diff mbox series

[2/2] dhcp.cgi: Adjust legend entries to make clear they are legends and not messages

Message ID 20240101143546.10272-2-adolf.belka@ipfire.org
State Staged
Commit f16eeae07853bf8b7bc8e740a74f9f9b28cadb1d
Headers
Series [1/2] dhcp.cgi: Adjust spacing between an icon and explanatory text |

Commit Message

Adolf Belka Jan. 1, 2024, 2:35 p.m. UTC 
  - A new IPFire user on the forum saw the orange and red coloured blocks in the legend
   section and believed that they were messages about problems that had been created with
   the fixed leases.
- This change puts a small block with seperate explanatory text for both the orange and
   red coloured blocks.
- This change will also be applied to the wiki in a much clearer way

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/dhcp.cgi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

jon Jan. 1, 2024, 4:53 p.m. UTC | #1 
Appreciated-by: Jon Murphy <jon.murphy@ipfire.org>

New tag in appreciation of the effort! 

Happy New Year!

> On Jan 1, 2024, at 8:35 AM, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - A new IPFire user on the forum saw the orange and red coloured blocks in the legend
>   section and believed that they were messages about problems that had been created with
>   the fixed leases.
> - This change puts a small block with seperate explanatory text for both the orange and
>   red coloured blocks.
> - This change will also be applied to the wiki in a much clearer way
> 
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> html/cgi-bin/dhcp.cgi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
> index ec5d62657..c079fe1ae 100644
> --- a/html/cgi-bin/dhcp.cgi
> +++ b/html/cgi-bin/dhcp.cgi
> @@ -1164,10 +1164,10 @@ print <<END
> </tr>
> <tr>
> 	<td>&nbsp;</td>
> -	<td>&nbsp;</td>
> -	<td class='base orange'>$Lang::tr{'ip address outside subnets'}</td>
> -        <td>&nbsp;&nbsp</td>
> -        <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td>
> +	<td class='base orange'>&nbsp;</td>
> +	<td class='base'>&nbsp;$Lang::tr{'ip address outside subnets'}&emsp;</td>
> +       <td class='base red'>&nbsp;</td>
> +       <td class='base'>&nbsp;$Lang::tr{'dhcp fixed ip address in dynamic range'}</td>
> 	<td>&nbsp;</td>
> 	<td>&nbsp;</td>
> 	$dup
> -- 
> 2.43.0
>
Bernhard Bitsch Jan. 1, 2024, 5:07 p.m. UTC | #2 
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 01.01.2024 um 15:35 schrieb Adolf Belka:
> - A new IPFire user on the forum saw the orange and red coloured blocks in the legend
>     section and believed that they were messages about problems that had been created with
>     the fixed leases.
> - This change puts a small block with seperate explanatory text for both the orange and
>     red coloured blocks.
> - This change will also be applied to the wiki in a much clearer way
> 
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   html/cgi-bin/dhcp.cgi | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
> index ec5d62657..c079fe1ae 100644
> --- a/html/cgi-bin/dhcp.cgi
> +++ b/html/cgi-bin/dhcp.cgi
> @@ -1164,10 +1164,10 @@ print <<END
>   </tr>
>   <tr>
>   	<td>&nbsp;</td>
> -	<td>&nbsp;</td>
> -	<td class='base orange'>$Lang::tr{'ip address outside subnets'}</td>
> -        <td>&nbsp;&nbsp</td>
> -        <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td>
> +	<td class='base orange'>&nbsp;</td>
> +	<td class='base'>&nbsp;$Lang::tr{'ip address outside subnets'}&emsp;</td>
> +       <td class='base red'>&nbsp;</td>
> +       <td class='base'>&nbsp;$Lang::tr{'dhcp fixed ip address in dynamic range'}</td>
>   	<td>&nbsp;</td>
>   	<td>&nbsp;</td>
>   	$dup
diff mbox series

Patch

diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
index ec5d62657..c079fe1ae 100644
--- a/html/cgi-bin/dhcp.cgi
+++ b/html/cgi-bin/dhcp.cgi
@@ -1164,10 +1164,10 @@  print <<END
 </tr>
 <tr>
 	<td>&nbsp;</td>
-	<td>&nbsp;</td>
-	<td class='base orange'>$Lang::tr{'ip address outside subnets'}</td>
-        <td>&nbsp;&nbsp</td>
-        <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td>
+	<td class='base orange'>&nbsp;</td>
+	<td class='base'>&nbsp;$Lang::tr{'ip address outside subnets'}&emsp;</td>
+       <td class='base red'>&nbsp;</td>
+       <td class='base'>&nbsp;$Lang::tr{'dhcp fixed ip address in dynamic range'}</td>
 	<td>&nbsp;</td>
 	<td>&nbsp;</td>
 	$dup