[2/2] dhcp.cgi: Adjust legend entries to make clear they are legends and not messages
Message ID | 20240101143546.10272-2-adolf.belka@ipfire.org |
---|---|
State | Accepted |
Commit | f16eeae07853bf8b7bc8e740a74f9f9b28cadb1d |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4T3dnq4vGZz3wmk for <patchwork@web04.haj.ipfire.org>; Mon, 1 Jan 2024 14:35:59 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4T3dnp07Bbz15D; Mon, 1 Jan 2024 14:35:58 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4T3dnn6dBzz30J8; Mon, 1 Jan 2024 14:35:57 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4T3dnh0ZFtz32M0 for <development@lists.ipfire.org>; Mon, 1 Jan 2024 14:35:52 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4T3dng5llgzYj; Mon, 1 Jan 2024 14:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1704119751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bJVD1erloi3lK9nsgi5C2B4qh4QTFRcDiNigeDIwrHQ=; b=Fuz/zjtDx+yfwok3zzn+wH/4GkWaTAYJ4R8yiq3503A+5vVG+eWsbG6RPh6gViPKedO9um m7WL7Ub0BRsL9GgC7CZViC6JlOK38rjvFleiOISIFTNn1sxz8PKLkO7xmz6SDvq+53gn29 dkQCFWE3vDX/g9+foLqKVIMvBGufdBwHA9CQJByNp9AJv2sGVJUjdc0OUjsEtY8x6idUYb yob30EA9Zyb8vUcFedsiSZG0Bqk0/qBaS7Vychj70B1VitIP/BvcCbv9osMQpO7vIWNP2m ah5IvU2gRFIOAHFUVUYlNVF5lliszkzWyNh6yGqTqrpgYlCNvj0kgYmmUwojkg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1704119751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bJVD1erloi3lK9nsgi5C2B4qh4QTFRcDiNigeDIwrHQ=; b=oAd3/YWQ+XRgKQgcAJEe9M6sQZl0ZIWqu+RQYMu5zIqLTqK/aOkyltGNs7fU3JyYvIY4wU HuIYIi3O+dBgpRDQ== From: Adolf Belka <adolf.belka@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH 2/2] dhcp.cgi: Adjust legend entries to make clear they are legends and not messages Date: Mon, 1 Jan 2024 15:35:46 +0100 Message-ID: <20240101143546.10272-2-adolf.belka@ipfire.org> In-Reply-To: <20240101143546.10272-1-adolf.belka@ipfire.org> References: <20240101143546.10272-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: LIBCXLF7IWD45AEDETAYGZRGP3VHH4GJ X-Message-ID-Hash: LIBCXLF7IWD45AEDETAYGZRGP3VHH4GJ X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> Archived-At: <https://lists.ipfire.org/hyperkitty/list/development@lists.ipfire.org/message/LIBCXLF7IWD45AEDETAYGZRGP3VHH4GJ/> List-Archive: <https://lists.ipfire.org/hyperkitty/list/development@lists.ipfire.org/> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Owner: <mailto:development-owner@lists.ipfire.org> List-Post: <mailto:development@lists.ipfire.org> List-Subscribe: <mailto:development-join@lists.ipfire.org> List-Unsubscribe: <mailto:development-leave@lists.ipfire.org> |
Series |
[1/2] dhcp.cgi: Adjust spacing between an icon and explanatory text
|
|
Commit Message
Adolf Belka
Jan. 1, 2024, 2:35 p.m. UTC
- A new IPFire user on the forum saw the orange and red coloured blocks in the legend section and believed that they were messages about problems that had been created with the fixed leases. - This change puts a small block with seperate explanatory text for both the orange and red coloured blocks. - This change will also be applied to the wiki in a much clearer way Tested-by: Adolf Belka <adolf.belka@ipfire.org> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> --- html/cgi-bin/dhcp.cgi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Comments
Appreciated-by: Jon Murphy <jon.murphy@ipfire.org> New tag in appreciation of the effort! Happy New Year! > On Jan 1, 2024, at 8:35 AM, Adolf Belka <adolf.belka@ipfire.org> wrote: > > - A new IPFire user on the forum saw the orange and red coloured blocks in the legend > section and believed that they were messages about problems that had been created with > the fixed leases. > - This change puts a small block with seperate explanatory text for both the orange and > red coloured blocks. > - This change will also be applied to the wiki in a much clearer way > > Tested-by: Adolf Belka <adolf.belka@ipfire.org> > Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> > --- > html/cgi-bin/dhcp.cgi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi > index ec5d62657..c079fe1ae 100644 > --- a/html/cgi-bin/dhcp.cgi > +++ b/html/cgi-bin/dhcp.cgi > @@ -1164,10 +1164,10 @@ print <<END > </tr> > <tr> > <td> </td> > - <td> </td> > - <td class='base orange'>$Lang::tr{'ip address outside subnets'}</td> > - <td>  </td> > - <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td> > + <td class='base orange'> </td> > + <td class='base'> $Lang::tr{'ip address outside subnets'} </td> > + <td class='base red'> </td> > + <td class='base'> $Lang::tr{'dhcp fixed ip address in dynamic range'}</td> > <td> </td> > <td> </td> > $dup > -- > 2.43.0 >
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> Am 01.01.2024 um 15:35 schrieb Adolf Belka: > - A new IPFire user on the forum saw the orange and red coloured blocks in the legend > section and believed that they were messages about problems that had been created with > the fixed leases. > - This change puts a small block with seperate explanatory text for both the orange and > red coloured blocks. > - This change will also be applied to the wiki in a much clearer way > > Tested-by: Adolf Belka <adolf.belka@ipfire.org> > Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> > --- > html/cgi-bin/dhcp.cgi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi > index ec5d62657..c079fe1ae 100644 > --- a/html/cgi-bin/dhcp.cgi > +++ b/html/cgi-bin/dhcp.cgi > @@ -1164,10 +1164,10 @@ print <<END > </tr> > <tr> > <td> </td> > - <td> </td> > - <td class='base orange'>$Lang::tr{'ip address outside subnets'}</td> > - <td>  </td> > - <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td> > + <td class='base orange'> </td> > + <td class='base'> $Lang::tr{'ip address outside subnets'} </td> > + <td class='base red'> </td> > + <td class='base'> $Lang::tr{'dhcp fixed ip address in dynamic range'}</td> > <td> </td> > <td> </td> > $dup
diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi index ec5d62657..c079fe1ae 100644 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -1164,10 +1164,10 @@ print <<END </tr> <tr> <td> </td> - <td> </td> - <td class='base orange'>$Lang::tr{'ip address outside subnets'}</td> - <td>  </td> - <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td> + <td class='base orange'> </td> + <td class='base'> $Lang::tr{'ip address outside subnets'} </td> + <td class='base red'> </td> + <td class='base'> $Lang::tr{'dhcp fixed ip address in dynamic range'}</td> <td> </td> <td> </td> $dup