From patchwork Mon Jan 1 14:35:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7430 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4T3dnn65SDz3wmk for ; Mon, 1 Jan 2024 14:35:57 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4T3dnk50syzYj; Mon, 1 Jan 2024 14:35:54 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4T3dnk1lTyz32Sw; Mon, 1 Jan 2024 14:35:54 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4T3dnh0460z30J8 for ; Mon, 1 Jan 2024 14:35:51 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4T3dng0Nf7z8X; Mon, 1 Jan 2024 14:35:51 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1704119751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jWWCNze7RI9QIszBlbLt+Jw6Ba2lLG1GelAjDCBzqUY=; b=X8N6VyMB99lsUF38g+1qBEgUF+HR8qxaL0arcTnqC3zyfxaFYmGHINUYV30RijRbuOLXAg f2qxIU5HSgoHERCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1704119751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jWWCNze7RI9QIszBlbLt+Jw6Ba2lLG1GelAjDCBzqUY=; b=T9RxMIKOxSEwe4N1FySA4RRzfK6u94710x3l4pZSyWhyvO9VMHz/bfuPhbo0WnWLVpm6Fh R8r/36L5GbDmawnpTC8ue5SLauEJL/uKjdNqQt50MVcNmWroPgk0MqMz8Nvg3wOiWhj9Ly EA82Y7GoXkxehANN+8gjl63L2WfEN4siZ4bSQIxiQejAaCBOAoIbJyJG6YiqJhQgIXQNG3 CVqR9/pbDxGCjfvDYi02diuK1eog3hmK83aCbG0Xt5/7Rc4VgeXIHrav+jjmlK/XTxgvpN ZGaUxxABknNHcXr9RzaGOOzCXIorwwjRy911/W8QZF27zqFNpUyhRmS+dZjvYw== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 1/2] dhcp.cgi: Adjust spacing between an icon and explanatory text Date: Mon, 1 Jan 2024 15:35:45 +0100 Message-ID: <20240101143546.10272-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: LHN6K7LAQYYUGX7SYLDXCXBWGEQI3MEJ X-Message-ID-Hash: LHN6K7LAQYYUGX7SYLDXCXBWGEQI3MEJ X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - When dealing with a problem on the forum I noticed that in the Fixed Leases table Legend section there was a very large space between the empty checkbox icon and the explanatory text. It looks like the   that I have removed worked on the text section 'click to enable' as that was moved but not on the off.gif icon as that stayed in its original place leaving a very large space between the icon and the explanatory text. Removing the two   commands fixes that. - Reading up about   the problem might be related to these tags no longer being recommended to use with the newer HTML versions and that indenting or spacing should be done via CSS code. Will have a look in future on how to accomplish this via CSS. Tested-by: Adolf Belka Signed-off-by: Adolf Belka Reviewed-by: Bernhard Bitsch --- html/cgi-bin/dhcp.cgi | 1 - 1 file changed, 1 deletion(-) mode change 100755 => 100644 html/cgi-bin/dhcp.cgi diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi old mode 100755 new mode 100644 index 84e2322af..ec5d62657 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -1153,7 +1153,6 @@ print < $Lang::tr{'legend'}:  $Lang::tr{ $Lang::tr{'click to disable'} -    $Lang::tr{ $Lang::tr{'click to enable'}    From patchwork Mon Jan 1 14:35:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7431 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4T3dnq4vGZz3wmk for ; Mon, 1 Jan 2024 14:35:59 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4T3dnp07Bbz15D; Mon, 1 Jan 2024 14:35:58 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4T3dnn6dBzz30J8; Mon, 1 Jan 2024 14:35:57 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4T3dnh0ZFtz32M0 for ; Mon, 1 Jan 2024 14:35:52 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4T3dng5llgzYj; Mon, 1 Jan 2024 14:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1704119751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bJVD1erloi3lK9nsgi5C2B4qh4QTFRcDiNigeDIwrHQ=; b=Fuz/zjtDx+yfwok3zzn+wH/4GkWaTAYJ4R8yiq3503A+5vVG+eWsbG6RPh6gViPKedO9um m7WL7Ub0BRsL9GgC7CZViC6JlOK38rjvFleiOISIFTNn1sxz8PKLkO7xmz6SDvq+53gn29 dkQCFWE3vDX/g9+foLqKVIMvBGufdBwHA9CQJByNp9AJv2sGVJUjdc0OUjsEtY8x6idUYb yob30EA9Zyb8vUcFedsiSZG0Bqk0/qBaS7Vychj70B1VitIP/BvcCbv9osMQpO7vIWNP2m ah5IvU2gRFIOAHFUVUYlNVF5lliszkzWyNh6yGqTqrpgYlCNvj0kgYmmUwojkg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1704119751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bJVD1erloi3lK9nsgi5C2B4qh4QTFRcDiNigeDIwrHQ=; b=oAd3/YWQ+XRgKQgcAJEe9M6sQZl0ZIWqu+RQYMu5zIqLTqK/aOkyltGNs7fU3JyYvIY4wU HuIYIi3O+dBgpRDQ== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 2/2] dhcp.cgi: Adjust legend entries to make clear they are legends and not messages Date: Mon, 1 Jan 2024 15:35:46 +0100 Message-ID: <20240101143546.10272-2-adolf.belka@ipfire.org> In-Reply-To: <20240101143546.10272-1-adolf.belka@ipfire.org> References: <20240101143546.10272-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: LIBCXLF7IWD45AEDETAYGZRGP3VHH4GJ X-Message-ID-Hash: LIBCXLF7IWD45AEDETAYGZRGP3VHH4GJ X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - A new IPFire user on the forum saw the orange and red coloured blocks in the legend section and believed that they were messages about problems that had been created with the fixed leases. - This change puts a small block with seperate explanatory text for both the orange and red coloured blocks. - This change will also be applied to the wiki in a much clearer way Tested-by: Adolf Belka Signed-off-by: Adolf Belka Reviewed-by: Bernhard Bitsch --- html/cgi-bin/dhcp.cgi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi index ec5d62657..c079fe1ae 100644 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -1164,10 +1164,10 @@ print <   -   - $Lang::tr{'ip address outside subnets'} -    - $Lang::tr{'dhcp fixed ip address in dynamic range'} +   +  $Lang::tr{'ip address outside subnets'}  +   +  $Lang::tr{'dhcp fixed ip address in dynamic range'}     $dup