diff mbox series

[1/2] dhcp.cgi: Adjust spacing between an icon and explanatory text

Message ID 20240101143546.10272-1-adolf.belka@ipfire.org
State Accepted
Commit dcb878d6a11ee9b75b4d0752a12b2d68b8691c8e
Headers
Series [1/2] dhcp.cgi: Adjust spacing between an icon and explanatory text |

Commit Message

Adolf Belka Jan. 1, 2024, 2:35 p.m. UTC 
  - When dealing with a problem on the forum I noticed that in the Fixed Leases table
   Legend section there was a very large space between the empty checkbox icon and the
   explanatory text. It looks like the &nbsp that I have removed worked on the text
   section 'click to enable' as that was moved but not on the off.gif icon as that stayed
   in its original place leaving a very large space between the icon and the explanatory
   text. Removing the two   commands fixes that.
- Reading up about &nbsp the problem might be related to these tags no longer being
   recommended to use with the newer HTML versions and that indenting or spacing should be
   done via CSS code. Will have a look in future on how to accomplish this via CSS.

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/dhcp.cgi | 1 -
 1 file changed, 1 deletion(-)
 mode change 100755 => 100644 html/cgi-bin/dhcp.cgi

Comments

Bernhard Bitsch Jan. 1, 2024, 4:41 p.m. UTC | #1 
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 01.01.2024 um 15:35 schrieb Adolf Belka:
> - When dealing with a problem on the forum I noticed that in the Fixed Leases table
>     Legend section there was a very large space between the empty checkbox icon and the
>     explanatory text. It looks like the &nbsp that I have removed worked on the text
>     section 'click to enable' as that was moved but not on the off.gif icon as that stayed
>     in its original place leaving a very large space between the icon and the explanatory
>     text. Removing the two &nbsp; commands fixes that.
> - Reading up about &nbsp the problem might be related to these tags no longer being
>     recommended to use with the newer HTML versions and that indenting or spacing should be
>     done via CSS code. Will have a look in future on how to accomplish this via CSS.
> 
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   html/cgi-bin/dhcp.cgi | 1 -
>   1 file changed, 1 deletion(-)
>   mode change 100755 => 100644 html/cgi-bin/dhcp.cgi
> 
> diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
> old mode 100755
> new mode 100644
> index 84e2322af..ec5d62657
> --- a/html/cgi-bin/dhcp.cgi
> +++ b/html/cgi-bin/dhcp.cgi
> @@ -1153,7 +1153,6 @@ print <<END
>   	<td class='boldbase'>&nbsp;<b>$Lang::tr{'legend'}:&nbsp;</b></td>
>   	<td><img src='/images/on.gif' alt='$Lang::tr{'click to disable'}' /></td>
>   	<td class='base'>$Lang::tr{'click to disable'}</td>
> -	<td>&nbsp;&nbsp;</td>
>   	<td><img src='/images/off.gif' alt='$Lang::tr{'click to enable'}' /></td>
>   	<td class='base'>$Lang::tr{'click to enable'}</td>
>   	<td>&nbsp;&nbsp;</td>
diff mbox series

Patch

diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
old mode 100755
new mode 100644
index 84e2322af..ec5d62657
--- a/html/cgi-bin/dhcp.cgi
+++ b/html/cgi-bin/dhcp.cgi
@@ -1153,7 +1153,6 @@  print <<END
 	<td class='boldbase'>&nbsp;<b>$Lang::tr{'legend'}:&nbsp;</b></td>
 	<td><img src='/images/on.gif' alt='$Lang::tr{'click to disable'}' /></td>
 	<td class='base'>$Lang::tr{'click to disable'}</td>
-	<td>&nbsp;&nbsp;</td>
 	<td><img src='/images/off.gif' alt='$Lang::tr{'click to enable'}' /></td>
 	<td class='base'>$Lang::tr{'click to enable'}</td>
 	<td>&nbsp;&nbsp;</td>