[2/2] iptables: Do not ship libxt_ddcp.so

Message ID 8d581c78-6627-58ee-b095-055b895a810d@ipfire.org
State New
Headers show
Series [1/2] iproute2: Do not ship /sbin/tipc | expand

Commit Message

Peter Müller March 19, 2022, 3:32 p.m. UTC
DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not
even available as a kernel module. Therefore, there is no sense in
shipping this module, since it cannot do anything.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 config/rootfiles/common/iptables | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Adolf Belka March 19, 2022, 9:54 p.m. UTC | #1
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org>

On 19/03/2022 16:32, Peter Müller wrote:
> DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not
> even available as a kernel module. Therefore, there is no sense in
> shipping this module, since it cannot do anything.
>
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
>   config/rootfiles/common/iptables | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables
> index b8bf748a5..559958b43 100644
> --- a/config/rootfiles/common/iptables
> +++ b/config/rootfiles/common/iptables
> @@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so
>   lib/xtables/libxt_connmark.so
>   lib/xtables/libxt_conntrack.so
>   lib/xtables/libxt_cpu.so
> -lib/xtables/libxt_dccp.so
> +#lib/xtables/libxt_dccp.so
>   lib/xtables/libxt_devgroup.so
>   lib/xtables/libxt_dscp.so
>   lib/xtables/libxt_ecn.so
Michael Tremer March 21, 2022, 8:49 a.m. UTC | #2
Hello Peter,

I am not sure whether I like the patch.

It becomes difficult and tiresome to keep track of these changes when the next update is due and I would prefer it, if the file wouldn’t be there in the first place. Because then, the next update cannot accidentally ship the file again.

Is there a —-disable-dccp option?

-Michael

> On 19 Mar 2022, at 15:32, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not
> even available as a kernel module. Therefore, there is no sense in
> shipping this module, since it cannot do anything.
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> config/rootfiles/common/iptables | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables
> index b8bf748a5..559958b43 100644
> --- a/config/rootfiles/common/iptables
> +++ b/config/rootfiles/common/iptables
> @@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so
> lib/xtables/libxt_connmark.so
> lib/xtables/libxt_conntrack.so
> lib/xtables/libxt_cpu.so
> -lib/xtables/libxt_dccp.so
> +#lib/xtables/libxt_dccp.so
> lib/xtables/libxt_devgroup.so
> lib/xtables/libxt_dscp.so
> lib/xtables/libxt_ecn.so
> -- 
> 2.34.1

Patch

diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables
index b8bf748a5..559958b43 100644
--- a/config/rootfiles/common/iptables
+++ b/config/rootfiles/common/iptables
@@ -86,7 +86,7 @@  lib/xtables/libxt_connlimit.so
 lib/xtables/libxt_connmark.so
 lib/xtables/libxt_conntrack.so
 lib/xtables/libxt_cpu.so
-lib/xtables/libxt_dccp.so
+#lib/xtables/libxt_dccp.so
 lib/xtables/libxt_devgroup.so
 lib/xtables/libxt_dscp.so
 lib/xtables/libxt_ecn.so