Message ID | 8d581c78-6627-58ee-b095-055b895a810d@ipfire.org |
---|---|
State | Dropped |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4KLPyx61Q3z3wt4 for <patchwork@web04.haj.ipfire.org>; Sat, 19 Mar 2022 15:32:57 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4KLPyw75G2z18B; Sat, 19 Mar 2022 15:32:56 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4KLPyw6SRhz301g; Sat, 19 Mar 2022 15:32:56 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4KLPyv3NX1z2xWt for <development@lists.ipfire.org>; Sat, 19 Mar 2022 15:32:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4KLPyt4fXZzXD for <development@lists.ipfire.org>; Sat, 19 Mar 2022 15:32:54 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1647703975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QQq3rw2LuzZncEBhlBFLg3CdDsXUjhADa3kYSWkqYPs=; b=z0iUp/zEZuxccXrif2XYZF2QhUjPY2XVpdjwJJPliRB9sH/FYjxMoaxHVCZF77FR4cYbBi CG5RRTPbTUFs60CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1647703975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QQq3rw2LuzZncEBhlBFLg3CdDsXUjhADa3kYSWkqYPs=; b=B4c4DiBrV558Zx1mllvVw8wqVK4jJDJPbJh8VzPcR4tB42JQsPfxOvvBwNK0AwsN8EgPor BHExRrtzWIjDGVTMbwa3xjovADWukLga33OYdBw0CAAm4+aCT5SKMGY12OtXCcVSzMeB3D 0YeWwoo0jX8j5pC73trAifD+WLmNlxy0+ik507REEi9HhbmSqlW7uIYVA5Ir2fOHFrNHB5 uEFYxASDVeUh8u78bb9kOXRFvv9x24//1OLBTtgeBN1N8nI4+4R+gAQjJuoWikvdpq5PQq 64mox1vJrqKT++Kb5cvgbTS6bzRZYCd+KMaNMNQM084AQBkV4JOG6U0A/xC8Ig== Message-ID: <8d581c78-6627-58ee-b095-055b895a810d@ipfire.org> Date: Sat, 19 Mar 2022 15:32:52 +0000 MIME-Version: 1.0 Subject: [PATCH 2/2] iptables: Do not ship libxt_ddcp.so Content-Language: en-US To: development@lists.ipfire.org References: <13403096-2b54-7005-3eb6-32ce67179f3b@ipfire.org> From: =?utf-8?q?Peter_M=C3=BCller?= <peter.mueller@ipfire.org> In-Reply-To: <13403096-2b54-7005-3eb6-32ce67179f3b@ipfire.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
[1/2] iproute2: Do not ship /sbin/tipc
|
|
Commit Message
Peter Müller
March 19, 2022, 3:32 p.m. UTC
DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not
even available as a kernel module. Therefore, there is no sense in
shipping this module, since it cannot do anything.
Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
config/rootfiles/common/iptables | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org> On 19/03/2022 16:32, Peter Müller wrote: > DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not > even available as a kernel module. Therefore, there is no sense in > shipping this module, since it cannot do anything. > > Signed-off-by: Peter Müller <peter.mueller@ipfire.org> > --- > config/rootfiles/common/iptables | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables > index b8bf748a5..559958b43 100644 > --- a/config/rootfiles/common/iptables > +++ b/config/rootfiles/common/iptables > @@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so > lib/xtables/libxt_connmark.so > lib/xtables/libxt_conntrack.so > lib/xtables/libxt_cpu.so > -lib/xtables/libxt_dccp.so > +#lib/xtables/libxt_dccp.so > lib/xtables/libxt_devgroup.so > lib/xtables/libxt_dscp.so > lib/xtables/libxt_ecn.so
Hello Peter, I am not sure whether I like the patch. It becomes difficult and tiresome to keep track of these changes when the next update is due and I would prefer it, if the file wouldn’t be there in the first place. Because then, the next update cannot accidentally ship the file again. Is there a —-disable-dccp option? -Michael > On 19 Mar 2022, at 15:32, Peter Müller <peter.mueller@ipfire.org> wrote: > > DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not > even available as a kernel module. Therefore, there is no sense in > shipping this module, since it cannot do anything. > > Signed-off-by: Peter Müller <peter.mueller@ipfire.org> > --- > config/rootfiles/common/iptables | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables > index b8bf748a5..559958b43 100644 > --- a/config/rootfiles/common/iptables > +++ b/config/rootfiles/common/iptables > @@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so > lib/xtables/libxt_connmark.so > lib/xtables/libxt_conntrack.so > lib/xtables/libxt_cpu.so > -lib/xtables/libxt_dccp.so > +#lib/xtables/libxt_dccp.so > lib/xtables/libxt_devgroup.so > lib/xtables/libxt_dscp.so > lib/xtables/libxt_ecn.so > -- > 2.34.1
diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables index b8bf748a5..559958b43 100644 --- a/config/rootfiles/common/iptables +++ b/config/rootfiles/common/iptables @@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so lib/xtables/libxt_connmark.so lib/xtables/libxt_conntrack.so lib/xtables/libxt_cpu.so -lib/xtables/libxt_dccp.so +#lib/xtables/libxt_dccp.so lib/xtables/libxt_devgroup.so lib/xtables/libxt_dscp.so lib/xtables/libxt_ecn.so