udev: do not generate manpages

Message ID 410cbebf-096b-4c57-0601-421dbc3dd5f8@ipfire.org
State New
Headers show
Series udev: do not generate manpages | expand

Commit Message

Peter Müller May 23, 2021, 3:46 p.m. UTC
This is probably a typo and was meant to read "--disable-manpages" in
the first place.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 lfs/udev | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Adolf Belka May 23, 2021, 8:28 p.m. UTC | #1
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org>

On 23/05/2021 17:46, Peter Müller wrote:
> This is probably a typo and was meant to read "--disable-manpages" in
> the first place.
>
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
>   lfs/udev | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lfs/udev b/lfs/udev
> index b578ab54c..11868ffe2 100644
> --- a/lfs/udev
> +++ b/lfs/udev
> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>   		--libexecdir=/lib \
>   		--with-rootprefix= \
>   		--with-rootlibdir=/lib \
> -		--enable-manpages \
> +		--disable-manpages \
>   		--disable-static
>   
>   	cd $(DIR_APP) && make $(MAKETUNING)
Michael Tremer May 25, 2021, 9:53 a.m. UTC | #2
Hello,

cool. Is the root file update coming in an extra patch?

-Michael

> On 23 May 2021, at 16:46, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> This is probably a typo and was meant to read "--disable-manpages" in
> the first place.
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> lfs/udev | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lfs/udev b/lfs/udev
> index b578ab54c..11868ffe2 100644
> --- a/lfs/udev
> +++ b/lfs/udev
> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> 		--libexecdir=/lib \
> 		--with-rootprefix= \
> 		--with-rootlibdir=/lib \
> -		--enable-manpages \
> +		--disable-manpages \
> 		--disable-static
> 
> 	cd $(DIR_APP) && make $(MAKETUNING)
> -- 
> 2.26.2
Peter Müller May 25, 2021, 7:40 p.m. UTC | #3
Hello Michael,

thanks for your reply.

No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken?

Thanks, and best regards,
Peter Müller

> Hello,
> 
> cool. Is the root file update coming in an extra patch?
> 
> -Michael
> 
>> On 23 May 2021, at 16:46, Peter Müller <peter.mueller@ipfire.org> wrote:
>>
>> This is probably a typo and was meant to read "--disable-manpages" in
>> the first place.
>>
>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
>> ---
>> lfs/udev | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lfs/udev b/lfs/udev
>> index b578ab54c..11868ffe2 100644
>> --- a/lfs/udev
>> +++ b/lfs/udev
>> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>> 		--libexecdir=/lib \
>> 		--with-rootprefix= \
>> 		--with-rootlibdir=/lib \
>> -		--enable-manpages \
>> +		--disable-manpages \
>> 		--disable-static
>>
>> 	cd $(DIR_APP) && make $(MAKETUNING)
>> -- 
>> 2.26.2
>
Michael Tremer May 25, 2021, 7:57 p.m. UTC | #4
The root file contains man-pages. Disabling them should make them disappear, or what is the point of the whole patch?

> On 25 May 2021, at 20:40, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> Hello Michael,
> 
> thanks for your reply.
> 
> No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken?
> 
> Thanks, and best regards,
> Peter Müller
> 
>> Hello,
>> 
>> cool. Is the root file update coming in an extra patch?
>> 
>> -Michael
>> 
>>> On 23 May 2021, at 16:46, Peter Müller <peter.mueller@ipfire.org> wrote:
>>> 
>>> This is probably a typo and was meant to read "--disable-manpages" in
>>> the first place.
>>> 
>>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
>>> ---
>>> lfs/udev | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/lfs/udev b/lfs/udev
>>> index b578ab54c..11868ffe2 100644
>>> --- a/lfs/udev
>>> +++ b/lfs/udev
>>> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>>> 		--libexecdir=/lib \
>>> 		--with-rootprefix= \
>>> 		--with-rootlibdir=/lib \
>>> -		--enable-manpages \
>>> +		--disable-manpages \
>>> 		--disable-static
>>> 
>>> 	cd $(DIR_APP) && make $(MAKETUNING)
>>> -- 
>>> 2.26.2
>>
Peter Müller May 25, 2021, 8:03 p.m. UTC | #5
Hello Michael,

hm, interesting. I cannot recall the build on my workstation to complain about changed rootfiles...

May I ask you to fix that for me?

Thanks in advance, sorry, and best regards,
Peter Müller


> The root file contains man-pages. Disabling them should make them disappear, or what is the point of the whole patch?
> 
>> On 25 May 2021, at 20:40, Peter Müller <peter.mueller@ipfire.org> wrote:
>>
>> Hello Michael,
>>
>> thanks for your reply.
>>
>> No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken?
>>
>> Thanks, and best regards,
>> Peter Müller
>>
>>> Hello,
>>>
>>> cool. Is the root file update coming in an extra patch?
>>>
>>> -Michael
>>>
>>>> On 23 May 2021, at 16:46, Peter Müller <peter.mueller@ipfire.org> wrote:
>>>>
>>>> This is probably a typo and was meant to read "--disable-manpages" in
>>>> the first place.
>>>>
>>>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
>>>> ---
>>>> lfs/udev | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lfs/udev b/lfs/udev
>>>> index b578ab54c..11868ffe2 100644
>>>> --- a/lfs/udev
>>>> +++ b/lfs/udev
>>>> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>>>> 		--libexecdir=/lib \
>>>> 		--with-rootprefix= \
>>>> 		--with-rootlibdir=/lib \
>>>> -		--enable-manpages \
>>>> +		--disable-manpages \
>>>> 		--disable-static
>>>>
>>>> 	cd $(DIR_APP) && make $(MAKETUNING)
>>>> -- 
>>>> 2.26.2
>>>
>

Patch

diff --git a/lfs/udev b/lfs/udev
index b578ab54c..11868ffe2 100644
--- a/lfs/udev
+++ b/lfs/udev
@@ -84,7 +84,7 @@  $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 		--libexecdir=/lib \
 		--with-rootprefix= \
 		--with-rootlibdir=/lib \
-		--enable-manpages \
+		--disable-manpages \
 		--disable-static
 
 	cd $(DIR_APP) && make $(MAKETUNING)