| Message ID | 410cbebf-096b-4c57-0601-421dbc3dd5f8@ipfire.org |
|---|---|
| State | Dropped |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4Fp4TJ4JxKz3wbl for <patchwork@web04.haj.ipfire.org>; Sun, 23 May 2021 15:46:44 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4Fp4TH48xhzwn; Sun, 23 May 2021 15:46:43 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4Fp4TH2VvNz2y55; Sun, 23 May 2021 15:46:43 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Fp4TG299Yz2xb4 for <development@lists.ipfire.org>; Sun, 23 May 2021 15:46:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4Fp4TD6LFpz81 for <development@lists.ipfire.org>; Sun, 23 May 2021 15:46:40 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1621784801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i9u0t8qMKxXjjtoLYv+Q0jTaSC1157Kaq1jxZ+Kto9Q=; b=57vPCP+3OaDWtydu5ZoPzmEkW37DOAcw2yoSQh5vnGMK9oiFy3+oILPyEvGXgLbnbyOewT r9CxI7k+Qs+zB9CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1621784801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i9u0t8qMKxXjjtoLYv+Q0jTaSC1157Kaq1jxZ+Kto9Q=; b=pGrsnvKuXSUwApgAqhveVCVAO/EeEN/3qZGGhNWDNSK04jlFAGcf1a3u7+Ql/IXRJSA9gi 0UOdo7QSW72poUrd5Rc/gD63D2U8uuhTbg7QjwTQnqVye/G3UAjmCSR/ypwyN+GIhg5Yzg hf7jhbvGyRijY5INzp3OjKxfNOwBo65M32H2QTZKI0Mn51nfBigeK3D5wkZIAhEpaI3Ku9 8jZwI9mxQaZDbm1cXWjhhK8BaWM9O7X6vV9el5x7m5NNSCXvvlSlnm8aTQHjDN3d1m8CBK ACAsK0Z2YK7fW9aMxfKzSRLNWMRHtFYRQRXhraCXtA6QW/5LfA1CNS4rRcnCkw== To: "IPFire: Development" <development@lists.ipfire.org> From: =?utf-8?q?Peter_M=C3=BCller?= <peter.mueller@ipfire.org> Subject: [PATCH] udev: do not generate manpages Message-ID: <410cbebf-096b-4c57-0601-421dbc3dd5f8@ipfire.org> Date: Sun, 23 May 2021 17:46:38 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
| Series |
udev: do not generate manpages
|
|
Commit Message
Peter Müller
May 23, 2021, 3:46 p.m. UTC
This is probably a typo and was meant to read "--disable-manpages" in
the first place.
Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
lfs/udev | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org> On 23/05/2021 17:46, Peter Müller wrote: > This is probably a typo and was meant to read "--disable-manpages" in > the first place. > > Signed-off-by: Peter Müller <peter.mueller@ipfire.org> > --- > lfs/udev | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lfs/udev b/lfs/udev > index b578ab54c..11868ffe2 100644 > --- a/lfs/udev > +++ b/lfs/udev > @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > --libexecdir=/lib \ > --with-rootprefix= \ > --with-rootlibdir=/lib \ > - --enable-manpages \ > + --disable-manpages \ > --disable-static > > cd $(DIR_APP) && make $(MAKETUNING)
Hello, cool. Is the root file update coming in an extra patch? -Michael > On 23 May 2021, at 16:46, Peter Müller <peter.mueller@ipfire.org> wrote: > > This is probably a typo and was meant to read "--disable-manpages" in > the first place. > > Signed-off-by: Peter Müller <peter.mueller@ipfire.org> > --- > lfs/udev | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lfs/udev b/lfs/udev > index b578ab54c..11868ffe2 100644 > --- a/lfs/udev > +++ b/lfs/udev > @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > --libexecdir=/lib \ > --with-rootprefix= \ > --with-rootlibdir=/lib \ > - --enable-manpages \ > + --disable-manpages \ > --disable-static > > cd $(DIR_APP) && make $(MAKETUNING) > -- > 2.26.2
Hello Michael, thanks for your reply. No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken? Thanks, and best regards, Peter Müller > Hello, > > cool. Is the root file update coming in an extra patch? > > -Michael > >> On 23 May 2021, at 16:46, Peter Müller <peter.mueller@ipfire.org> wrote: >> >> This is probably a typo and was meant to read "--disable-manpages" in >> the first place. >> >> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >> --- >> lfs/udev | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lfs/udev b/lfs/udev >> index b578ab54c..11868ffe2 100644 >> --- a/lfs/udev >> +++ b/lfs/udev >> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >> --libexecdir=/lib \ >> --with-rootprefix= \ >> --with-rootlibdir=/lib \ >> - --enable-manpages \ >> + --disable-manpages \ >> --disable-static >> >> cd $(DIR_APP) && make $(MAKETUNING) >> -- >> 2.26.2 >
The root file contains man-pages. Disabling them should make them disappear, or what is the point of the whole patch? > On 25 May 2021, at 20:40, Peter Müller <peter.mueller@ipfire.org> wrote: > > Hello Michael, > > thanks for your reply. > > No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken? > > Thanks, and best regards, > Peter Müller > >> Hello, >> >> cool. Is the root file update coming in an extra patch? >> >> -Michael >> >>> On 23 May 2021, at 16:46, Peter Müller <peter.mueller@ipfire.org> wrote: >>> >>> This is probably a typo and was meant to read "--disable-manpages" in >>> the first place. >>> >>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >>> --- >>> lfs/udev | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/lfs/udev b/lfs/udev >>> index b578ab54c..11868ffe2 100644 >>> --- a/lfs/udev >>> +++ b/lfs/udev >>> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >>> --libexecdir=/lib \ >>> --with-rootprefix= \ >>> --with-rootlibdir=/lib \ >>> - --enable-manpages \ >>> + --disable-manpages \ >>> --disable-static >>> >>> cd $(DIR_APP) && make $(MAKETUNING) >>> -- >>> 2.26.2 >>
Hello Michael, hm, interesting. I cannot recall the build on my workstation to complain about changed rootfiles... May I ask you to fix that for me? Thanks in advance, sorry, and best regards, Peter Müller > The root file contains man-pages. Disabling them should make them disappear, or what is the point of the whole patch? > >> On 25 May 2021, at 20:40, Peter Müller <peter.mueller@ipfire.org> wrote: >> >> Hello Michael, >> >> thanks for your reply. >> >> No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken? >> >> Thanks, and best regards, >> Peter Müller >> >>> Hello, >>> >>> cool. Is the root file update coming in an extra patch? >>> >>> -Michael >>> >>>> On 23 May 2021, at 16:46, Peter Müller <peter.mueller@ipfire.org> wrote: >>>> >>>> This is probably a typo and was meant to read "--disable-manpages" in >>>> the first place. >>>> >>>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >>>> --- >>>> lfs/udev | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/lfs/udev b/lfs/udev >>>> index b578ab54c..11868ffe2 100644 >>>> --- a/lfs/udev >>>> +++ b/lfs/udev >>>> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >>>> --libexecdir=/lib \ >>>> --with-rootprefix= \ >>>> --with-rootlibdir=/lib \ >>>> - --enable-manpages \ >>>> + --disable-manpages \ >>>> --disable-static >>>> >>>> cd $(DIR_APP) && make $(MAKETUNING) >>>> -- >>>> 2.26.2 >>> >
diff --git a/lfs/udev b/lfs/udev index b578ab54c..11868ffe2 100644 --- a/lfs/udev +++ b/lfs/udev @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) --libexecdir=/lib \ --with-rootprefix= \ --with-rootlibdir=/lib \ - --enable-manpages \ + --disable-manpages \ --disable-static cd $(DIR_APP) && make $(MAKETUNING)