[8/9] Revert "gcp-setup: Fixes bug12763"

Message ID 20240510120234.995049-8-michael.tremer@ipfire.org
State Staged
Commit 731d944b2b82ce30f604f7d79cc91f6a29ec637d
Headers
Series [1/9] ipsec-interfaces: Don't throw away errors when creating routes |

Commit Message

Michael Tremer May 10, 2024, 12:02 p.m. UTC
  This reverts commit 2841a675482879a5eb6bfeaabb268066af762e9d.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 src/initscripts/helper/gcp-setup | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Adolf Belka May 10, 2024, 3:24 p.m. UTC | #1
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org>

On 10/05/2024 14:02, Michael Tremer wrote:
> This reverts commit 2841a675482879a5eb6bfeaabb268066af762e9d.
>
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>   src/initscripts/helper/gcp-setup | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/initscripts/helper/gcp-setup b/src/initscripts/helper/gcp-setup
> index 8273b70b4..4f5148c3e 100644
> --- a/src/initscripts/helper/gcp-setup
> +++ b/src/initscripts/helper/gcp-setup
> @@ -268,8 +268,8 @@ case "${reason}" in
>   		ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}"
>   
>   		# Add the default route
> -		ip route add "${new_routers}" dev "${interface}" >/dev/null 2>&1
> -		ip route add default via "${new_routers}" >/dev/null 2>&1
> +		ip route add "${new_routers}" dev "${interface}"
> +		ip route add default via "${new_routers}"
>   
>   		# Setup DNS
>   		for domain_name_server in ${new_domain_name_servers}; do
  

Patch

diff --git a/src/initscripts/helper/gcp-setup b/src/initscripts/helper/gcp-setup
index 8273b70b4..4f5148c3e 100644
--- a/src/initscripts/helper/gcp-setup
+++ b/src/initscripts/helper/gcp-setup
@@ -268,8 +268,8 @@  case "${reason}" in
 		ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}"
 
 		# Add the default route
-		ip route add "${new_routers}" dev "${interface}" >/dev/null 2>&1
-		ip route add default via "${new_routers}" >/dev/null 2>&1
+		ip route add "${new_routers}" dev "${interface}"
+		ip route add default via "${new_routers}"
 
 		# Setup DNS
 		for domain_name_server in ${new_domain_name_servers}; do