diff mbox series

[1/9] ipsec-interfaces: Don't throw away errors when creating routes

Message ID 20240510120234.995049-1-michael.tremer@ipfire.org
State Staged
Commit c522d8109dcfa95c5a9b054276cbfb768af51b69
Headers
Series [1/9] ipsec-interfaces: Don't throw away errors when creating routes |

Commit Message

Michael Tremer May 10, 2024, 12:02 p.m. UTC 
  This partly reverts 87a97a431915849cf6d19e1b7137b4fb0b6dd91d.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 src/scripts/ipsec-interfaces | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Adolf Belka May 10, 2024, 3:21 p.m. UTC | #1 
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org>

On 10/05/2024 14:02, Michael Tremer wrote:
> This partly reverts 87a97a431915849cf6d19e1b7137b4fb0b6dd91d.
>
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>   src/scripts/ipsec-interfaces | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/scripts/ipsec-interfaces b/src/scripts/ipsec-interfaces
> index 974d3ac84..b05b2009c 100644
> --- a/src/scripts/ipsec-interfaces
> +++ b/src/scripts/ipsec-interfaces
> @@ -115,7 +115,7 @@ main() {
>   	# We are done when IPsec is not enabled
>   	if [ "${ENABLED}" = "on" ]; then
>   		# Enable route table lookup
> -		ip rule add lookup "${ROUTE_TABLE}" prio "${ROUTE_TABLE_PRIO}" >/dev/null 2>&1
> +		ip rule add lookup "${ROUTE_TABLE}" prio "${ROUTE_TABLE_PRIO}"
>   
>   		while IFS="," read -r "${VARS[@]}"; do
>   			# Check if the connection is enabled
> @@ -158,7 +158,7 @@ main() {
>   
>   						log "Creating route to ${rightsubnet} (via ${address} and ${RED_INTF})"
>   						ip route add table "${ROUTE_TABLE}" "${rightsubnet}" proto static \
> -							dev "${RED_INTF}" src "${address}" >/dev/null 2>&1
> +							dev "${RED_INTF}" src "${address}"
>   					done
>   
>   					# No interface processing required
diff mbox series

Patch

diff --git a/src/scripts/ipsec-interfaces b/src/scripts/ipsec-interfaces
index 974d3ac84..b05b2009c 100644
--- a/src/scripts/ipsec-interfaces
+++ b/src/scripts/ipsec-interfaces
@@ -115,7 +115,7 @@  main() {
 	# We are done when IPsec is not enabled
 	if [ "${ENABLED}" = "on" ]; then
 		# Enable route table lookup
-		ip rule add lookup "${ROUTE_TABLE}" prio "${ROUTE_TABLE_PRIO}" >/dev/null 2>&1
+		ip rule add lookup "${ROUTE_TABLE}" prio "${ROUTE_TABLE_PRIO}"
 
 		while IFS="," read -r "${VARS[@]}"; do
 			# Check if the connection is enabled
@@ -158,7 +158,7 @@  main() {
 
 						log "Creating route to ${rightsubnet} (via ${address} and ${RED_INTF})"
 						ip route add table "${ROUTE_TABLE}" "${rightsubnet}" proto static \
-							dev "${RED_INTF}" src "${address}" >/dev/null 2>&1
+							dev "${RED_INTF}" src "${address}"
 					done
 
 					# No interface processing required