diff mbox series

[v2,1/2] dns.cgi: Revert "dns.cgi: Fixes bug#12395 - German umlauts not correctly displayed in remarks"

Message ID 20240311121909.5445-1-adolf.belka@ipfire.org
State Staged
Commit 5a7342fc285425d226e52d988c0e35c23cd7547b
Headers
Series [v2,1/2] dns.cgi: Revert "dns.cgi: Fixes bug#12395 - German umlauts not correctly displayed in remarks" |

Commit Message

Adolf Belka March 11, 2024, 12:19 p.m. UTC 
  - This reverts commit 7c6ff5ff12331a53f416080a44c8d6145e78bfac
- That commit removed the cleanhtml command which is not advised, based on feedback from
   Michael Tremer from other patch submissions as it creates a potential security problem.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/dns.cgi | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/html/cgi-bin/dns.cgi b/html/cgi-bin/dns.cgi
index f3dd5c7a9..0a34d3fd6 100644
--- a/html/cgi-bin/dns.cgi
+++ b/html/cgi-bin/dns.cgi
@@ -141,6 +141,8 @@  if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
 
 	# Go further if there was no error.
 	if ( ! $errormessage) {
+		# Check if a remark has been entered.
+		$cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'});
 
 		my %dns_servers = ();
 		my $id;