From patchwork Mon Mar 11 12:19:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7599 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4TtbRv243dz3wtq for ; Mon, 11 Mar 2024 12:19:23 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature ECDSA (secp384r1)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4TtbRr2BZdzs6; Mon, 11 Mar 2024 12:19:20 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4TtbRq6mPdz32pV; Mon, 11 Mar 2024 12:19:19 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4TtbRn2MCtz304Y for ; Mon, 11 Mar 2024 12:19:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4TtbRm2LTDzC8; Mon, 11 Mar 2024 12:19:16 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1710159556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=9EFzhu3zTK8qJcyvCXKozvGUCGi63iaD0KJfg1uOmYc=; b=Mn2LVA+05ZDw/L4xUj7URs6mFEBQWu+wVxcov9XgBnfFuTdrlMVItMFGpjOhMcrIOAzYne gJMzSlZeS4jrZYBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1710159556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=9EFzhu3zTK8qJcyvCXKozvGUCGi63iaD0KJfg1uOmYc=; b=YUIWfEUbpNgXIRS2savMEIYgvlliSwwZ9u7g+HDdElXuFvRJsKVoayPDcWzE2V/+qPj05x Qq+m0IDnFgMFh+qHzgffwbhaNabebQVK4Yo0sp8zbo3K4e/Hkw8MCW1QPCTQ+ysXM08AjA mRq4hLA2b2E5j0NGOv1cVDKv25j23sJpCk6G8glBAMYcoMqjOxuMG1gzR23savth7m6K6H LlhmfSUCzZviR3Ho8Pf/XbrhLX9vUaNBnr5IQpG7h6tWzbUoEwYustLUUdN5rR6SL/pO2U 6aT/06STDnmMrV6KfkTFLsx63tDvKvu5GCkSK4p9nviIImWYYJIlrBd9H8PDCA== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH v2 1/2] dns.cgi: Revert "dns.cgi: Fixes bug#12395 - German umlauts not correctly displayed in remarks" Date: Mon, 11 Mar 2024 13:19:08 +0100 Message-ID: <20240311121909.5445-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: CHKQXLLKLIINO7F5FNYMTMEAVKEON44J X-Message-ID-Hash: CHKQXLLKLIINO7F5FNYMTMEAVKEON44J X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - This reverts commit 7c6ff5ff12331a53f416080a44c8d6145e78bfac - That commit removed the cleanhtml command which is not advised, based on feedback from Michael Tremer from other patch submissions as it creates a potential security problem. Signed-off-by: Adolf Belka --- html/cgi-bin/dns.cgi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/html/cgi-bin/dns.cgi b/html/cgi-bin/dns.cgi index f3dd5c7a9..0a34d3fd6 100644 --- a/html/cgi-bin/dns.cgi +++ b/html/cgi-bin/dns.cgi @@ -141,6 +141,8 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L # Go further if there was no error. if ( ! $errormessage) { + # Check if a remark has been entered. + $cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'}); my %dns_servers = (); my $id;