dhcp.cgi: Remove cleanhtml command from Remark

Message ID 20240305184418.3431741-2-adolf.belka@ipfire.org
State Dropped
Series dhcp.cgi: Remove cleanhtml command from Remark |

Commit Message

Adolf Belka March 5, 2024, 6:44 p.m. UTC
  - Using cleanhtml on Remarks means that all characters with diacritical marks such as
   umlauts or grave accents etc get encoded into other characters.
- If Freifunk München e.V. is entered as a remark it gets converted to
   Freifunk München e.V.
- cleanhtml is only removed from Remarks or Comment fields. In other places it has been
   left in place.

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
 html/cgi-bin/dhcp.cgi | 1 -
 1 file changed, 1 deletion(-)


diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
index be00f199a..128e42355 100644
--- a/html/cgi-bin/dhcp.cgi
+++ b/html/cgi-bin/dhcp.cgi
@@ -455,7 +455,6 @@  if ($dhcpsettings{'ACTION'} eq $Lang::tr{'add'}.'2') {
     unless ($errormessage) {
-	$dhcpsettings{'FIX_REMARK'} = &Header::cleanhtml($dhcpsettings{'FIX_REMARK'});
 	$dhcpsettings{'FIX_NEXTADDR'} = &Header::cleanhtml($dhcpsettings{'FIX_NEXTADDR'});
 	$dhcpsettings{'FIX_FILENAME'} = &Header::cleanhtml($dhcpsettings{'FIX_FILENAME'});
 	$dhcpsettings{'FIX_ROOTPATH'} = &Header::cleanhtml($dhcpsettings{'FIX_ROOTPATH'});