From patchwork Tue Mar 5 18:44:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adolf Belka X-Patchwork-Id: 7591 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4Tq4H53pgkz3wvx for ; Tue, 5 Mar 2024 18:44:33 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4Tq4H007SbzdH; Tue, 5 Mar 2024 18:44:28 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4Tq4Gz5fsJz32q7; Tue, 5 Mar 2024 18:44:27 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Tq4Gv6fGkz30sH for ; Tue, 5 Mar 2024 18:44:23 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4Tq4Gv30WkzdH; Tue, 5 Mar 2024 18:44:23 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1709664263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ajv8gBPeRZsH3Qi6cdMb8H0o7DQpg/Qb5uW4HOVsbg=; b=Q00m5190uiWPX8xX9JaCx8s0r2tTwod9MY6M73IbyVUxye+glw/fyS1DiSbdfo2xAU801h 7btfzpqMC8v8owAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1709664263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ajv8gBPeRZsH3Qi6cdMb8H0o7DQpg/Qb5uW4HOVsbg=; b=Acyc6WxfTxEJgBBYF+q0dU1pGRFqMfC5zKn80H+K3exRYzL16liFhQsmnj77OS+qVdyoES WcaNrMCpHUzLlVdb2bt2xIg1GLtMkmv4e9GzAkWgMgCvcmtEWMXPfkkkrEOu38bYlWlRnx AC6Z0mGNPmpf9G2bc/cpLwA7eA+8rAij+3dKAGNt+LUoGXYSvkBJ5AYTHPgvIvAEA0XXEK p31eQ68CorNiEDYa4mFjBDyshmRK3XGVC/z85NrVhFnJtaRnygNICUikieYj+aTicDM9/P 22i1JICuAMtHGcXPIYe1N90OAY/1PY4LUX61Fy33aXO7nSQCRtE5jgDWa7VdVw== From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH] dhcp.cgi: Remove cleanhtml command from Remark Date: Tue, 5 Mar 2024 19:44:14 +0100 Message-ID: <20240305184418.3431741-2-adolf.belka@ipfire.org> In-Reply-To: <20240305184418.3431741-1-adolf.belka@ipfire.org> References: <20240305184418.3431741-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Message-ID-Hash: 5NVG6NLWGRTGCUZNXI5WNM3RC7MFA5JW X-Message-ID-Hash: 5NVG6NLWGRTGCUZNXI5WNM3RC7MFA5JW X-MailFrom: adolf.belka@ipfire.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: IPFire development talk Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: - Using cleanhtml on Remarks means that all characters with diacritical marks such as umlauts or grave accents etc get encoded into other characters. - If Freifunk München e.V. is entered as a remark it gets converted to Freifunk München e.V. - cleanhtml is only removed from Remarks or Comment fields. In other places it has been left in place. Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- html/cgi-bin/dhcp.cgi | 1 - 1 file changed, 1 deletion(-) diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi index be00f199a..128e42355 100644 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -455,7 +455,6 @@ if ($dhcpsettings{'ACTION'} eq $Lang::tr{'add'}.'2') { } unless ($errormessage) { - $dhcpsettings{'FIX_REMARK'} = &Header::cleanhtml($dhcpsettings{'FIX_REMARK'}); $dhcpsettings{'FIX_NEXTADDR'} = &Header::cleanhtml($dhcpsettings{'FIX_NEXTADDR'}); $dhcpsettings{'FIX_FILENAME'} = &Header::cleanhtml($dhcpsettings{'FIX_FILENAME'}); $dhcpsettings{'FIX_ROOTPATH'} = &Header::cleanhtml($dhcpsettings{'FIX_ROOTPATH'});