Message ID | 20221118104915.1320-1-hofmann@leo-andres.de |
---|---|
State | Accepted |
Commit | 32fcdf45e4bdd079506fbf148ce486d3a1c13bde |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4NDD7j34Mhz3wgd for <patchwork@web04.haj.ipfire.org>; Fri, 18 Nov 2022 10:49:53 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4NDD7f573Sz1P2; Fri, 18 Nov 2022 10:49:50 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4NDD7f3GS1z2xl7; Fri, 18 Nov 2022 10:49:50 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4NDD7d1tYZz2xGV for <development@lists.ipfire.org>; Fri, 18 Nov 2022 10:49:49 +0000 (UTC) Received: from arche.uberspace.de (arche.uberspace.de [185.26.156.147]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4NDD7W1VTYzdn for <development@lists.ipfire.org>; Fri, 18 Nov 2022 10:49:43 +0000 (UTC) Authentication-Results: mail01.ipfire.org; dkim=none; dmarc=pass (policy=quarantine) header.from=leo-andres.de; spf=pass (mail01.ipfire.org: domain of hofmann@leo-andres.de designates 185.26.156.147 as permitted sender) smtp.mailfrom=hofmann@leo-andres.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1668768583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ydnLv/gXYg7U2WMAda6i2mKu0k27uqGeWYwuL0NyufM=; b=mtnd88GNCqFPdn8GgqWIBav1kBKMdyVK3ADWdkReNyCMriurTCEyOnsy16wjAzJBIZX9Uc Xz2ZYI3GcgKaX0WLKuKBvniElYTVTwXQnxqO0x0IhzLwBfqHN9NCQlDExgt2rrSCmB+2p/ TdbCWVOu0KaVX1QVxSNJaieT9DZX0Jq/PXVuo7XqD2qsekm4Ey/pP/j4lQWAtSibxbOGAO u7AG3SKQJnGQah7hV5K+0yHAEMFveLODowrzOZj66P3AAG+yLq6B/1JNBOsrBTVU/BZw7a wBhO6j/3NcuSC5GLmEnKKjcU5dflwLpHD67Q1lralvbqQ9Wt2zyNObsJ0HFj8Q== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=none; dmarc=pass (policy=quarantine) header.from=leo-andres.de; spf=pass (mail01.ipfire.org: domain of hofmann@leo-andres.de designates 185.26.156.147 as permitted sender) smtp.mailfrom=hofmann@leo-andres.de ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1668768583; a=rsa-sha256; cv=none; b=orbuCuhRpcqrH/ORmrEr2piM4E6GnxTcxpo91aZgXxbaSHmvOzxLvMxJDPEEzJZ0HjFPLr wLH2S8riNXi5eKxkmrXEr6zbLWuv8qgiEimlFZXyC0RURw4Ymprz+oOIwv83xg/Wy75UX3 WXJYoWONS7BsaFhCkxrz2+A+HF5qejlmrLA1SjSd9COH5IUOJPgdTIe2HATl126gOs+TFd L2xUlBYVkm4Pm1Eu9T8Alogy5sIYPnEYOqbSMkO1dqh8n9iLx20Mc+7Zj1hqGOvQpDo0o0 RQzjFf4Lmmk0Ow+QaFgrdxneXYPdZQMHR7lgZaVyJehWIP4/Lht+ekJG0WH5hA== Received: (qmail 7057 invoked by uid 990); 18 Nov 2022 10:49:37 -0000 From: Leo-Andres Hofmann <hofmann@leo-andres.de> To: development@lists.ipfire.org Subject: [PATCH] Rename misleading "check filesystem" reboot option Date: Fri, 18 Nov 2022 11:49:15 +0100 Message-Id: <20221118104915.1320-1-hofmann@leo-andres.de> X-Mailer: git-send-email 2.37.1.windows.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Bar: -- X-Rspamd-Report: MIME_GOOD(-0.1) MID_CONTAINS_FROM(1) BAYES_HAM(-3) X-Rspamd-Score: -2.1 Received: from unknown (HELO unkown) (::1) by arche.uberspace.de (Haraka/2.8.28) with ESMTPSA; Fri, 18 Nov 2022 11:49:37 +0100 X-Spamd-Result: default: False [-1.77 / 11.00]; BAYES_HAM(-1.47)[91.46%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM(-1.00)[-0.996]; MX_INVALID(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[leo-andres.de,quarantine]; R_SPF_ALLOW(-0.20)[+ip4:185.26.156.0/24]; MIME_GOOD(-0.10)[text/plain]; IP_REPUTATION_HAM(-0.00)[asn: 205766(0.00), country: DE(-0.00), ip: 185.26.156.147(0.00)]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[185.26.156.147:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:205766, ipnet:185.26.156.0/24, country:DE]; RCPT_COUNT_TWO(0.00)[2]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Server: mail01.haj.ipfire.org X-Rspamd-Queue-Id: 4NDD7W1VTYzdn X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
Rename misleading "check filesystem" reboot option
|
|
Commit Message
Leo-Andres Hofmann
Nov. 18, 2022, 10:49 a.m. UTC
Some users assume that "check filesystem" does more than
just trigger a simple "fsck" run. This patch changes the
button label to avoid confusion.
Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
---
langs/de/cgi-bin/de.pl | 2 +-
langs/en/cgi-bin/en.pl | 2 +-
langs/fr/cgi-bin/fr.pl | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Comments
I think this are cosmetics. The new text adds no new information. 'check filesystem' is a synonym to 'run fsck' in a Linux system, IMHO. But if it helps some users, we can change this button text. Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> Am 18.11.2022 um 11:49 schrieb Leo-Andres Hofmann: > Some users assume that "check filesystem" does more than > just trigger a simple "fsck" run. This patch changes the > button label to avoid confusion. > > Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de> > --- > langs/de/cgi-bin/de.pl | 2 +- > langs/en/cgi-bin/en.pl | 2 +- > langs/fr/cgi-bin/fr.pl | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl > index db7d117b0..110e4ccba 100644 > --- a/langs/de/cgi-bin/de.pl > +++ b/langs/de/cgi-bin/de.pl > @@ -2144,7 +2144,7 @@ > 'real address' => 'Reale Addresse', > 'reboot' => 'Neustart', > 'reboot ask' => 'Neustart?', > -'reboot fsck' => 'Neustart & Dateisystem-Test', > +'reboot fsck' => 'Neustart & ‘fsck’ ausführen', > 'reboot question' => 'Extra Abfrage bei neustart und herunterfahren einschalten', > 'reboot schedule' => 'Zeitsteuerung für IPFire Neustarts', > 'reboot sure' => 'Sind Sie sicher, dass Sie neustarten wollen?', > diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl > index 60dca5be4..004c64b6a 100644 > --- a/langs/en/cgi-bin/en.pl > +++ b/langs/en/cgi-bin/en.pl > @@ -2198,7 +2198,7 @@ > 'real address' => 'Real Address', > 'reboot' => 'Reboot', > 'reboot ask' => 'Reboot?', > -'reboot fsck' => 'Reboot & check filesystem', > +'reboot fsck' => 'Reboot & run ‘fsck’', > 'reboot question' => 'Extra query for restart and shutdown', > 'reboot schedule' => 'Schedule IPFire reboots', > 'reboot sure' => 'Are you sure that you want to reboot?', > diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl > index a1643557e..e46c4fa46 100644 > --- a/langs/fr/cgi-bin/fr.pl > +++ b/langs/fr/cgi-bin/fr.pl > @@ -2206,7 +2206,7 @@ > 'real address' => 'Adresse réelle', > 'reboot' => 'Redémarrer', > 'reboot ask' => 'Redémarrage ?', > -'reboot fsck' => 'Redémarrer et vérifier le système de fichier', > +'reboot fsck' => 'Redémarrer et exécuter ‘fsck’', > 'reboot question' => 'Requête supplémentaire pour le redémarrage et l\'arrêt', > 'reboot schedule' => 'Redémarrages planifiées d\'IPFire', > 'reboot sure' => 'Etes-vous sûr de vouloir redémarrer ?',
Yes, this is totally cosmetic. In the past, I have noticed a few forum posts where people assumed this button would automatically fix file permissions or even configuration issues. I think the new label is clearer and leaves no room for false expectations. Am 18.11.2022 um 13:07 schrieb Bernhard Bitsch: > I think this are cosmetics. > The new text adds no new information. 'check filesystem' is a synonym > to 'run fsck' in a Linux system, IMHO. > But if it helps some users, we can change this button text. > > Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> > > Am 18.11.2022 um 11:49 schrieb Leo-Andres Hofmann: >> Some users assume that "check filesystem" does more than >> just trigger a simple "fsck" run. This patch changes the >> button label to avoid confusion. >> >> Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de> >> --- >> langs/de/cgi-bin/de.pl | 2 +- >> langs/en/cgi-bin/en.pl | 2 +- >> langs/fr/cgi-bin/fr.pl | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl >> index db7d117b0..110e4ccba 100644 >> --- a/langs/de/cgi-bin/de.pl >> +++ b/langs/de/cgi-bin/de.pl >> @@ -2144,7 +2144,7 @@ >> 'real address' => 'Reale Addresse', >> 'reboot' => 'Neustart', >> 'reboot ask' => 'Neustart?', >> -'reboot fsck' => 'Neustart & Dateisystem-Test', >> +'reboot fsck' => 'Neustart & ‘fsck’ ausführen', >> 'reboot question' => 'Extra Abfrage bei neustart und herunterfahren >> einschalten', >> 'reboot schedule' => 'Zeitsteuerung für IPFire Neustarts', >> 'reboot sure' => 'Sind Sie sicher, dass Sie neustarten wollen?', >> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl >> index 60dca5be4..004c64b6a 100644 >> --- a/langs/en/cgi-bin/en.pl >> +++ b/langs/en/cgi-bin/en.pl >> @@ -2198,7 +2198,7 @@ >> 'real address' => 'Real Address', >> 'reboot' => 'Reboot', >> 'reboot ask' => 'Reboot?', >> -'reboot fsck' => 'Reboot & check filesystem', >> +'reboot fsck' => 'Reboot & run ‘fsck’', >> 'reboot question' => 'Extra query for restart and shutdown', >> 'reboot schedule' => 'Schedule IPFire reboots', >> 'reboot sure' => 'Are you sure that you want to reboot?', >> diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl >> index a1643557e..e46c4fa46 100644 >> --- a/langs/fr/cgi-bin/fr.pl >> +++ b/langs/fr/cgi-bin/fr.pl >> @@ -2206,7 +2206,7 @@ >> 'real address' => 'Adresse réelle', >> 'reboot' => 'Redémarrer', >> 'reboot ask' => 'Redémarrage ?', >> -'reboot fsck' => 'Redémarrer et vérifier le système de fichier', >> +'reboot fsck' => 'Redémarrer et exécuter ‘fsck’', >> 'reboot question' => 'Requête supplémentaire pour le redémarrage et >> l\'arrêt', >> 'reboot schedule' => 'Redémarrages planifiées d\'IPFire', >> 'reboot sure' => 'Etes-vous sûr de vouloir redémarrer ?',
I would argue that this won’t be helpful for anyone. If you are a person that reads “check filesystem” and thinks that means “repair filesystem”, then you’re a person that’ll read “run fsck” and think it means “repair filesystem using fsck.” My suggestion would be to add another menu option that actually does repair things, or to change the name from “check filesystem” to “check filesystem (no repairs made)” or something like that. Tom > On Nov 18, 2022, at 5:44 PM, Leo-Andres Hofmann <hofmann@leo-andres.de> wrote: > > Yes, this is totally cosmetic. In the past, I have noticed a few forum posts where people assumed this button would automatically fix file permissions or even configuration issues. I think the new label is clearer and leaves no room for false expectations. > >> Am 18.11.2022 um 13:07 schrieb Bernhard Bitsch: >> I think this are cosmetics. >> The new text adds no new information. 'check filesystem' is a synonym to 'run fsck' in a Linux system, IMHO. >> But if it helps some users, we can change this button text. >> >> Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> >> >>> Am 18.11.2022 um 11:49 schrieb Leo-Andres Hofmann: >>> Some users assume that "check filesystem" does more than >>> just trigger a simple "fsck" run. This patch changes the >>> button label to avoid confusion. >>> >>> Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de> >>> --- >>> langs/de/cgi-bin/de.pl | 2 +- >>> langs/en/cgi-bin/en.pl | 2 +- >>> langs/fr/cgi-bin/fr.pl | 2 +- >>> 3 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl >>> index db7d117b0..110e4ccba 100644 >>> --- a/langs/de/cgi-bin/de.pl >>> +++ b/langs/de/cgi-bin/de.pl >>> @@ -2144,7 +2144,7 @@ >>> 'real address' => 'Reale Addresse', >>> 'reboot' => 'Neustart', >>> 'reboot ask' => 'Neustart?', >>> -'reboot fsck' => 'Neustart & Dateisystem-Test', >>> +'reboot fsck' => 'Neustart & ‘fsck’ ausführen', >>> 'reboot question' => 'Extra Abfrage bei neustart und herunterfahren einschalten', >>> 'reboot schedule' => 'Zeitsteuerung für IPFire Neustarts', >>> 'reboot sure' => 'Sind Sie sicher, dass Sie neustarten wollen?', >>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl >>> index 60dca5be4..004c64b6a 100644 >>> --- a/langs/en/cgi-bin/en.pl >>> +++ b/langs/en/cgi-bin/en.pl >>> @@ -2198,7 +2198,7 @@ >>> 'real address' => 'Real Address', >>> 'reboot' => 'Reboot', >>> 'reboot ask' => 'Reboot?', >>> -'reboot fsck' => 'Reboot & check filesystem', >>> +'reboot fsck' => 'Reboot & run ‘fsck’', >>> 'reboot question' => 'Extra query for restart and shutdown', >>> 'reboot schedule' => 'Schedule IPFire reboots', >>> 'reboot sure' => 'Are you sure that you want to reboot?', >>> diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl >>> index a1643557e..e46c4fa46 100644 >>> --- a/langs/fr/cgi-bin/fr.pl >>> +++ b/langs/fr/cgi-bin/fr.pl >>> @@ -2206,7 +2206,7 @@ >>> 'real address' => 'Adresse réelle', >>> 'reboot' => 'Redémarrer', >>> 'reboot ask' => 'Redémarrage ?', >>> -'reboot fsck' => 'Redémarrer et vérifier le système de fichier', >>> +'reboot fsck' => 'Redémarrer et exécuter ‘fsck’', >>> 'reboot question' => 'Requête supplémentaire pour le redémarrage et l\'arrêt', >>> 'reboot schedule' => 'Redémarrages planifiées d\'IPFire', >>> 'reboot sure' => 'Etes-vous sûr de vouloir redémarrer ?',
Maybe "Check filesystem consistency" is more clear ? Or just check filesystem like it was and add a clear description on the wiki page https://wiki.ipfire.org/configuration/system/shutdown Robin Tom Rymes schreef op vr 18-11-2022 om 19:15 [-0500]: > I would argue that this won’t be helpful for anyone. If you are a > person that reads “check filesystem” and thinks that means “repair > filesystem”, then you’re a person that’ll read “run fsck” and think > it means “repair filesystem using fsck.” > > My suggestion would be to add another menu option that actually does > repair things, or to change the name from “check filesystem” to > “check filesystem (no repairs made)” or something like that. > > Tom > > > On Nov 18, 2022, at 5:44 PM, Leo-Andres Hofmann > > <hofmann@leo-andres.de> wrote: > > > > Yes, this is totally cosmetic. In the past, I have noticed a few > > forum posts where people assumed this button would automatically > > fix file permissions or even configuration issues. I think the new > > label is clearer and leaves no room for false expectations. > > > > > Am 18.11.2022 um 13:07 schrieb Bernhard Bitsch: > > > I think this are cosmetics. > > > The new text adds no new information. 'check filesystem' is a > > > synonym to 'run fsck' in a Linux system, IMHO. > > > But if it helps some users, we can change this button text. > > > > > > Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> > > > > > > > Am 18.11.2022 um 11:49 schrieb Leo-Andres Hofmann: > > > > Some users assume that "check filesystem" does more than > > > > just trigger a simple "fsck" run. This patch changes the > > > > button label to avoid confusion. > > > > > > > > Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de> > > > > --- > > > > langs/de/cgi-bin/de.pl | 2 +- > > > > langs/en/cgi-bin/en.pl | 2 +- > > > > langs/fr/cgi-bin/fr.pl | 2 +- > > > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl > > > > index db7d117b0..110e4ccba 100644 > > > > --- a/langs/de/cgi-bin/de.pl > > > > +++ b/langs/de/cgi-bin/de.pl > > > > @@ -2144,7 +2144,7 @@ > > > > 'real address' => 'Reale Addresse', > > > > 'reboot' => 'Neustart', > > > > 'reboot ask' => 'Neustart?', > > > > -'reboot fsck' => 'Neustart & Dateisystem-Test', > > > > +'reboot fsck' => 'Neustart & ‘fsck’ ausführen', > > > > 'reboot question' => 'Extra Abfrage bei neustart und > > > > herunterfahren einschalten', > > > > 'reboot schedule' => 'Zeitsteuerung für IPFire Neustarts', > > > > 'reboot sure' => 'Sind Sie sicher, dass Sie neustarten > > > > wollen?', > > > > diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl > > > > index 60dca5be4..004c64b6a 100644 > > > > --- a/langs/en/cgi-bin/en.pl > > > > +++ b/langs/en/cgi-bin/en.pl > > > > @@ -2198,7 +2198,7 @@ > > > > 'real address' => 'Real Address', > > > > 'reboot' => 'Reboot', > > > > 'reboot ask' => 'Reboot?', > > > > -'reboot fsck' => 'Reboot & check filesystem', > > > > +'reboot fsck' => 'Reboot & run ‘fsck’', > > > > 'reboot question' => 'Extra query for restart and shutdown', > > > > 'reboot schedule' => 'Schedule IPFire reboots', > > > > 'reboot sure' => 'Are you sure that you want to reboot?', > > > > diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl > > > > index a1643557e..e46c4fa46 100644 > > > > --- a/langs/fr/cgi-bin/fr.pl > > > > +++ b/langs/fr/cgi-bin/fr.pl > > > > @@ -2206,7 +2206,7 @@ > > > > 'real address' => 'Adresse réelle', > > > > 'reboot' => 'Redémarrer', > > > > 'reboot ask' => 'Redémarrage ?', > > > > -'reboot fsck' => 'Redémarrer et vérifier le système de > > > > fichier', > > > > +'reboot fsck' => 'Redémarrer et exécuter ‘fsck’', > > > > 'reboot question' => 'Requête supplémentaire pour le > > > > redémarrage et l\'arrêt', > > > > 'reboot schedule' => 'Redémarrages planifiées d\'IPFire', > > > > 'reboot sure' => 'Etes-vous sûr de vouloir redémarrer ?', >
Hello, I really like this conversation here :) > On 20 Nov 2022, at 19:49, Robin Roevens <robin.roevens@disroot.org> wrote: > > Maybe "Check filesystem consistency" is more clear ? I think this would be the clearest option. However, I do not know why we have this button in the first place. Why would you suspect having an inconsistent file system? And if you do, is this button actually helping? I am not suggestion to remove it - I am just questioning why we have this and who would use it and when. I just don’t know. -Michael > > Or just check filesystem like it was and add a clear description on the > wiki page https://wiki.ipfire.org/configuration/system/shutdown > > Robin > > Tom Rymes schreef op vr 18-11-2022 om 19:15 [-0500]: >> I would argue that this won’t be helpful for anyone. If you are a >> person that reads “check filesystem” and thinks that means “repair >> filesystem”, then you’re a person that’ll read “run fsck” and think >> it means “repair filesystem using fsck.” >> >> My suggestion would be to add another menu option that actually does >> repair things, or to change the name from “check filesystem” to >> “check filesystem (no repairs made)” or something like that. >> >> Tom >> >>> On Nov 18, 2022, at 5:44 PM, Leo-Andres Hofmann >>> <hofmann@leo-andres.de> wrote: >>> >>> Yes, this is totally cosmetic. In the past, I have noticed a few >>> forum posts where people assumed this button would automatically >>> fix file permissions or even configuration issues. I think the new >>> label is clearer and leaves no room for false expectations. >>> >>>> Am 18.11.2022 um 13:07 schrieb Bernhard Bitsch: >>>> I think this are cosmetics. >>>> The new text adds no new information. 'check filesystem' is a >>>> synonym to 'run fsck' in a Linux system, IMHO. >>>> But if it helps some users, we can change this button text. >>>> >>>> Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org> >>>> >>>>> Am 18.11.2022 um 11:49 schrieb Leo-Andres Hofmann: >>>>> Some users assume that "check filesystem" does more than >>>>> just trigger a simple "fsck" run. This patch changes the >>>>> button label to avoid confusion. >>>>> >>>>> Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de> >>>>> --- >>>>> langs/de/cgi-bin/de.pl | 2 +- >>>>> langs/en/cgi-bin/en.pl | 2 +- >>>>> langs/fr/cgi-bin/fr.pl | 2 +- >>>>> 3 files changed, 3 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl >>>>> index db7d117b0..110e4ccba 100644 >>>>> --- a/langs/de/cgi-bin/de.pl >>>>> +++ b/langs/de/cgi-bin/de.pl >>>>> @@ -2144,7 +2144,7 @@ >>>>> 'real address' => 'Reale Addresse', >>>>> 'reboot' => 'Neustart', >>>>> 'reboot ask' => 'Neustart?', >>>>> -'reboot fsck' => 'Neustart & Dateisystem-Test', >>>>> +'reboot fsck' => 'Neustart & ‘fsck’ ausführen', >>>>> 'reboot question' => 'Extra Abfrage bei neustart und >>>>> herunterfahren einschalten', >>>>> 'reboot schedule' => 'Zeitsteuerung für IPFire Neustarts', >>>>> 'reboot sure' => 'Sind Sie sicher, dass Sie neustarten >>>>> wollen?', >>>>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl >>>>> index 60dca5be4..004c64b6a 100644 >>>>> --- a/langs/en/cgi-bin/en.pl >>>>> +++ b/langs/en/cgi-bin/en.pl >>>>> @@ -2198,7 +2198,7 @@ >>>>> 'real address' => 'Real Address', >>>>> 'reboot' => 'Reboot', >>>>> 'reboot ask' => 'Reboot?', >>>>> -'reboot fsck' => 'Reboot & check filesystem', >>>>> +'reboot fsck' => 'Reboot & run ‘fsck’', >>>>> 'reboot question' => 'Extra query for restart and shutdown', >>>>> 'reboot schedule' => 'Schedule IPFire reboots', >>>>> 'reboot sure' => 'Are you sure that you want to reboot?', >>>>> diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl >>>>> index a1643557e..e46c4fa46 100644 >>>>> --- a/langs/fr/cgi-bin/fr.pl >>>>> +++ b/langs/fr/cgi-bin/fr.pl >>>>> @@ -2206,7 +2206,7 @@ >>>>> 'real address' => 'Adresse réelle', >>>>> 'reboot' => 'Redémarrer', >>>>> 'reboot ask' => 'Redémarrage ?', >>>>> -'reboot fsck' => 'Redémarrer et vérifier le système de >>>>> fichier', >>>>> +'reboot fsck' => 'Redémarrer et exécuter ‘fsck’', >>>>> 'reboot question' => 'Requête supplémentaire pour le >>>>> redémarrage et l\'arrêt', >>>>> 'reboot schedule' => 'Redémarrages planifiées d\'IPFire', >>>>> 'reboot sure' => 'Etes-vous sûr de vouloir redémarrer ?', >> > > -- > Dit bericht is gescanned op virussen en andere gevaarlijke > inhoud door MailScanner en lijkt schoon te zijn. >
diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl index db7d117b0..110e4ccba 100644 --- a/langs/de/cgi-bin/de.pl +++ b/langs/de/cgi-bin/de.pl @@ -2144,7 +2144,7 @@ 'real address' => 'Reale Addresse', 'reboot' => 'Neustart', 'reboot ask' => 'Neustart?', -'reboot fsck' => 'Neustart & Dateisystem-Test', +'reboot fsck' => 'Neustart & ‘fsck’ ausführen', 'reboot question' => 'Extra Abfrage bei neustart und herunterfahren einschalten', 'reboot schedule' => 'Zeitsteuerung für IPFire Neustarts', 'reboot sure' => 'Sind Sie sicher, dass Sie neustarten wollen?', diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl index 60dca5be4..004c64b6a 100644 --- a/langs/en/cgi-bin/en.pl +++ b/langs/en/cgi-bin/en.pl @@ -2198,7 +2198,7 @@ 'real address' => 'Real Address', 'reboot' => 'Reboot', 'reboot ask' => 'Reboot?', -'reboot fsck' => 'Reboot & check filesystem', +'reboot fsck' => 'Reboot & run ‘fsck’', 'reboot question' => 'Extra query for restart and shutdown', 'reboot schedule' => 'Schedule IPFire reboots', 'reboot sure' => 'Are you sure that you want to reboot?', diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl index a1643557e..e46c4fa46 100644 --- a/langs/fr/cgi-bin/fr.pl +++ b/langs/fr/cgi-bin/fr.pl @@ -2206,7 +2206,7 @@ 'real address' => 'Adresse réelle', 'reboot' => 'Redémarrer', 'reboot ask' => 'Redémarrage ?', -'reboot fsck' => 'Redémarrer et vérifier le système de fichier', +'reboot fsck' => 'Redémarrer et exécuter ‘fsck’', 'reboot question' => 'Requête supplémentaire pour le redémarrage et l\'arrêt', 'reboot schedule' => 'Redémarrages planifiées d\'IPFire', 'reboot sure' => 'Etes-vous sûr de vouloir redémarrer ?',