dracut: Enable automatic assembly of any RAID/LVM devices

Message ID 20220516144814.4143999-1-michael.tremer@ipfire.org
State Accepted
Commit 1c1d9fd7bfdf5495069c3119982753a9ddc5fe24
Headers show
Series dracut: Enable automatic assembly of any RAID/LVM devices | expand

Commit Message

Michael Tremer May 16, 2022, 2:48 p.m. UTC
This has changed in dracut 24 and we have used various hacks to enable
this behaviour again when it would have been so easy to just enable this
parameter.

Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
Reported-by: Dirk Sihling <dsihling@web.de>
Reported-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 config/grub2/default | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Müller May 16, 2022, 3:17 p.m. UTC | #1
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>

> This has changed in dracut 24 and we have used various hacks to enable
> this behaviour again when it would have been so easy to just enable this
> parameter.
> 
> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
> Reported-by: Dirk Sihling <dsihling@web.de>
> Reported-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>   config/grub2/default | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/grub2/default b/config/grub2/default
> index c1b78237e..127d33445 100644
> --- a/config/grub2/default
> +++ b/config/grub2/default
> @@ -1,6 +1,6 @@
>   GRUB_TIMEOUT=5
>   GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
>   GRUB_DEFAULT=saved
> -GRUB_CMDLINE_LINUX="panic=10"
> +GRUB_CMDLINE_LINUX="rd.auto panic=10"
>   GRUB_DISABLE_RECOVERY="true"
>   GRUB_BACKGROUND="/boot/grub/splash.png"
Michael Tremer May 16, 2022, 3:18 p.m. UTC | #2
Please do not merge this yet.

This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot.

-Michael

> On 16 May 2022, at 16:17, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
> 
>> This has changed in dracut 24 and we have used various hacks to enable
>> this behaviour again when it would have been so easy to just enable this
>> parameter.
>> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
>> Reported-by: Dirk Sihling <dsihling@web.de>
>> Reported-by: Adolf Belka <adolf.belka@ipfire.org>
>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
>> ---
>>  config/grub2/default | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/config/grub2/default b/config/grub2/default
>> index c1b78237e..127d33445 100644
>> --- a/config/grub2/default
>> +++ b/config/grub2/default
>> @@ -1,6 +1,6 @@
>>  GRUB_TIMEOUT=5
>>  GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
>>  GRUB_DEFAULT=saved
>> -GRUB_CMDLINE_LINUX="panic=10"
>> +GRUB_CMDLINE_LINUX="rd.auto panic=10"
>>  GRUB_DISABLE_RECOVERY="true"
>>  GRUB_BACKGROUND="/boot/grub/splash.png"
Peter Müller May 16, 2022, 6:38 p.m. UTC | #3
Hello Michael,

thanks for your mail, which I unfortunately noticed too late.

So, we have this patch in "next" for the time being, which I consider acceptable, since
it will not reach anybody aside people running IPFire from the "unstable" tree - which
is just as the name implies.

Feel free to revert the patch in "next" at your discretion. I do, however, not consider
it overly problematic to stay there. :-)

Thanks, and best regards,
Peter Müller


> Please do not merge this yet.
> 
> This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot.
> 
> -Michael
> 
>> On 16 May 2022, at 16:17, Peter Müller <peter.mueller@ipfire.org> wrote:
>>
>> Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
>>
>>> This has changed in dracut 24 and we have used various hacks to enable
>>> this behaviour again when it would have been so easy to just enable this
>>> parameter.
>>> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
>>> Reported-by: Dirk Sihling <dsihling@web.de>
>>> Reported-by: Adolf Belka <adolf.belka@ipfire.org>
>>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
>>> ---
>>>  config/grub2/default | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> diff --git a/config/grub2/default b/config/grub2/default
>>> index c1b78237e..127d33445 100644
>>> --- a/config/grub2/default
>>> +++ b/config/grub2/default
>>> @@ -1,6 +1,6 @@
>>>  GRUB_TIMEOUT=5
>>>  GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
>>>  GRUB_DEFAULT=saved
>>> -GRUB_CMDLINE_LINUX="panic=10"
>>> +GRUB_CMDLINE_LINUX="rd.auto panic=10"
>>>  GRUB_DISABLE_RECOVERY="true"
>>>  GRUB_BACKGROUND="/boot/grub/splash.png"
>
Michael Tremer May 17, 2022, 11:22 a.m. UTC | #4
Hello Peter,

> On 16 May 2022, at 19:38, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> Hello Michael,
> 
> thanks for your mail, which I unfortunately noticed too late.

LOL

> So, we have this patch in "next" for the time being, which I consider acceptable, since
> it will not reach anybody aside people running IPFire from the "unstable" tree - which
> is just as the name implies.

Indeed this change will only affect new installations from next and not change any existing ones.

> Feel free to revert the patch in "next" at your discretion. I do, however, not consider
> it overly problematic to stay there. :-)

Not right now, but there is more required to make this work. I will need some time to find out how to do this and until then this sadly will have to block the release:

See my latest comment here: https://bugzilla.ipfire.org/show_bug.cgi?id=12862#c37

-Michael

> 
> Thanks, and best regards,
> Peter Müller
> 
> 
>> Please do not merge this yet.
>> 
>> This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot.
>> 
>> -Michael
>> 
>>> On 16 May 2022, at 16:17, Peter Müller <peter.mueller@ipfire.org> wrote:
>>> 
>>> Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
>>> 
>>>> This has changed in dracut 24 and we have used various hacks to enable
>>>> this behaviour again when it would have been so easy to just enable this
>>>> parameter.
>>>> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
>>>> Reported-by: Dirk Sihling <dsihling@web.de>
>>>> Reported-by: Adolf Belka <adolf.belka@ipfire.org>
>>>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
>>>> ---
>>>> config/grub2/default | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>> diff --git a/config/grub2/default b/config/grub2/default
>>>> index c1b78237e..127d33445 100644
>>>> --- a/config/grub2/default
>>>> +++ b/config/grub2/default
>>>> @@ -1,6 +1,6 @@
>>>> GRUB_TIMEOUT=5
>>>> GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
>>>> GRUB_DEFAULT=saved
>>>> -GRUB_CMDLINE_LINUX="panic=10"
>>>> +GRUB_CMDLINE_LINUX="rd.auto panic=10"
>>>> GRUB_DISABLE_RECOVERY="true"
>>>> GRUB_BACKGROUND="/boot/grub/splash.png"
>>

Patch

diff --git a/config/grub2/default b/config/grub2/default
index c1b78237e..127d33445 100644
--- a/config/grub2/default
+++ b/config/grub2/default
@@ -1,6 +1,6 @@ 
 GRUB_TIMEOUT=5
 GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
 GRUB_DEFAULT=saved
-GRUB_CMDLINE_LINUX="panic=10"
+GRUB_CMDLINE_LINUX="rd.auto panic=10"
 GRUB_DISABLE_RECOVERY="true"
 GRUB_BACKGROUND="/boot/grub/splash.png"