Message ID | 20220516144814.4143999-1-michael.tremer@ipfire.org |
---|---|
State | Accepted |
Commit | 1c1d9fd7bfdf5495069c3119982753a9ddc5fe24 |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4L22Dm6H2Gz3yZG for <patchwork@web04.haj.ipfire.org>; Mon, 16 May 2022 14:48:24 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4L22Dl5qwwzfF; Mon, 16 May 2022 14:48:23 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4L22Dl5FYMz2ynQ; Mon, 16 May 2022 14:48:23 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4L22Dk6wlbz2xbM for <development@lists.ipfire.org>; Mon, 16 May 2022 14:48:22 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4L22Dh6vk9zDC; Mon, 16 May 2022 14:48:20 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1652712501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tgm5UH7RoF83UF1XELdFpAAzdPQ+OiDj/I/Izawp/rs=; b=b1adMOL17hnX4pQCXcSSYXDJUdW+YLpRf9+yxmIm3XTknnKNTpOhMtqe3bT0+ovVWVLmYC 8pWPDaWcHWVmc/AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1652712501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tgm5UH7RoF83UF1XELdFpAAzdPQ+OiDj/I/Izawp/rs=; b=fMd+9smTRYTdIfT3QzjIqvYgWhjj7PRkzfR9npuepmoPhcOVvib3wLS5Xaedv4eS52qNsr bKbJdWWWWQrQrJHt7N/0YpzshwhXSrdmjlPThnL6VaXsRyr31gSpUJ5itzn+RQAXD90XG0 H6fb6inBkw3dVn2HVszKpOshYjwdXcNe8zTlCgbtJF+hvGQkoeficv3E+dli1mxD6CO45j KRom3IflX0hOTnBf5wzUJP06s7wjmU4KDLKonDs23fOtHMT36Ei0UsI4Hu6oQxOQgD00dR 1LSSaAakZ7WGSIo5AaC2+cjJpkxo6xZhZ7r6l+GS3+PXT7WmdCmrg85R0DZ/yw== From: Michael Tremer <michael.tremer@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH] dracut: Enable automatic assembly of any RAID/LVM devices Date: Mon, 16 May 2022 14:48:14 +0000 Message-Id: <20220516144814.4143999-1-michael.tremer@ipfire.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Cc: Michael Tremer <michael.tremer@ipfire.org>, Dirk Sihling <dsihling@web.de> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
dracut: Enable automatic assembly of any RAID/LVM devices
|
|
Commit Message
Michael Tremer
May 16, 2022, 2:48 p.m. UTC
This has changed in dracut 24 and we have used various hacks to enable
this behaviour again when it would have been so easy to just enable this
parameter.
Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
Reported-by: Dirk Sihling <dsihling@web.de>
Reported-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
config/grub2/default | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Reviewed-by: Peter Müller <peter.mueller@ipfire.org> > This has changed in dracut 24 and we have used various hacks to enable > this behaviour again when it would have been so easy to just enable this > parameter. > > Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore > Reported-by: Dirk Sihling <dsihling@web.de> > Reported-by: Adolf Belka <adolf.belka@ipfire.org> > Signed-off-by: Michael Tremer <michael.tremer@ipfire.org> > --- > config/grub2/default | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/grub2/default b/config/grub2/default > index c1b78237e..127d33445 100644 > --- a/config/grub2/default > +++ b/config/grub2/default > @@ -1,6 +1,6 @@ > GRUB_TIMEOUT=5 > GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)" > GRUB_DEFAULT=saved > -GRUB_CMDLINE_LINUX="panic=10" > +GRUB_CMDLINE_LINUX="rd.auto panic=10" > GRUB_DISABLE_RECOVERY="true" > GRUB_BACKGROUND="/boot/grub/splash.png"
Please do not merge this yet. This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot. -Michael > On 16 May 2022, at 16:17, Peter Müller <peter.mueller@ipfire.org> wrote: > > Reviewed-by: Peter Müller <peter.mueller@ipfire.org> > >> This has changed in dracut 24 and we have used various hacks to enable >> this behaviour again when it would have been so easy to just enable this >> parameter. >> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore >> Reported-by: Dirk Sihling <dsihling@web.de> >> Reported-by: Adolf Belka <adolf.belka@ipfire.org> >> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org> >> --- >> config/grub2/default | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/config/grub2/default b/config/grub2/default >> index c1b78237e..127d33445 100644 >> --- a/config/grub2/default >> +++ b/config/grub2/default >> @@ -1,6 +1,6 @@ >> GRUB_TIMEOUT=5 >> GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)" >> GRUB_DEFAULT=saved >> -GRUB_CMDLINE_LINUX="panic=10" >> +GRUB_CMDLINE_LINUX="rd.auto panic=10" >> GRUB_DISABLE_RECOVERY="true" >> GRUB_BACKGROUND="/boot/grub/splash.png"
Hello Michael, thanks for your mail, which I unfortunately noticed too late. So, we have this patch in "next" for the time being, which I consider acceptable, since it will not reach anybody aside people running IPFire from the "unstable" tree - which is just as the name implies. Feel free to revert the patch in "next" at your discretion. I do, however, not consider it overly problematic to stay there. :-) Thanks, and best regards, Peter Müller > Please do not merge this yet. > > This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot. > > -Michael > >> On 16 May 2022, at 16:17, Peter Müller <peter.mueller@ipfire.org> wrote: >> >> Reviewed-by: Peter Müller <peter.mueller@ipfire.org> >> >>> This has changed in dracut 24 and we have used various hacks to enable >>> this behaviour again when it would have been so easy to just enable this >>> parameter. >>> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore >>> Reported-by: Dirk Sihling <dsihling@web.de> >>> Reported-by: Adolf Belka <adolf.belka@ipfire.org> >>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org> >>> --- >>> config/grub2/default | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> diff --git a/config/grub2/default b/config/grub2/default >>> index c1b78237e..127d33445 100644 >>> --- a/config/grub2/default >>> +++ b/config/grub2/default >>> @@ -1,6 +1,6 @@ >>> GRUB_TIMEOUT=5 >>> GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)" >>> GRUB_DEFAULT=saved >>> -GRUB_CMDLINE_LINUX="panic=10" >>> +GRUB_CMDLINE_LINUX="rd.auto panic=10" >>> GRUB_DISABLE_RECOVERY="true" >>> GRUB_BACKGROUND="/boot/grub/splash.png" >
Hello Peter, > On 16 May 2022, at 19:38, Peter Müller <peter.mueller@ipfire.org> wrote: > > Hello Michael, > > thanks for your mail, which I unfortunately noticed too late. LOL > So, we have this patch in "next" for the time being, which I consider acceptable, since > it will not reach anybody aside people running IPFire from the "unstable" tree - which > is just as the name implies. Indeed this change will only affect new installations from next and not change any existing ones. > Feel free to revert the patch in "next" at your discretion. I do, however, not consider > it overly problematic to stay there. :-) Not right now, but there is more required to make this work. I will need some time to find out how to do this and until then this sadly will have to block the release: See my latest comment here: https://bugzilla.ipfire.org/show_bug.cgi?id=12862#c37 -Michael > > Thanks, and best regards, > Peter Müller > > >> Please do not merge this yet. >> >> This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot. >> >> -Michael >> >>> On 16 May 2022, at 16:17, Peter Müller <peter.mueller@ipfire.org> wrote: >>> >>> Reviewed-by: Peter Müller <peter.mueller@ipfire.org> >>> >>>> This has changed in dracut 24 and we have used various hacks to enable >>>> this behaviour again when it would have been so easy to just enable this >>>> parameter. >>>> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore >>>> Reported-by: Dirk Sihling <dsihling@web.de> >>>> Reported-by: Adolf Belka <adolf.belka@ipfire.org> >>>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org> >>>> --- >>>> config/grub2/default | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> diff --git a/config/grub2/default b/config/grub2/default >>>> index c1b78237e..127d33445 100644 >>>> --- a/config/grub2/default >>>> +++ b/config/grub2/default >>>> @@ -1,6 +1,6 @@ >>>> GRUB_TIMEOUT=5 >>>> GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)" >>>> GRUB_DEFAULT=saved >>>> -GRUB_CMDLINE_LINUX="panic=10" >>>> +GRUB_CMDLINE_LINUX="rd.auto panic=10" >>>> GRUB_DISABLE_RECOVERY="true" >>>> GRUB_BACKGROUND="/boot/grub/splash.png" >>
diff --git a/config/grub2/default b/config/grub2/default index c1b78237e..127d33445 100644 --- a/config/grub2/default +++ b/config/grub2/default @@ -1,6 +1,6 @@ GRUB_TIMEOUT=5 GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)" GRUB_DEFAULT=saved -GRUB_CMDLINE_LINUX="panic=10" +GRUB_CMDLINE_LINUX="rd.auto panic=10" GRUB_DISABLE_RECOVERY="true" GRUB_BACKGROUND="/boot/grub/splash.png"