[2/3] linux-firmware: Drop hack to remove spaces in filenames

Message ID 20230118113628.3309496-2-michael.tremer@ipfire.org
State Accepted
Commit f5c45515b55ac2cd326cd4cd416916e2727aa4da
Headers
Series [1/3] Config: Support rootfiles with spaces in filenames |

Commit Message

Michael Tremer Jan. 18, 2023, 11:36 a.m. UTC
  Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 config/rootfiles/common/linux-firmware | 14 +++++++-------
 lfs/linux-firmware                     |  5 -----
 2 files changed, 7 insertions(+), 12 deletions(-)
  

Comments

Peter Müller Jan. 18, 2023, 11:25 p.m. UTC | #1
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>

> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>  config/rootfiles/common/linux-firmware | 14 +++++++-------
>  lfs/linux-firmware                     |  5 -----
>  2 files changed, 7 insertions(+), 12 deletions(-)
> 
> diff --git a/config/rootfiles/common/linux-firmware b/config/rootfiles/common/linux-firmware
> index 4d73cc060..2e147afd1 100644
> --- a/config/rootfiles/common/linux-firmware
> +++ b/config/rootfiles/common/linux-firmware
> @@ -824,7 +824,7 @@ lib/firmware/brcm/brcmfmac43143-sdio.bin
>  lib/firmware/brcm/brcmfmac43143.bin
>  lib/firmware/brcm/brcmfmac43236b.bin
>  lib/firmware/brcm/brcmfmac43241b0-sdio.bin
> -lib/firmware/brcm/brcmfmac43241b4-sdio.Intel_Corp.-VALLEYVIEW_C0_PLATFORM.txt
> +lib/firmware/brcm/brcmfmac43241b4-sdio.Intel Corp.-VALLEYVIEW C0 PLATFORM.txt
>  lib/firmware/brcm/brcmfmac43241b4-sdio.bin
>  lib/firmware/brcm/brcmfmac43241b5-sdio.bin
>  lib/firmware/brcm/brcmfmac43242a.bin
> @@ -832,7 +832,7 @@ lib/firmware/brcm/brcmfmac4329-sdio.bin
>  lib/firmware/brcm/brcmfmac4330-sdio.Prowise-PT301.txt
>  lib/firmware/brcm/brcmfmac4330-sdio.bin
>  lib/firmware/brcm/brcmfmac4334-sdio.bin
> -lib/firmware/brcm/brcmfmac43340-sdio.ASUSTeK_COMPUTER_INC.-TF103CE.txt
> +lib/firmware/brcm/brcmfmac43340-sdio.ASUSTeK COMPUTER INC.-TF103CE.txt
>  lib/firmware/brcm/brcmfmac43340-sdio.bin
>  lib/firmware/brcm/brcmfmac43340-sdio.meegopad-t08.txt
>  lib/firmware/brcm/brcmfmac43340-sdio.pov-tab-p1006w-data.txt
> @@ -858,14 +858,14 @@ lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-ultra.txt
>  lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-zero.txt
>  lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m3.txt
>  lib/firmware/brcm/brcmfmac43430-sdio.starfive,visionfive-v1.txt
> -lib/firmware/brcm/brcmfmac43430a0-sdio.ONDA-V80_PLUS.txt
> +lib/firmware/brcm/brcmfmac43430a0-sdio.ONDA-V80 PLUS.txt
>  lib/firmware/brcm/brcmfmac43430a0-sdio.bin
>  lib/firmware/brcm/brcmfmac43430a0-sdio.ilife-S806.txt
>  lib/firmware/brcm/brcmfmac43430a0-sdio.jumper-ezpad-mini3.txt
>  lib/firmware/brcm/brcmfmac43455-sdio.AW-CM256SM.txt
> -lib/firmware/brcm/brcmfmac43455-sdio.MINIX-NEO_Z83-4.txt
> -lib/firmware/brcm/brcmfmac43455-sdio.Raspberry_Pi_Foundation-Raspberry_Pi_4_Model_B.txt
> -lib/firmware/brcm/brcmfmac43455-sdio.Raspberry_Pi_Foundation-Raspberry_Pi_Compute_Module_4.txt
> +lib/firmware/brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt
> +lib/firmware/brcm/brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi 4 Model B.txt
> +lib/firmware/brcm/brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi Compute Module 4.txt
>  lib/firmware/brcm/brcmfmac43455-sdio.acepc-t8.txt
>  lib/firmware/brcm/brcmfmac43455-sdio.beagle,am5729-beagleboneai.txt
>  lib/firmware/brcm/brcmfmac43455-sdio.bin
> @@ -880,7 +880,7 @@ lib/firmware/brcm/brcmfmac4350-pcie.bin
>  lib/firmware/brcm/brcmfmac4350c2-pcie.bin
>  lib/firmware/brcm/brcmfmac4354-sdio.bin
>  lib/firmware/brcm/brcmfmac4354-sdio.clm_blob
> -lib/firmware/brcm/brcmfmac4356-pcie.Xiaomi_Inc-Mipad2.txt
> +lib/firmware/brcm/brcmfmac4356-pcie.Xiaomi Inc-Mipad2.txt
>  lib/firmware/brcm/brcmfmac4356-pcie.bin
>  lib/firmware/brcm/brcmfmac4356-pcie.clm_blob
>  lib/firmware/brcm/brcmfmac4356-pcie.gpd-win-pocket.txt
> diff --git a/lfs/linux-firmware b/lfs/linux-firmware
> index 0a11eef8c..f234dce62 100644
> --- a/lfs/linux-firmware
> +++ b/lfs/linux-firmware
> @@ -73,11 +73,6 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>  	mkdir -p /lib/firmware
>  	cd $(DIR_APP) && make install
>  
> -	# Remove any spaces in filenames
> -	while read -r file; do \
> -		mv "$${file}" "$${file// /_}" || exit 1; \
> -	done < <(find /lib/firmware -name "* *")
> -
>  	# Hardlink any identical files
>  	hardlink -c -vv /lib/firmware
>
  

Patch

diff --git a/config/rootfiles/common/linux-firmware b/config/rootfiles/common/linux-firmware
index 4d73cc060..2e147afd1 100644
--- a/config/rootfiles/common/linux-firmware
+++ b/config/rootfiles/common/linux-firmware
@@ -824,7 +824,7 @@  lib/firmware/brcm/brcmfmac43143-sdio.bin
 lib/firmware/brcm/brcmfmac43143.bin
 lib/firmware/brcm/brcmfmac43236b.bin
 lib/firmware/brcm/brcmfmac43241b0-sdio.bin
-lib/firmware/brcm/brcmfmac43241b4-sdio.Intel_Corp.-VALLEYVIEW_C0_PLATFORM.txt
+lib/firmware/brcm/brcmfmac43241b4-sdio.Intel Corp.-VALLEYVIEW C0 PLATFORM.txt
 lib/firmware/brcm/brcmfmac43241b4-sdio.bin
 lib/firmware/brcm/brcmfmac43241b5-sdio.bin
 lib/firmware/brcm/brcmfmac43242a.bin
@@ -832,7 +832,7 @@  lib/firmware/brcm/brcmfmac4329-sdio.bin
 lib/firmware/brcm/brcmfmac4330-sdio.Prowise-PT301.txt
 lib/firmware/brcm/brcmfmac4330-sdio.bin
 lib/firmware/brcm/brcmfmac4334-sdio.bin
-lib/firmware/brcm/brcmfmac43340-sdio.ASUSTeK_COMPUTER_INC.-TF103CE.txt
+lib/firmware/brcm/brcmfmac43340-sdio.ASUSTeK COMPUTER INC.-TF103CE.txt
 lib/firmware/brcm/brcmfmac43340-sdio.bin
 lib/firmware/brcm/brcmfmac43340-sdio.meegopad-t08.txt
 lib/firmware/brcm/brcmfmac43340-sdio.pov-tab-p1006w-data.txt
@@ -858,14 +858,14 @@  lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-ultra.txt
 lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-zero.txt
 lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m3.txt
 lib/firmware/brcm/brcmfmac43430-sdio.starfive,visionfive-v1.txt
-lib/firmware/brcm/brcmfmac43430a0-sdio.ONDA-V80_PLUS.txt
+lib/firmware/brcm/brcmfmac43430a0-sdio.ONDA-V80 PLUS.txt
 lib/firmware/brcm/brcmfmac43430a0-sdio.bin
 lib/firmware/brcm/brcmfmac43430a0-sdio.ilife-S806.txt
 lib/firmware/brcm/brcmfmac43430a0-sdio.jumper-ezpad-mini3.txt
 lib/firmware/brcm/brcmfmac43455-sdio.AW-CM256SM.txt
-lib/firmware/brcm/brcmfmac43455-sdio.MINIX-NEO_Z83-4.txt
-lib/firmware/brcm/brcmfmac43455-sdio.Raspberry_Pi_Foundation-Raspberry_Pi_4_Model_B.txt
-lib/firmware/brcm/brcmfmac43455-sdio.Raspberry_Pi_Foundation-Raspberry_Pi_Compute_Module_4.txt
+lib/firmware/brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt
+lib/firmware/brcm/brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi 4 Model B.txt
+lib/firmware/brcm/brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi Compute Module 4.txt
 lib/firmware/brcm/brcmfmac43455-sdio.acepc-t8.txt
 lib/firmware/brcm/brcmfmac43455-sdio.beagle,am5729-beagleboneai.txt
 lib/firmware/brcm/brcmfmac43455-sdio.bin
@@ -880,7 +880,7 @@  lib/firmware/brcm/brcmfmac4350-pcie.bin
 lib/firmware/brcm/brcmfmac4350c2-pcie.bin
 lib/firmware/brcm/brcmfmac4354-sdio.bin
 lib/firmware/brcm/brcmfmac4354-sdio.clm_blob
-lib/firmware/brcm/brcmfmac4356-pcie.Xiaomi_Inc-Mipad2.txt
+lib/firmware/brcm/brcmfmac4356-pcie.Xiaomi Inc-Mipad2.txt
 lib/firmware/brcm/brcmfmac4356-pcie.bin
 lib/firmware/brcm/brcmfmac4356-pcie.clm_blob
 lib/firmware/brcm/brcmfmac4356-pcie.gpd-win-pocket.txt
diff --git a/lfs/linux-firmware b/lfs/linux-firmware
index 0a11eef8c..f234dce62 100644
--- a/lfs/linux-firmware
+++ b/lfs/linux-firmware
@@ -73,11 +73,6 @@  $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 	mkdir -p /lib/firmware
 	cd $(DIR_APP) && make install
 
-	# Remove any spaces in filenames
-	while read -r file; do \
-		mv "$${file}" "$${file// /_}" || exit 1; \
-	done < <(find /lib/firmware -name "* *")
-
 	# Hardlink any identical files
 	hardlink -c -vv /lib/firmware