[2/3] dhcp: update lfs file after gzip update to fix build fail
| Message ID | 1457431773-6715-2-git-send-email-marcel.lorenz@ipfire.org |
|---|---|
| State | Dropped |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (hedwig.ipfire.org [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id 581A961C09 for <patchwork@ipfire.org>; Tue, 8 Mar 2016 10:58:17 +0100 (CET) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id E4DBF348C; Tue, 8 Mar 2016 10:58:14 +0100 (CET) Received: from mint01.skynet.local (ip5f5b7cdb.dynamic.kabel-deutschland.de [95.91.124.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id E4E38121B; Tue, 8 Mar 2016 10:58:09 +0100 (CET) From: Marcel Lorenz <marcel.lorenz@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH 2/3] dhcp: update lfs file after gzip update to fix build fail Date: Tue, 8 Mar 2016 11:09:32 +0100 Message-Id: <1457431773-6715-2-git-send-email-marcel.lorenz@ipfire.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1457431773-6715-1-git-send-email-marcel.lorenz@ipfire.org> References: <1457431773-6715-1-git-send-email-marcel.lorenz@ipfire.org> X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Marcel Lorenz
March 8, 2016, 9:09 p.m. UTC
Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org>
---
lfs/dhcp | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
Comments
Hi, what is the build issue you are trying to solve here? Copying in a highly outdated version of the bind libs is from my point of view a big security risk. -Michael On Tue, 2016-03-08 at 11:09 +0100, Marcel Lorenz wrote: > Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org> > > --- > lfs/dhcp | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/lfs/dhcp b/lfs/dhcp > index 9a89d40..cec8628 100644 > --- a/lfs/dhcp > +++ b/lfs/dhcp > @@ -99,17 +99,11 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > cd $(DIR_APP) && patch -Np1 < > $(DIR_SRC)/src/patches/dhcp/dhcp-gpxe-cid.patch > cd $(DIR_APP) && patch -Np1 < > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch > > - # Remove bundled BIND stuff. > - # (requires newer autoconf) > - #rm -rfv $(DIR_APP)/bind/bind.tar.gz > - #cd $(DIR_APP) && autoreconf --verbose --force --install > - > - cd $(DIR_APP) && \ > - ./configure \ > + cd $(DIR_APP)/bind && tar -axf bind.tar.gz > + cd $(DIR_APP) && ./configure \ > --prefix=/usr \ > --sysconfdir=/etc/dhcp \ > --with-srv-lease- > file=/var/state/dhcp/dhcpd.leases \ > - --disable-static \ > --enable-paranoia \ > --enable-early-chroot \ > --disable-dhcpv6
Am 2016-03-08 15:26, schrieb Michael Tremer: > Hi, > > what is the build issue you are trying to solve here? > > Copying in a highly outdated version of the bind libs is from my point > of view a big security risk. > > -Michael > > On Tue, 2016-03-08 at 11:09 +0100, Marcel Lorenz wrote: >> Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org> Hi, you have right, the old bind is a security risk! This is the current lfs file without patch: ***** cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch # Remove bundled BIND stuff. # (requires newer autoconf) #rm -rfv $(DIR_APP)/bind/bind.tar.gz #cd $(DIR_APP) && autoreconf --verbose --force --install cd $(DIR_APP) && \ ***** The error in log is "use tar axf to extract..." The old bind is extracted while make runs. After gzip update this not working more automatic. They only need some files from bind archive to built the isc-dhcp package. Bind itself is not used. (When i understood this correct) The: "cd $(DIR_APP)/bind && tar -axf bind.tar.gz" extract this before make runs.. That's all.. Greetings, Marcel >> >> --- >> lfs/dhcp | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/lfs/dhcp b/lfs/dhcp >> index 9a89d40..cec8628 100644 >> --- a/lfs/dhcp >> +++ b/lfs/dhcp >> @@ -99,17 +99,11 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >> cd $(DIR_APP) && patch -Np1 < >> $(DIR_SRC)/src/patches/dhcp/dhcp-gpxe-cid.patch >> cd $(DIR_APP) && patch -Np1 < >> $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch >> >> - # Remove bundled BIND stuff. >> - # (requires newer autoconf) >> - #rm -rfv $(DIR_APP)/bind/bind.tar.gz >> - #cd $(DIR_APP) && autoreconf --verbose --force --install >> - >> - cd $(DIR_APP) && \ >> - ./configure \ >> + cd $(DIR_APP)/bind && tar -axf bind.tar.gz >> + cd $(DIR_APP) && ./configure \ >> --prefix=/usr \ >> --sysconfdir=/etc/dhcp \ >> --with-srv-lease- >> file=/var/state/dhcp/dhcpd.leases \ >> - --disable-static \ >> --enable-paranoia \ >> --enable-early-chroot \ >> --disable-dhcpv6
I think this *should not* break. This might be a regression in gzip then. Do you have a snippet of the build log of the error? -Michael On Tue, 2016-03-08 at 18:03 +0100, Marcel Lorenz wrote: > Am 2016-03-08 15:26, schrieb Michael Tremer: > > Hi, > > > > what is the build issue you are trying to solve here? > > > > Copying in a highly outdated version of the bind libs is from my > > point > > of view a big security risk. > > > > -Michael > > > > On Tue, 2016-03-08 at 11:09 +0100, Marcel Lorenz wrote: > > > Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org> > Hi, > > you have right, the old bind is a security risk! > > This is the current lfs file without patch: > ***** > cd $(DIR_APP) && patch -Np1 < > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch > > # Remove bundled BIND stuff. > # (requires newer autoconf) > #rm -rfv $(DIR_APP)/bind/bind.tar.gz > #cd $(DIR_APP) && autoreconf --verbose --force --install > > cd $(DIR_APP) && \ > ***** > > The error in log is "use tar axf to extract..." > > The old bind is extracted while make runs. After gzip update this > not > working more automatic. > They only need some files from bind archive to built the isc-dhcp > package. Bind itself is not used. > (When i understood this correct) > > The: "cd $(DIR_APP)/bind && tar -axf bind.tar.gz" extract this > before > make runs.. That's all.. > > Greetings, > Marcel > > > > > > > > --- > > > lfs/dhcp | 10 ++-------- > > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > > > diff --git a/lfs/dhcp b/lfs/dhcp > > > index 9a89d40..cec8628 100644 > > > --- a/lfs/dhcp > > > +++ b/lfs/dhcp > > > @@ -99,17 +99,11 @@ $(TARGET) : $(patsubst > > > %,$(DIR_DL)/%,$(objects)) > > > cd $(DIR_APP) && patch -Np1 < > > > $(DIR_SRC)/src/patches/dhcp/dhcp-gpxe-cid.patch > > > cd $(DIR_APP) && patch -Np1 < > > > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch > > > > > > - # Remove bundled BIND stuff. > > > - # (requires newer autoconf) > > > - #rm -rfv $(DIR_APP)/bind/bind.tar.gz > > > - #cd $(DIR_APP) && autoreconf --verbose --force --install > > > - > > > - cd $(DIR_APP) && \ > > > - ./configure \ > > > + cd $(DIR_APP)/bind && tar -axf bind.tar.gz > > > + cd $(DIR_APP) && ./configure \ > > > --prefix=/usr \ > > > --sysconfdir=/etc/dhcp \ > > > --with-srv-lease- > > > file=/var/state/dhcp/dhcpd.leases \ > > > - --disable-static \ > > > --enable-paranoia \ > > > --enable-early-chroot \ > > > --disable-dhcpv6 >
:) as you wish: ***** Now you can type make to build ISC DHCP cd /usr/src/dhcp-4.3.1 && make -j5 make[1]: Entering directory '/usr/src/dhcp-4.3.1' Making all in bind make[2]: Entering directory '/usr/src/dhcp-4.3.1/bind' tar: Archive is compressed. Use -z option tar: Error is not recoverable: exiting now Makefile:33: recipe for target 'all' failed **** Marcel Am 2016-03-08 18:06, schrieb Michael Tremer: > I think this *should not* break. This might be a regression in gzip > then. > > Do you have a snippet of the build log of the error? > > -Michael > > On Tue, 2016-03-08 at 18:03 +0100, Marcel Lorenz wrote: >> Am 2016-03-08 15:26, schrieb Michael Tremer: >> > Hi, >> > >> > what is the build issue you are trying to solve here? >> > >> > Copying in a highly outdated version of the bind libs is from my >> > point >> > of view a big security risk. >> > >> > -Michael >> > >> > On Tue, 2016-03-08 at 11:09 +0100, Marcel Lorenz wrote: >> > > Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org> >> Hi, >> >> you have right, the old bind is a security risk! >> >> This is the current lfs file without patch: >> ***** >> cd $(DIR_APP) && patch -Np1 < >> $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch >> >> # Remove bundled BIND stuff. >> # (requires newer autoconf) >> #rm -rfv $(DIR_APP)/bind/bind.tar.gz >> #cd $(DIR_APP) && autoreconf --verbose --force --install >> >> cd $(DIR_APP) && \ >> ***** >> >> The error in log is "use tar axf to extract..." >> >> The old bind is extracted while make runs. After gzip update this >> not >> working more automatic. >> They only need some files from bind archive to built the isc-dhcp >> package. Bind itself is not used. >> (When i understood this correct) >> >> The: "cd $(DIR_APP)/bind && tar -axf bind.tar.gz" extract this >> before >> make runs.. That's all.. >> >> Greetings, >> Marcel >> >> >> > > >> > > --- >> > > lfs/dhcp | 10 ++-------- >> > > 1 file changed, 2 insertions(+), 8 deletions(-) >> > > >> > > diff --git a/lfs/dhcp b/lfs/dhcp >> > > index 9a89d40..cec8628 100644 >> > > --- a/lfs/dhcp >> > > +++ b/lfs/dhcp >> > > @@ -99,17 +99,11 @@ $(TARGET) : $(patsubst >> > > %,$(DIR_DL)/%,$(objects)) >> > > cd $(DIR_APP) && patch -Np1 < >> > > $(DIR_SRC)/src/patches/dhcp/dhcp-gpxe-cid.patch >> > > cd $(DIR_APP) && patch -Np1 < >> > > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch >> > > >> > > - # Remove bundled BIND stuff. >> > > - # (requires newer autoconf) >> > > - #rm -rfv $(DIR_APP)/bind/bind.tar.gz >> > > - #cd $(DIR_APP) && autoreconf --verbose --force --install >> > > - >> > > - cd $(DIR_APP) && \ >> > > - ./configure \ >> > > + cd $(DIR_APP)/bind && tar -axf bind.tar.gz >> > > + cd $(DIR_APP) && ./configure \ >> > > --prefix=/usr \ >> > > --sysconfdir=/etc/dhcp \ >> > > --with-srv-lease- >> > > file=/var/state/dhcp/dhcpd.leases \ >> > > - --disable-static \ >> > > --enable-paranoia \ >> > > --enable-early-chroot \ >> > > --disable-dhcpv6 >>
Hmm, this is not giving away much. I will have a look myself and get back to you. This might take a few days though... -Michael On Tue, 2016-03-08 at 18:18 +0100, Marcel Lorenz wrote: > :) as you wish: > > ***** > Now you can type make to build ISC DHCP > > cd /usr/src/dhcp-4.3.1 && make -j5 > make[1]: Entering directory '/usr/src/dhcp-4.3.1' > Making all in bind > make[2]: Entering directory '/usr/src/dhcp-4.3.1/bind' > tar: Archive is compressed. Use -z option > tar: Error is not recoverable: exiting now > Makefile:33: recipe for target 'all' failed > **** > > Marcel > > > > Am 2016-03-08 18:06, schrieb Michael Tremer: > > I think this *should not* break. This might be a regression in gzip > > then. > > > > Do you have a snippet of the build log of the error? > > > > -Michael > > > > On Tue, 2016-03-08 at 18:03 +0100, Marcel Lorenz wrote: > > > Am 2016-03-08 15:26, schrieb Michael Tremer: > > > > Hi, > > > > > > > > what is the build issue you are trying to solve here? > > > > > > > > Copying in a highly outdated version of the bind libs is from > > > > my > > > > point > > > > of view a big security risk. > > > > > > > > -Michael > > > > > > > > On Tue, 2016-03-08 at 11:09 +0100, Marcel Lorenz wrote: > > > > > Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org> > > > Hi, > > > > > > you have right, the old bind is a security risk! > > > > > > This is the current lfs file without patch: > > > ***** > > > cd $(DIR_APP) && patch -Np1 < > > > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch > > > > > > # Remove bundled BIND stuff. > > > # (requires newer autoconf) > > > #rm -rfv $(DIR_APP)/bind/bind.tar.gz > > > #cd $(DIR_APP) && autoreconf --verbose --force --install > > > > > > cd $(DIR_APP) && \ > > > ***** > > > > > > The error in log is "use tar axf to extract..." > > > > > > The old bind is extracted while make runs. After gzip update this > > > not > > > working more automatic. > > > They only need some files from bind archive to built the isc- > > > dhcp > > > package. Bind itself is not used. > > > (When i understood this correct) > > > > > > The: "cd $(DIR_APP)/bind && tar -axf bind.tar.gz" extract this > > > before > > > make runs.. That's all.. > > > > > > Greetings, > > > Marcel > > > > > > > > > > > > > > > > --- > > > > > lfs/dhcp | 10 ++-------- > > > > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > > > > > > > diff --git a/lfs/dhcp b/lfs/dhcp > > > > > index 9a89d40..cec8628 100644 > > > > > --- a/lfs/dhcp > > > > > +++ b/lfs/dhcp > > > > > @@ -99,17 +99,11 @@ $(TARGET) : $(patsubst > > > > > %,$(DIR_DL)/%,$(objects)) > > > > > cd $(DIR_APP) && patch -Np1 < > > > > > $(DIR_SRC)/src/patches/dhcp/dhcp-gpxe-cid.patch > > > > > cd $(DIR_APP) && patch -Np1 < > > > > > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch > > > > > > > > > > - # Remove bundled BIND stuff. > > > > > - # (requires newer autoconf) > > > > > - #rm -rfv $(DIR_APP)/bind/bind.tar.gz > > > > > - #cd $(DIR_APP) && autoreconf --verbose --force -- > > > > > install > > > > > - > > > > > - cd $(DIR_APP) && \ > > > > > - ./configure \ > > > > > + cd $(DIR_APP)/bind && tar -axf bind.tar.gz > > > > > + cd $(DIR_APP) && ./configure \ > > > > > --prefix=/usr \ > > > > > --sysconfdir=/etc/dhcp \ > > > > > --with-srv-lease- > > > > > file=/var/state/dhcp/dhcpd.leases \ > > > > > - --disable-static \ > > > > > --enable-paranoia \ > > > > > --enable-early-chroot \ > > > > > --disable-dhcpv6 > > > >
Hi, I just applied the update of gzip and it built through. So I believe we can drop the patch for DHCP. Best, -Michael On Tue, 2016-03-08 at 22:39 +0000, Michael Tremer wrote: > Hmm, this is not giving away much. I will have a look myself and get > back to you. This might take a few days though... > > -Michael > > On Tue, 2016-03-08 at 18:18 +0100, Marcel Lorenz wrote: > > :) as you wish: > > > > ***** > > Now you can type make to build ISC DHCP > > > > cd /usr/src/dhcp-4.3.1 && make -j5 > > make[1]: Entering directory '/usr/src/dhcp-4.3.1' > > Making all in bind > > make[2]: Entering directory '/usr/src/dhcp-4.3.1/bind' > > tar: Archive is compressed. Use -z option > > tar: Error is not recoverable: exiting now > > Makefile:33: recipe for target 'all' failed > > **** > > > > Marcel > > > > > > > > Am 2016-03-08 18:06, schrieb Michael Tremer: > > > I think this *should not* break. This might be a regression in > > > gzip > > > then. > > > > > > Do you have a snippet of the build log of the error? > > > > > > -Michael > > > > > > On Tue, 2016-03-08 at 18:03 +0100, Marcel Lorenz wrote: > > > > Am 2016-03-08 15:26, schrieb Michael Tremer: > > > > > Hi, > > > > > > > > > > what is the build issue you are trying to solve here? > > > > > > > > > > Copying in a highly outdated version of the bind libs is from > > > > > my > > > > > point > > > > > of view a big security risk. > > > > > > > > > > -Michael > > > > > > > > > > On Tue, 2016-03-08 at 11:09 +0100, Marcel Lorenz wrote: > > > > > > Signed-off-by: Marcel Lorenz <marcel.lorenz@ipfire.org> > > > > Hi, > > > > > > > > you have right, the old bind is a security risk! > > > > > > > > This is the current lfs file without patch: > > > > ***** > > > > cd $(DIR_APP) && patch -Np1 < > > > > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch > > > > > > > > # Remove bundled BIND stuff. > > > > # (requires newer autoconf) > > > > #rm -rfv $(DIR_APP)/bind/bind.tar.gz > > > > #cd $(DIR_APP) && autoreconf --verbose --force -- > > > > install > > > > > > > > cd $(DIR_APP) && \ > > > > ***** > > > > > > > > The error in log is "use tar axf to extract..." > > > > > > > > The old bind is extracted while make runs. After gzip update > > > > this > > > > not > > > > working more automatic. > > > > They only need some files from bind archive to built the isc- > > > > dhcp > > > > package. Bind itself is not used. > > > > (When i understood this correct) > > > > > > > > The: "cd $(DIR_APP)/bind && tar -axf bind.tar.gz" extract this > > > > before > > > > make runs.. That's all.. > > > > > > > > Greetings, > > > > Marcel > > > > > > > > > > > > > > > > > > > > --- > > > > > > lfs/dhcp | 10 ++-------- > > > > > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > > > > > > > > > diff --git a/lfs/dhcp b/lfs/dhcp > > > > > > index 9a89d40..cec8628 100644 > > > > > > --- a/lfs/dhcp > > > > > > +++ b/lfs/dhcp > > > > > > @@ -99,17 +99,11 @@ $(TARGET) : $(patsubst > > > > > > %,$(DIR_DL)/%,$(objects)) > > > > > > cd $(DIR_APP) && patch -Np1 < > > > > > > $(DIR_SRC)/src/patches/dhcp/dhcp-gpxe-cid.patch > > > > > > cd $(DIR_APP) && patch -Np1 < > > > > > > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch > > > > > > > > > > > > - # Remove bundled BIND stuff. > > > > > > - # (requires newer autoconf) > > > > > > - #rm -rfv $(DIR_APP)/bind/bind.tar.gz > > > > > > - #cd $(DIR_APP) && autoreconf --verbose --force -- > > > > > > install > > > > > > - > > > > > > - cd $(DIR_APP) && \ > > > > > > - ./configure \ > > > > > > + cd $(DIR_APP)/bind && tar -axf bind.tar.gz > > > > > > + cd $(DIR_APP) && ./configure \ > > > > > > --prefix=/usr \ > > > > > > --sysconfdir=/etc/dhcp \ > > > > > > --with-srv-lease- > > > > > > file=/var/state/dhcp/dhcpd.leases \ > > > > > > - --disable-static \ > > > > > > --enable-paranoia \ > > > > > > --enable-early-chroot \ > > > > > > --disable-dhcpv6 > > > >