diff mbox series

flash-images: Drop 2gb-ext4 from image filename

Message ID 20220808202742.1120200-1-michael.tremer@ipfire.org
State Accepted
Commit 2e58337291fc2073f0484e24e34c0b6c0e29603f
Headers
Series flash-images: Drop 2gb-ext4 from image filename |

Commit Message

Michael Tremer Aug. 8, 2022, 8:27 p.m. UTC 
  This is now being dropped since the image won't fit onto a 2GB device
any more and since there is only one type of image, we don't need to
state the filesystem type.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 lfs/flash-images | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jon Murphy Aug. 9, 2022, 7:03 p.m. UTC | #1 
I’ve always been curious about the 2 GB max size. 

When the internet was slow and HDs were expensive it made perfect sense. But I am curious why not 3 GB or 4 GB?

No rush - just curious.


Jon

> On Aug 8, 2022, at 3:27 PM, Michael Tremer <michael.tremer@ipfire.org> wrote:
> 
> This is now being dropped since the image won't fit onto a 2GB device
> any more and since there is only one type of image, we don't need to
> state the filesystem type.
> 
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
> lfs/flash-images | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lfs/flash-images b/lfs/flash-images
> index b4fde8dd9..af78f5de9 100644
> --- a/lfs/flash-images
> +++ b/lfs/flash-images
> @@ -36,7 +36,7 @@ ifeq "$(EFI)" "1"
> endif
> PART_ROOT  = /dev/mapper/$(patsubst /dev/%,%,$(DEVICE))p3
> 
> -IMAGE_FILE = /install/images/$(SNAME)-$(VERSION).2gb-ext4.$(BUILD_ARCH)-full-core$(CORE).img.xz
> +IMAGE_FILE = /install/images/$(SNAME)-$(VERSION)-core$(CORE)-$(BUILD_ARCH).img.xz
> 
> FSTAB_FMT = UUID=%s %-8s %-4s %-10s %d %d\n
> 
> -- 
> 2.30.2
>
Arne Fitzenreiter Aug. 10, 2022, 7:44 a.m. UTC | #2 
Am 2022-08-09 21:03, schrieb Jon Murphy:
> I’ve always been curious about the 2 GB max size.

It was not the max size. It was the minimal size of the media that could 
used.
Now it is larger so 4GB cards are now minimum.
At first boot IPFire resize it to the size of the used media up to
2 TB (max size of a MBR partitioned disk)


> 
> When the internet was slow and HDs were expensive it made perfect
> sense. But I am curious why not 3 GB or 4 GB?
> 
> No rush - just curious.
> 
> 
> Jon
> 
>> On Aug 8, 2022, at 3:27 PM, Michael Tremer <michael.tremer@ipfire.org> 
>> wrote:
>> 
>> This is now being dropped since the image won't fit onto a 2GB device
>> any more and since there is only one type of image, we don't need to
>> state the filesystem type.
>> 
>> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
>> ---
>> lfs/flash-images | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/lfs/flash-images b/lfs/flash-images
>> index b4fde8dd9..af78f5de9 100644
>> --- a/lfs/flash-images
>> +++ b/lfs/flash-images
>> @@ -36,7 +36,7 @@ ifeq "$(EFI)" "1"
>> endif
>> PART_ROOT  = /dev/mapper/$(patsubst /dev/%,%,$(DEVICE))p3
>> 
>> -IMAGE_FILE = 
>> /install/images/$(SNAME)-$(VERSION).2gb-ext4.$(BUILD_ARCH)-full-core$(CORE).img.xz
>> +IMAGE_FILE = 
>> /install/images/$(SNAME)-$(VERSION)-core$(CORE)-$(BUILD_ARCH).img.xz
>> 
>> FSTAB_FMT = UUID=%s %-8s %-4s %-10s %d %d\n
>> 
>> --
>> 2.30.2
>>
diff mbox series

Patch

diff --git a/lfs/flash-images b/lfs/flash-images
index b4fde8dd9..af78f5de9 100644
--- a/lfs/flash-images
+++ b/lfs/flash-images
@@ -36,7 +36,7 @@  ifeq "$(EFI)" "1"
 endif
 PART_ROOT  = /dev/mapper/$(patsubst /dev/%,%,$(DEVICE))p3
 
-IMAGE_FILE = /install/images/$(SNAME)-$(VERSION).2gb-ext4.$(BUILD_ARCH)-full-core$(CORE).img.xz
+IMAGE_FILE = /install/images/$(SNAME)-$(VERSION)-core$(CORE)-$(BUILD_ARCH).img.xz
 
 FSTAB_FMT = UUID=%s %-8s %-4s %-10s %d %d\n