ddns: Update to 012

Message ID 20191105093744.4931-1-stefan.schantl@ipfire.org
State Accepted
Commit 3e9f88bc65213150f0fc975f360d835c1423f622
Headers
Series ddns: Update to 012 |

Commit Message

Stefan Schantl Nov. 5, 2019, 9:37 a.m. UTC
  Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 lfs/ddns | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Michael Tremer Nov. 5, 2019, 10:18 a.m. UTC | #1
Hi Stefan,

Yes, finally.

However, I cannot find all of those commits for this release in the master branch.

Could you check and potentially push again? I just think you didn’t push master.

  https://git.ipfire.org/?p=ddns.git;a=summary

This one just shows a slightly typo-ed tag:

  https://git.ipfire.org/?p=ddns.git;a=shortlog;h=ca9c381a5388ff10243048903f11192b95518c72

Are none of the urgent bug fixes in this release?

-Michael

> On 5 Nov 2019, at 09:37, Stefan Schantl <stefan.schantl@ipfire.org> wrote:
> 
> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
> ---
> lfs/ddns | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/ddns b/lfs/ddns
> index cd56ee72b..a6ca2e35d 100644
> --- a/lfs/ddns
> +++ b/lfs/ddns
> @@ -24,7 +24,7 @@
> 
> include Config
> 
> -VER        = 011
> +VER        = 012
> 
> THISAPP    = ddns-$(VER)
> DL_FILE    = $(THISAPP).tar.xz
> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_MD5 = f0399ba5bad3272f32e539c45cd1abe9
> +$(DL_FILE)_MD5 = 00e70e8bf619148e14b6f6836314bbb7
> 
> install : $(TARGET)
> 
> -- 
> 2.20.1
>
  
Stefan Schantl Nov. 5, 2019, 12:16 p.m. UTC | #2
Hello Michael,

the DDNS git is correct like it actually is. Every single patch which
was located on the ddns Mailing list has been merged.

What are that "urgent bug fixes" which you asked about?

Best regards,

-Stefan
> Hi Stefan,
> 
> Yes, finally.
> 
> However, I cannot find all of those commits for this release in the
> master branch.
> 
> Could you check and potentially push again? I just think you didn’t
> push master.
> 
>   https://git.ipfire.org/?p=ddns.git;a=summary
> 
> This one just shows a slightly typo-ed tag:
> 
>   
> https://git.ipfire.org/?p=ddns.git;a=shortlog;h=ca9c381a5388ff10243048903f11192b95518c72
> 
> Are none of the urgent bug fixes in this release?
> 
> -Michael
> 
> > On 5 Nov 2019, at 09:37, Stefan Schantl <stefan.schantl@ipfire.org>
> > wrote:
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
> > ---
> > lfs/ddns | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lfs/ddns b/lfs/ddns
> > index cd56ee72b..a6ca2e35d 100644
> > --- a/lfs/ddns
> > +++ b/lfs/ddns
> > @@ -24,7 +24,7 @@
> > 
> > include Config
> > 
> > -VER        = 011
> > +VER        = 012
> > 
> > THISAPP    = ddns-$(VER)
> > DL_FILE    = $(THISAPP).tar.xz
> > @@ -40,7 +40,7 @@ objects = $(DL_FILE)
> > 
> > $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> > 
> > -$(DL_FILE)_MD5 = f0399ba5bad3272f32e539c45cd1abe9
> > +$(DL_FILE)_MD5 = 00e70e8bf619148e14b6f6836314bbb7
> > 
> > install : $(TARGET)
> > 
> > -- 
> > 2.20.1
> >
  
Michael Tremer Nov. 5, 2019, 3:51 p.m. UTC | #3
> On 5 Nov 2019, at 12:16, Stefan Schantl <stefan.schantl@ipfire.org> wrote:
> 
> Hello Michael,
> 
> the DDNS git is correct like it actually is. Every single patch which
> was located on the ddns Mailing list has been merged.

Indeed.

> 
> What are that "urgent bug fixes" which you asked about?

https://bugzilla.ipfire.org/show_bug.cgi?id=12195
https://bugzilla.ipfire.org/show_bug.cgi?id=11561

These are easy. Please tell reporters that they should send potential fixes to the mailing lists.

Best,
-Michael

> 
> Best regards,
> 
> -Stefan
>> Hi Stefan,
>> 
>> Yes, finally.
>> 
>> However, I cannot find all of those commits for this release in the
>> master branch.
>> 
>> Could you check and potentially push again? I just think you didn’t
>> push master.
>> 
>>  https://git.ipfire.org/?p=ddns.git;a=summary
>> 
>> This one just shows a slightly typo-ed tag:
>> 
>> 
>> https://git.ipfire.org/?p=ddns.git;a=shortlog;h=ca9c381a5388ff10243048903f11192b95518c72
>> 
>> Are none of the urgent bug fixes in this release?
>> 
>> -Michael
>> 
>>> On 5 Nov 2019, at 09:37, Stefan Schantl <stefan.schantl@ipfire.org>
>>> wrote:
>>> 
>>> Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
>>> ---
>>> lfs/ddns | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/lfs/ddns b/lfs/ddns
>>> index cd56ee72b..a6ca2e35d 100644
>>> --- a/lfs/ddns
>>> +++ b/lfs/ddns
>>> @@ -24,7 +24,7 @@
>>> 
>>> include Config
>>> 
>>> -VER        = 011
>>> +VER        = 012
>>> 
>>> THISAPP    = ddns-$(VER)
>>> DL_FILE    = $(THISAPP).tar.xz
>>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>> 
>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>> 
>>> -$(DL_FILE)_MD5 = f0399ba5bad3272f32e539c45cd1abe9
>>> +$(DL_FILE)_MD5 = 00e70e8bf619148e14b6f6836314bbb7
>>> 
>>> install : $(TARGET)
>>> 
>>> -- 
>>> 2.20.1
>>> 
>
  

Patch

diff --git a/lfs/ddns b/lfs/ddns
index cd56ee72b..a6ca2e35d 100644
--- a/lfs/ddns
+++ b/lfs/ddns
@@ -24,7 +24,7 @@ 
 
 include Config
 
-VER        = 011
+VER        = 012
 
 THISAPP    = ddns-$(VER)
 DL_FILE    = $(THISAPP).tar.xz
@@ -40,7 +40,7 @@  objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = f0399ba5bad3272f32e539c45cd1abe9
+$(DL_FILE)_MD5 = 00e70e8bf619148e14b6f6836314bbb7
 
 install : $(TARGET)