[2/2] apache / WPAD: Add correct MIME type for wpad.dat andproxy.pac

Message ID 1555545258-20523-2-git-send-email-ipfire@starkstromkonsument.de
State Accepted
Commit 68d7ae338e7b509fe00b42c3c44634cf18872056
Headers
Series [1/2] squid / WPAD: Add GUI for exception-files for generationof proxy.pac |

Commit Message

Alexander Koch April 18, 2019, 9:54 a.m. UTC
  Some clients require the correct MIME type to be set for accepting/handling the Proxy-Settings properly.

See: http://findproxyforurl.com/deploying-wpad/

Signed-off-by: Alexander Koch <ipfire@starkstromkonsument.de>
---
 config/etc/mime.types | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Alexander Koch April 24, 2019, 1:23 a.m. UTC | #1
Hello Michael,

thank you for reviewing and merging my patches and preventing me from 
getting "hurt" for my apostrophes ;-)

This patch has not been merged though. Did you skip it on purpose or by 
accident?

Regards, Alex


Am 18.04.19 um 01:54 schrieb Alexander Koch:
> Some clients require the correct MIME type to be set for accepting/handling the Proxy-Settings properly.
>
> See: http://findproxyforurl.com/deploying-wpad/
>
> Signed-off-by: Alexander Koch <ipfire@starkstromkonsument.de>
> ---
>   config/etc/mime.types | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/config/etc/mime.types b/config/etc/mime.types
> index bf088b0..af82d48 100644
> --- a/config/etc/mime.types
> +++ b/config/etc/mime.types
> @@ -168,6 +168,8 @@ application/x-javascript	js
>   application/x-koan		skp skd skt skm
>   application/x-latex		latex
>   application/x-netcdf		nc cdf
> +application/x-ns-proxy-autoconfig       pac
> +application/x-ns-proxy-autoconfig       dat
>   # The standard is that rpm is audio/x-pn-realaudio-plugin... oh well...
>   application/x-rpm		rpm
>   application/x-sh		sh
  
Michael Tremer April 24, 2019, 8:55 p.m. UTC | #2
Hi,

> On 23 Apr 2019, at 16:23, Alexander Koch <ipfire@starkstromkonsument.de> wrote:
> 
> Hello Michael,
> 
> thank you for reviewing and merging my patches and preventing me from getting "hurt" for my apostrophes ;-)
> 
> This patch has not been merged though. Did you skip it on purpose or by accident?

No, I missed this. Thanks for reminding me.

We should attempt to keep patchsets together in the future and if one patch is changed, resending the whole patchset. That will make sure that my old brain does not forget things so easily.

-Michael

> 
> Regards, Alex
> 
> 
> Am 18.04.19 um 01:54 schrieb Alexander Koch:
>> Some clients require the correct MIME type to be set for accepting/handling the Proxy-Settings properly.
>> 
>> See: http://findproxyforurl.com/deploying-wpad/
>> 
>> Signed-off-by: Alexander Koch <ipfire@starkstromkonsument.de>
>> ---
>>  config/etc/mime.types | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/config/etc/mime.types b/config/etc/mime.types
>> index bf088b0..af82d48 100644
>> --- a/config/etc/mime.types
>> +++ b/config/etc/mime.types
>> @@ -168,6 +168,8 @@ application/x-javascript	js
>>  application/x-koan		skp skd skt skm
>>  application/x-latex		latex
>>  application/x-netcdf		nc cdf
>> +application/x-ns-proxy-autoconfig       pac
>> +application/x-ns-proxy-autoconfig       dat
>>  # The standard is that rpm is audio/x-pn-realaudio-plugin... oh well...
>>  application/x-rpm		rpm
>>  application/x-sh		sh
  

Patch

diff --git a/config/etc/mime.types b/config/etc/mime.types
index bf088b0..af82d48 100644
--- a/config/etc/mime.types
+++ b/config/etc/mime.types
@@ -168,6 +168,8 @@  application/x-javascript	js
 application/x-koan		skp skd skt skm
 application/x-latex		latex
 application/x-netcdf		nc cdf
+application/x-ns-proxy-autoconfig       pac
+application/x-ns-proxy-autoconfig       dat
 # The standard is that rpm is audio/x-pn-realaudio-plugin... oh well...
 application/x-rpm		rpm
 application/x-sh		sh