[16/21] linux: Disable ACPI configfs support

Message ID 7897a29a-1dae-0158-f207-f67a3d91ae16@ipfire.org
State Accepted
Commit 0186d8d0e1dea29c2ec6aaefe97ee28cc6171226
Headers
Series linux: Update to 5.15.85 and backport many IPFire 3.x changes |

Commit Message

Peter Müller Dec. 26, 2022, 7:29 p.m. UTC
  This is disabled in IPFire 3.x, and projects such as grsecurity
recommend doing so for security reasons as well. Also, skimming through
our source code, there is no point where this ACPI configfs would have
been explicitly mounted, which leads to the assumption that we never
used it anyway.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 config/kernel/kernel.config.x86_64-ipfire | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Michael Tremer Dec. 27, 2022, 11:29 a.m. UTC | #1
Acked-by: Michael Tremer <michael.tremer@ipfire.org>

> On 26 Dec 2022, at 20:29, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> This is disabled in IPFire 3.x, and projects such as grsecurity
> recommend doing so for security reasons as well. Also, skimming through
> our source code, there is no point where this ACPI configfs would have
> been explicitly mounted, which leads to the assumption that we never
> used it anyway.
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> config/kernel/kernel.config.x86_64-ipfire | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
> index 763c7c842..5a8a9e14b 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -552,7 +552,7 @@ CONFIG_ACPI_APEI_MEMORY_FAILURE=y
> CONFIG_ACPI_WATCHDOG=y
> CONFIG_ACPI_EXTLOG=m
> CONFIG_ACPI_ADXL=y
> -CONFIG_ACPI_CONFIGFS=m
> +# CONFIG_ACPI_CONFIGFS is not set
> CONFIG_PMIC_OPREGION=y
> # CONFIG_XPOWER_PMIC_OPREGION is not set
> CONFIG_ACPI_VIOT=y
> -- 
> 2.35.3
  

Patch

diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
index 763c7c842..5a8a9e14b 100644
--- a/config/kernel/kernel.config.x86_64-ipfire
+++ b/config/kernel/kernel.config.x86_64-ipfire
@@ -552,7 +552,7 @@  CONFIG_ACPI_APEI_MEMORY_FAILURE=y
 CONFIG_ACPI_WATCHDOG=y
 CONFIG_ACPI_EXTLOG=m
 CONFIG_ACPI_ADXL=y
-CONFIG_ACPI_CONFIGFS=m
+# CONFIG_ACPI_CONFIGFS is not set
 CONFIG_PMIC_OPREGION=y
 # CONFIG_XPOWER_PMIC_OPREGION is not set
 CONFIG_ACPI_VIOT=y