Message ID | 20220222125135.1211290-41-michael.tremer@ipfire.org |
---|---|
State | Accepted |
Commit | 0b6ba4a0ca2e08cd9fc56e99e80d33a6fe88b395 |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4K2zbW2qRmz3xgb for <patchwork@web04.haj.ipfire.org>; Tue, 22 Feb 2022 12:52:39 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4K2zZv35d4z5bb; Tue, 22 Feb 2022 12:52:07 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4K2zZt6r6pz32MW; Tue, 22 Feb 2022 12:52:06 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4K2zZj2hJJz32Mv for <development@lists.ipfire.org>; Tue, 22 Feb 2022 12:51:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4K2zZj0CQ6z5WZ; Tue, 22 Feb 2022 12:51:57 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1645534317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S1znq3pbH8Yf92uNMGAH1T88MtSK10TtAKAV4rk7FTQ=; b=4G5y+ahH8jnEAL3lo2lLQJj955gb0t9u/SsY2cIrEdyeDStjUyVzy0IF0MxEyh9CL3rX5e 3+0OPh62938qj8Bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1645534317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S1znq3pbH8Yf92uNMGAH1T88MtSK10TtAKAV4rk7FTQ=; b=KCNh/S6mB8bv1AGn27KnGcseQKccv/eu53HD4DMJAY51mg6h1+D3d2j8Be/4CXBNqdl8jm Vo+XUb8X5RbZV2FhiD6oHbWLeIuIWmc7yth0Ju5+E1AhgGWh6qcSy3yUkHPvGbQmAJnfSW OQoRBRpiUFlr3peKED0d0Go2KcozM7PE/4T1KyQa4CY+SyoFnR0vi6JoA0krk7SHCxSQVw 7AzrbDz8RAG7E/E9B7xH8FBIfJXe3zAXw/+gvZ2IMrA12N7RYJbUeTbMxudf9ZGX5ipNuC mlDiYg+CY8u9CA7DhzcJjFlWInQOFdYK7Pnb/7yQvUa04o/hrVOwv23HuKaYsQ== From: Michael Tremer <michael.tremer@ipfire.org> To: development@lists.ipfire.org Subject: [PATCH 40/50] gcc: Compile without ZSTD Date: Tue, 22 Feb 2022 12:51:25 +0000 Message-Id: <20220222125135.1211290-41-michael.tremer@ipfire.org> In-Reply-To: <20220222125135.1211290-1-michael.tremer@ipfire.org> References: <20220222125135.1211290-1-michael.tremer@ipfire.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Cc: Michael Tremer <michael.tremer@ipfire.org> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
[01/50] expat: Update to version 2.4.6 - Security/CVE fixes
|
|
Commit Message
Michael Tremer
Feb. 22, 2022, 12:51 p.m. UTC
GCC can use ZSTD to compress debugging/LTO information in binary
objects. However, on riscv64, compiling zstd requires libatomic which is
not available at this point.
In order to make the build work, we explicitely disable ZSTD in GCC and
build ZSTD after libatomic is available.
Although ZSTD offers great compression, we won't have any disadvantages
through this change since we do not ship any debugging information and
at this point in time to not use LTO.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
lfs/gcc | 3 ++-
make.sh | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
Comments
Hello Peter, Could you please revert this patch again? Bird seems to (unconditionally) enable LTO which it shouldn’t. This patch shouldn’t break LTO at all, but it does. Since this is not a priority right now, could you please just revert this patch? -Michael > On 22 Feb 2022, at 12:51, Michael Tremer <michael.tremer@ipfire.org> wrote: > > GCC can use ZSTD to compress debugging/LTO information in binary > objects. However, on riscv64, compiling zstd requires libatomic which is > not available at this point. > > In order to make the build work, we explicitely disable ZSTD in GCC and > build ZSTD after libatomic is available. > > Although ZSTD offers great compression, we won't have any disadvantages > through this change since we do not ship any debugging information and > at this point in time to not use LTO. > > Signed-off-by: Michael Tremer <michael.tremer@ipfire.org> > --- > lfs/gcc | 3 ++- > make.sh | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lfs/gcc b/lfs/gcc > index f78891e24..563e94c16 100644 > --- a/lfs/gcc > +++ b/lfs/gcc > @@ -182,7 +182,8 @@ EXTRA_CONFIG += \ > --disable-multilib \ > --with-bugurl=https://bugzilla.ipfire.org \ > --disable-libunwind-exceptions \ > - --enable-gnu-unique-object > + --enable-gnu-unique-object \ > + --without-zstd > > export XCFLAGS = $(CFLAGS) > export TCFLAGS = $(CFLAGS) > diff --git a/make.sh b/make.sh > index cb11b36ab..522fe8401 100755 > --- a/make.sh > +++ b/make.sh > @@ -1079,7 +1079,6 @@ buildbase() { > lfsmake2 tzdata > lfsmake2 cleanup-toolchain > lfsmake2 zlib > - lfsmake2 zstd > lfsmake2 autoconf > lfsmake2 automake > lfsmake2 libtool > @@ -1090,6 +1089,7 @@ buildbase() { > lfsmake2 libxcrypt > lfsmake2 file > lfsmake2 gcc > + lfsmake2 zstd > lfsmake2 sed > lfsmake2 berkeley > lfsmake2 coreutils > -- > 2.30.2 >
Hello Michael, thanks for your reply. Yeah, I saw the nightly builds failing across all architectures, too. The offending patch has been revered: https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=8fa66ce750dee06140e55b689a0645860e005b11 Let's hope everything compiles again _now_ ... :-) Thanks, and best regards, Peter Müller > Hello Peter, > > Could you please revert this patch again? > > Bird seems to (unconditionally) enable LTO which it shouldn’t. This patch shouldn’t break LTO at all, but it does. > > Since this is not a priority right now, could you please just revert this patch? > > -Michael > >> On 22 Feb 2022, at 12:51, Michael Tremer <michael.tremer@ipfire.org> wrote: >> >> GCC can use ZSTD to compress debugging/LTO information in binary >> objects. However, on riscv64, compiling zstd requires libatomic which is >> not available at this point. >> >> In order to make the build work, we explicitely disable ZSTD in GCC and >> build ZSTD after libatomic is available. >> >> Although ZSTD offers great compression, we won't have any disadvantages >> through this change since we do not ship any debugging information and >> at this point in time to not use LTO. >> >> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org> >> --- >> lfs/gcc | 3 ++- >> make.sh | 2 +- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/lfs/gcc b/lfs/gcc >> index f78891e24..563e94c16 100644 >> --- a/lfs/gcc >> +++ b/lfs/gcc >> @@ -182,7 +182,8 @@ EXTRA_CONFIG += \ >> --disable-multilib \ >> --with-bugurl=https://bugzilla.ipfire.org \ >> --disable-libunwind-exceptions \ >> - --enable-gnu-unique-object >> + --enable-gnu-unique-object \ >> + --without-zstd >> >> export XCFLAGS = $(CFLAGS) >> export TCFLAGS = $(CFLAGS) >> diff --git a/make.sh b/make.sh >> index cb11b36ab..522fe8401 100755 >> --- a/make.sh >> +++ b/make.sh >> @@ -1079,7 +1079,6 @@ buildbase() { >> lfsmake2 tzdata >> lfsmake2 cleanup-toolchain >> lfsmake2 zlib >> - lfsmake2 zstd >> lfsmake2 autoconf >> lfsmake2 automake >> lfsmake2 libtool >> @@ -1090,6 +1089,7 @@ buildbase() { >> lfsmake2 libxcrypt >> lfsmake2 file >> lfsmake2 gcc >> + lfsmake2 zstd >> lfsmake2 sed >> lfsmake2 berkeley >> lfsmake2 coreutils >> -- >> 2.30.2 >> >
diff --git a/lfs/gcc b/lfs/gcc index f78891e24..563e94c16 100644 --- a/lfs/gcc +++ b/lfs/gcc @@ -182,7 +182,8 @@ EXTRA_CONFIG += \ --disable-multilib \ --with-bugurl=https://bugzilla.ipfire.org \ --disable-libunwind-exceptions \ - --enable-gnu-unique-object + --enable-gnu-unique-object \ + --without-zstd export XCFLAGS = $(CFLAGS) export TCFLAGS = $(CFLAGS) diff --git a/make.sh b/make.sh index cb11b36ab..522fe8401 100755 --- a/make.sh +++ b/make.sh @@ -1079,7 +1079,6 @@ buildbase() { lfsmake2 tzdata lfsmake2 cleanup-toolchain lfsmake2 zlib - lfsmake2 zstd lfsmake2 autoconf lfsmake2 automake lfsmake2 libtool @@ -1090,6 +1089,7 @@ buildbase() { lfsmake2 libxcrypt lfsmake2 file lfsmake2 gcc + lfsmake2 zstd lfsmake2 sed lfsmake2 berkeley lfsmake2 coreutils