Message ID | 80d9fc05-8163-88d5-e482-08b0a7f7c07e@stalhut.de |
---|---|
State | Accepted |
Headers |
Return-Path: <ddns-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.i.ipfire.org [172.28.1.200]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail01.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by web07.i.ipfire.org (Postfix) with ESMTPS id AC30289FA71 for <patchwork@web07.i.ipfire.org>; Sat, 25 May 2019 22:48:13 +0100 (BST) Received: from mail01.i.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 45BH0r6BgRz51tbw; Sat, 25 May 2019 22:48:12 +0100 (BST) Received: from mail.stalhut-it.de (mail.stalhut-it.de [178.254.6.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 45BH0q05ncz51tbw for <ddns@lists.ipfire.org>; Sat, 25 May 2019 22:48:10 +0100 (BST) Received: from [192.168.57.144] (p5DD4B555.dip0.t-ipconnect.de [93.212.181.85]) by mail.stalhut-it.de (Postfix) with ESMTPSA id 0C7A73D401A4 for <ddns@lists.ipfire.org>; Sat, 25 May 2019 23:48:03 +0200 (CEST) Received-SPF: pass (v16146.1blu.de: connection is authenticated) From: Jan Stalhut <jan@stalhut.de> Subject: [PATCH] add new provider it's DNS (https://www.itsdns.de) To: ddns@lists.ipfire.org Message-ID: <80d9fc05-8163-88d5-e482-08b0a7f7c07e@stalhut.de> Date: Sat, 25 May 2019 23:48:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Language: de-DE Authentication-Results: mail01.ipfire.org; dkim=none; dmarc=none; spf=pass (mail01.ipfire.org: domain of jan@stalhut.de designates 178.254.6.146 as permitted sender) smtp.mailfrom=jan@stalhut.de X-Rspamd-Queue-Id: 45BH0q05ncz51tbw X-Spamd-Result: default: False [-4.34 / 11.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; BAYES_HAM(-3.00)[100.00%]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[ddns@lists.ipfire.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[stalhut.de]; MX_GOOD(-0.01)[mail.stalhut-it.de]; NEURAL_HAM(-1.01)[-0.337,0]; IP_SCORE(-0.02)[country: DE(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[85.181.212.93.zen.spamhaus.org : 127.0.0.10]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:42730, ipnet:178.254.0.0/19, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[] X-Rspamd-Server: mail01.i.ipfire.org X-BeenThere: ddns@lists.ipfire.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List for the IPFire dynamic DNS client <ddns.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/ddns>, <mailto:ddns-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <https://lists.ipfire.org/pipermail/ddns/> List-Post: <mailto:ddns@lists.ipfire.org> List-Help: <mailto:ddns-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/ddns>, <mailto:ddns-request@lists.ipfire.org?subject=subscribe> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ddns-bounces@lists.ipfire.org Sender: "ddns" <ddns-bounces@lists.ipfire.org> |
Series |
add new provider it's DNS (https://www.itsdns.de)
|
|
Commit Message
Jan Stalhut
May 26, 2019, 7:48 a.m. UTC
--- README | 1 + src/ddns/providers.py | 10 ++++++++++ 2 files changed, 11 insertions(+)
Comments
Hello Jan, Thank you for submitting your patch. It looks good to me. But unfortunately I wasn’t able to merge it. I suppose that your email client replaced all tabs with spaces or something: [root@ipfire ddns]# pwclient git-am -p ddns -s 2265 Applying patch #2265 using "git am -s" Description: add new provider it's DNS (https://www.itsdns.de) Applying: add new provider it's DNS (https://www.itsdns.de) error: patch failed: README:67 error: README: patch does not apply error: patch failed: src/ddns/providers.py:1108 error: src/ddns/providers.py: patch does not apply Patch failed at 0001 add new provider it's DNS (https://www.itsdns.de) The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". 'git am' failed with exit status 128 [root@ipfire ddns]# git apply -3 .git/rebase-apply/patch error: patch failed: README:67 Falling back to three-way merge... error: patch failed: README:67 error: README: patch does not apply error: patch failed: src/ddns/providers.py:1108 Falling back to three-way merge... error: patch failed: src/ddns/providers.py:1108 error: src/ddns/providers.py: patch does not apply Could you check that and send again? Best, -Michael > On 25 May 2019, at 22:48, Jan Stalhut <jan@stalhut.de> wrote: > > --- > README | 1 + > src/ddns/providers.py | 10 ++++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/README b/README > index d170858..1c5ffd6 100644 > --- a/README > +++ b/README > @@ -67,6 +67,7 @@ SUPPORTED PROVIDERS: > enom.com > entrydns.net > freedns.afraid.org > + itsdns.de > joker.com > loopia.se > myonlineportal.net > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > index ea723e5..a9a0b03 100644 > --- a/src/ddns/providers.py > +++ b/src/ddns/providers.py > @@ -1108,6 +1108,16 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): > # If we got here, some other update error happened. > raise DDNSUpdateError > > +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): > + handle = "itsdns.de" > + name = "it's DNS" > + website = "http://www.itsdns.de/" > + protocols = ("ipv6", "ipv4") > + > + # Information about the format of the HTTP request is to be > + # found here: https://www.itsdns.de/dynupdatehelp.htm > + > + url = "https://www.itsdns.de/update.php” > And you could add another empty line here, because we usually have two empty lines after a class. > class DDNSProviderJoker(DDNSProtocolDynDNS2, DDNSProvider): > handle = "joker.com" > -- > 2.17.1 > _______________________________________________ > ddns mailing list > ddns@lists.ipfire.org > https://lists.ipfire.org/mailman/listinfo/ddns
Hi Michael, thank you for the fast feedback. Now, you find the patch-file as attachment of this email. I hope this works now. Can you say something on how long it will take to make these changes into an ipfire release? Best regards, Jan Am 26.05.19 um 11:30 schrieb Michael Tremer: > Hello Jan, > > Thank you for submitting your patch. It looks good to me. > > But unfortunately I wasn’t able to merge it. > > I suppose that your email client replaced all tabs with spaces or something: > > [root@ipfire ddns]# pwclient git-am -p ddns -s 2265 > Applying patch #2265 using "git am -s" > Description: add new provider it's DNS (https://www.itsdns.de) > Applying: add new provider it's DNS (https://www.itsdns.de) > error: patch failed: README:67 > error: README: patch does not apply > error: patch failed: src/ddns/providers.py:1108 > error: src/ddns/providers.py: patch does not apply > Patch failed at 0001 add new provider it's DNS (https://www.itsdns.de) > The copy of the patch that failed is found in: .git/rebase-apply/patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > 'git am' failed with exit status 128 > [root@ipfire ddns]# git apply -3 .git/rebase-apply/patch > error: patch failed: README:67 > Falling back to three-way merge... > error: patch failed: README:67 > error: README: patch does not apply > error: patch failed: src/ddns/providers.py:1108 > Falling back to three-way merge... > error: patch failed: src/ddns/providers.py:1108 > error: src/ddns/providers.py: patch does not apply > > Could you check that and send again? > > Best, > -Michael > >> On 25 May 2019, at 22:48, Jan Stalhut <jan@stalhut.de> wrote: >> >> --- >> README | 1 + >> src/ddns/providers.py | 10 ++++++++++ >> 2 files changed, 11 insertions(+) >> >> diff --git a/README b/README >> index d170858..1c5ffd6 100644 >> --- a/README >> +++ b/README >> @@ -67,6 +67,7 @@ SUPPORTED PROVIDERS: >> enom.com >> entrydns.net >> freedns.afraid.org >> + itsdns.de >> joker.com >> loopia.se >> myonlineportal.net >> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >> index ea723e5..a9a0b03 100644 >> --- a/src/ddns/providers.py >> +++ b/src/ddns/providers.py >> @@ -1108,6 +1108,16 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >> # If we got here, some other update error happened. >> raise DDNSUpdateError >> >> +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): >> + handle = "itsdns.de" >> + name = "it's DNS" >> + website = "http://www.itsdns.de/" >> + protocols = ("ipv6", "ipv4") >> + >> + # Information about the format of the HTTP request is to be >> + # found here: https://www.itsdns.de/dynupdatehelp.htm >> + >> + url = "https://www.itsdns.de/update.php” >> > > And you could add another empty line here, because we usually have two empty lines after a class. > >> class DDNSProviderJoker(DDNSProtocolDynDNS2, DDNSProvider): >> handle = "joker.com" >> -- >> 2.17.1 >> _______________________________________________ >> ddns mailing list >> ddns@lists.ipfire.org >> https://lists.ipfire.org/mailman/listinfo/ddns > Mit freundlichen Grüßen Jan Stalhut
Hello Jan, This one time I will accept the file :) The downside of files is that you cannot have inline comments in them which makes the conversation around the patch a bit more difficult. However, this is merged now. I have tagged a new release of ddns and integrated that into the next tree of IPFire: https://git.ipfire.org/?p=ddns.git;a=commitdiff;h=327095f0ea7f80b782664dbc9cb0fce68c7e19cd This will eventually become Core Update 133 and I would suppose that this will be available in around 6 weeks. We don’t even have 132 out, yet. Hope this is okay. Best, -Michael > On 26 May 2019, at 22:01, Jan Stalhut <jan@stalhut.de> wrote: > > Hi Michael, > > thank you for the fast feedback. Now, you find the patch-file as attachment of this email. I hope this works now. > > Can you say something on how long it will take to make these changes into an ipfire release? > > Best regards, > Jan > > > Am 26.05.19 um 11:30 schrieb Michael Tremer: >> Hello Jan, >> Thank you for submitting your patch. It looks good to me. >> But unfortunately I wasn’t able to merge it. >> I suppose that your email client replaced all tabs with spaces or something: >> [root@ipfire ddns]# pwclient git-am -p ddns -s 2265 >> Applying patch #2265 using "git am -s" >> Description: add new provider it's DNS (https://www.itsdns.de) >> Applying: add new provider it's DNS (https://www.itsdns.de) >> error: patch failed: README:67 >> error: README: patch does not apply >> error: patch failed: src/ddns/providers.py:1108 >> error: src/ddns/providers.py: patch does not apply >> Patch failed at 0001 add new provider it's DNS (https://www.itsdns.de) >> The copy of the patch that failed is found in: .git/rebase-apply/patch >> When you have resolved this problem, run "git am --continue". >> If you prefer to skip this patch, run "git am --skip" instead. >> To restore the original branch and stop patching, run "git am --abort". >> 'git am' failed with exit status 128 >> [root@ipfire ddns]# git apply -3 .git/rebase-apply/patch >> error: patch failed: README:67 >> Falling back to three-way merge... >> error: patch failed: README:67 >> error: README: patch does not apply >> error: patch failed: src/ddns/providers.py:1108 >> Falling back to three-way merge... >> error: patch failed: src/ddns/providers.py:1108 >> error: src/ddns/providers.py: patch does not apply >> Could you check that and send again? >> Best, >> -Michael >>> On 25 May 2019, at 22:48, Jan Stalhut <jan@stalhut.de> wrote: >>> >>> --- >>> README | 1 + >>> src/ddns/providers.py | 10 ++++++++++ >>> 2 files changed, 11 insertions(+) >>> >>> diff --git a/README b/README >>> index d170858..1c5ffd6 100644 >>> --- a/README >>> +++ b/README >>> @@ -67,6 +67,7 @@ SUPPORTED PROVIDERS: >>> enom.com >>> entrydns.net >>> freedns.afraid.org >>> + itsdns.de >>> joker.com >>> loopia.se >>> myonlineportal.net >>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>> index ea723e5..a9a0b03 100644 >>> --- a/src/ddns/providers.py >>> +++ b/src/ddns/providers.py >>> @@ -1108,6 +1108,16 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>> # If we got here, some other update error happened. >>> raise DDNSUpdateError >>> >>> +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): >>> + handle = "itsdns.de" >>> + name = "it's DNS" >>> + website = "http://www.itsdns.de/" >>> + protocols = ("ipv6", "ipv4") >>> + >>> + # Information about the format of the HTTP request is to be >>> + # found here: https://www.itsdns.de/dynupdatehelp.htm >>> + >>> + url = "https://www.itsdns.de/update.php” >>> >> And you could add another empty line here, because we usually have two empty lines after a class. >>> class DDNSProviderJoker(DDNSProtocolDynDNS2, DDNSProvider): >>> handle = "joker.com" >>> -- >>> 2.17.1 >>> _______________________________________________ >>> ddns mailing list >>> ddns@lists.ipfire.org >>> https://lists.ipfire.org/mailman/listinfo/ddns > > > Mit freundlichen Grüßen > Jan Stalhut > > -- > Jan Stalhut > Rostocker Str. 21 > 27211 Bassum > > Tel. 04241 8208797 > Mobil 0171 5380915 > > Facebook -> http://facebook.com/jan.stalhut > <0001-add-new-provider-it-s-DNS-https-www.itsdns.de.patch>
Hello Michael, in the meantime, I've updated IPfire on some of my clients to Core Update 134, but there are no new DDNS providers in the web interface. I read on the changelog of Core Update 133 this line: ddns: Some new provides have been added Has anything gone wrong with the update? Best regards, Jan Am 27.05.19 um 17:29 schrieb Michael Tremer: > Hello Jan, > > This one time I will accept the file :) > > The downside of files is that you cannot have inline comments in them which makes the conversation around the patch a bit more difficult. > > However, this is merged now. I have tagged a new release of ddns and integrated that into the next tree of IPFire: > > https://git.ipfire.org/?p=ddns.git;a=commitdiff;h=327095f0ea7f80b782664dbc9cb0fce68c7e19cd > > This will eventually become Core Update 133 and I would suppose that this will be available in around 6 weeks. We don’t even have 132 out, yet. > > Hope this is okay. > > Best, > -Michael > >> On 26 May 2019, at 22:01, Jan Stalhut <jan@stalhut.de> wrote: >> >> Hi Michael, >> >> thank you for the fast feedback. Now, you find the patch-file as attachment of this email. I hope this works now. >> >> Can you say something on how long it will take to make these changes into an ipfire release? >> >> Best regards, >> Jan >> >> >> Am 26.05.19 um 11:30 schrieb Michael Tremer: >>> Hello Jan, >>> Thank you for submitting your patch. It looks good to me. >>> But unfortunately I wasn’t able to merge it. >>> I suppose that your email client replaced all tabs with spaces or something: >>> [root@ipfire ddns]# pwclient git-am -p ddns -s 2265 >>> Applying patch #2265 using "git am -s" >>> Description: add new provider it's DNS (https://www.itsdns.de) >>> Applying: add new provider it's DNS (https://www.itsdns.de) >>> error: patch failed: README:67 >>> error: README: patch does not apply >>> error: patch failed: src/ddns/providers.py:1108 >>> error: src/ddns/providers.py: patch does not apply >>> Patch failed at 0001 add new provider it's DNS (https://www.itsdns.de) >>> The copy of the patch that failed is found in: .git/rebase-apply/patch >>> When you have resolved this problem, run "git am --continue". >>> If you prefer to skip this patch, run "git am --skip" instead. >>> To restore the original branch and stop patching, run "git am --abort". >>> 'git am' failed with exit status 128 >>> [root@ipfire ddns]# git apply -3 .git/rebase-apply/patch >>> error: patch failed: README:67 >>> Falling back to three-way merge... >>> error: patch failed: README:67 >>> error: README: patch does not apply >>> error: patch failed: src/ddns/providers.py:1108 >>> Falling back to three-way merge... >>> error: patch failed: src/ddns/providers.py:1108 >>> error: src/ddns/providers.py: patch does not apply >>> Could you check that and send again? >>> Best, >>> -Michael >>>> On 25 May 2019, at 22:48, Jan Stalhut <jan@stalhut.de> wrote: >>>> >>>> --- >>>> README | 1 + >>>> src/ddns/providers.py | 10 ++++++++++ >>>> 2 files changed, 11 insertions(+) >>>> >>>> diff --git a/README b/README >>>> index d170858..1c5ffd6 100644 >>>> --- a/README >>>> +++ b/README >>>> @@ -67,6 +67,7 @@ SUPPORTED PROVIDERS: >>>> enom.com >>>> entrydns.net >>>> freedns.afraid.org >>>> + itsdns.de >>>> joker.com >>>> loopia.se >>>> myonlineportal.net >>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>>> index ea723e5..a9a0b03 100644 >>>> --- a/src/ddns/providers.py >>>> +++ b/src/ddns/providers.py >>>> @@ -1108,6 +1108,16 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>>> # If we got here, some other update error happened. >>>> raise DDNSUpdateError >>>> >>>> +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): >>>> + handle = "itsdns.de" >>>> + name = "it's DNS" >>>> + website = "http://www.itsdns.de/" >>>> + protocols = ("ipv6", "ipv4") >>>> + >>>> + # Information about the format of the HTTP request is to be >>>> + # found here: https://www.itsdns.de/dynupdatehelp.htm >>>> + >>>> + url = "https://www.itsdns.de/update.php” >>>> >>> And you could add another empty line here, because we usually have two empty lines after a class. >>>> class DDNSProviderJoker(DDNSProtocolDynDNS2, DDNSProvider): >>>> handle = "joker.com" >>>> -- >>>> 2.17.1 >>>> _______________________________________________ >>>> ddns mailing list >>>> ddns@lists.ipfire.org >>>> https://lists.ipfire.org/mailman/listinfo/ddns >> >
Hi Jan, Yes, I broke this in the updater. I simply forgot to include the package. A new installation should already show it. https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=8650d11bc3a6e506e08dd708ec3f86fd566bb182 This will now be shipped with Core Update 135. Sorry for this mess. Best, -Michael > On 3 Jul 2019, at 12:33, Jan Stalhut <jan@stalhut.de> wrote: > > Hello Michael, > > in the meantime, I've updated IPfire on some of my clients to Core Update 134, but there are no new DDNS providers in the web interface. > > I read on the changelog of Core Update 133 this line: > ddns: Some new provides have been added > > Has anything gone wrong with the update? > > Best regards, > Jan > > > Am 27.05.19 um 17:29 schrieb Michael Tremer: >> Hello Jan, >> This one time I will accept the file :) >> The downside of files is that you cannot have inline comments in them which makes the conversation around the patch a bit more difficult. >> However, this is merged now. I have tagged a new release of ddns and integrated that into the next tree of IPFire: >> https://git.ipfire.org/?p=ddns.git;a=commitdiff;h=327095f0ea7f80b782664dbc9cb0fce68c7e19cd >> This will eventually become Core Update 133 and I would suppose that this will be available in around 6 weeks. We don’t even have 132 out, yet. >> Hope this is okay. >> Best, >> -Michael >>> On 26 May 2019, at 22:01, Jan Stalhut <jan@stalhut.de> wrote: >>> >>> Hi Michael, >>> >>> thank you for the fast feedback. Now, you find the patch-file as attachment of this email. I hope this works now. >>> >>> Can you say something on how long it will take to make these changes into an ipfire release? >>> >>> Best regards, >>> Jan >>> >>> >>> Am 26.05.19 um 11:30 schrieb Michael Tremer: >>>> Hello Jan, >>>> Thank you for submitting your patch. It looks good to me. >>>> But unfortunately I wasn’t able to merge it. >>>> I suppose that your email client replaced all tabs with spaces or something: >>>> [root@ipfire ddns]# pwclient git-am -p ddns -s 2265 >>>> Applying patch #2265 using "git am -s" >>>> Description: add new provider it's DNS (https://www.itsdns.de) >>>> Applying: add new provider it's DNS (https://www.itsdns.de) >>>> error: patch failed: README:67 >>>> error: README: patch does not apply >>>> error: patch failed: src/ddns/providers.py:1108 >>>> error: src/ddns/providers.py: patch does not apply >>>> Patch failed at 0001 add new provider it's DNS (https://www.itsdns.de) >>>> The copy of the patch that failed is found in: .git/rebase-apply/patch >>>> When you have resolved this problem, run "git am --continue". >>>> If you prefer to skip this patch, run "git am --skip" instead. >>>> To restore the original branch and stop patching, run "git am --abort". >>>> 'git am' failed with exit status 128 >>>> [root@ipfire ddns]# git apply -3 .git/rebase-apply/patch >>>> error: patch failed: README:67 >>>> Falling back to three-way merge... >>>> error: patch failed: README:67 >>>> error: README: patch does not apply >>>> error: patch failed: src/ddns/providers.py:1108 >>>> Falling back to three-way merge... >>>> error: patch failed: src/ddns/providers.py:1108 >>>> error: src/ddns/providers.py: patch does not apply >>>> Could you check that and send again? >>>> Best, >>>> -Michael >>>>> On 25 May 2019, at 22:48, Jan Stalhut <jan@stalhut.de> wrote: >>>>> >>>>> --- >>>>> README | 1 + >>>>> src/ddns/providers.py | 10 ++++++++++ >>>>> 2 files changed, 11 insertions(+) >>>>> >>>>> diff --git a/README b/README >>>>> index d170858..1c5ffd6 100644 >>>>> --- a/README >>>>> +++ b/README >>>>> @@ -67,6 +67,7 @@ SUPPORTED PROVIDERS: >>>>> enom.com >>>>> entrydns.net >>>>> freedns.afraid.org >>>>> + itsdns.de >>>>> joker.com >>>>> loopia.se >>>>> myonlineportal.net >>>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>>>> index ea723e5..a9a0b03 100644 >>>>> --- a/src/ddns/providers.py >>>>> +++ b/src/ddns/providers.py >>>>> @@ -1108,6 +1108,16 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>>>> # If we got here, some other update error happened. >>>>> raise DDNSUpdateError >>>>> >>>>> +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): >>>>> + handle = "itsdns.de" >>>>> + name = "it's DNS" >>>>> + website = "http://www.itsdns.de/" >>>>> + protocols = ("ipv6", "ipv4") >>>>> + >>>>> + # Information about the format of the HTTP request is to be >>>>> + # found here: https://www.itsdns.de/dynupdatehelp.htm >>>>> + >>>>> + url = "https://www.itsdns.de/update.php” >>>>> >>>> And you could add another empty line here, because we usually have two empty lines after a class. >>>>> class DDNSProviderJoker(DDNSProtocolDynDNS2, DDNSProvider): >>>>> handle = "joker.com" >>>>> -- >>>>> 2.17.1 >>>>> _______________________________________________ >>>>> ddns mailing list >>>>> ddns@lists.ipfire.org >>>>> https://lists.ipfire.org/mailman/listinfo/ddns >>> >
diff --git a/README b/README index d170858..1c5ffd6 100644 --- a/README +++ b/README @@ -67,6 +67,7 @@ SUPPORTED PROVIDERS: enom.com entrydns.net freedns.afraid.org + itsdns.de joker.com loopia.se myonlineportal.net diff --git a/src/ddns/providers.py b/src/ddns/providers.py index ea723e5..a9a0b03 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1108,6 +1108,16 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): # If we got here, some other update error happened. raise DDNSUpdateError +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): + handle = "itsdns.de" + name = "it's DNS" + website = "http://www.itsdns.de/" + protocols = ("ipv6", "ipv4") + + # Information about the format of the HTTP request is to be + # found here: https://www.itsdns.de/dynupdatehelp.htm + + url = "https://www.itsdns.de/update.php" class DDNSProviderJoker(DDNSProtocolDynDNS2, DDNSProvider): handle = "joker.com"