From patchwork Fri Oct 6 19:28:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Kapfer X-Patchwork-Id: 1439 Return-Path: Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id 641A86095C for ; Fri, 6 Oct 2017 10:28:39 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 752042836; Fri, 6 Oct 2017 10:28:38 +0200 (CEST) Received: from localhost.localdomain (p5DC0BBEC.dip0.t-ipconnect.de [93.192.187.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 8EBB8282F; Fri, 6 Oct 2017 10:28:35 +0200 (CEST) From: Erik Kapfer To: development@lists.ipfire.org Subject: [PATCH] Deleted unneeded path to $swroot. Date: Fri, 6 Oct 2017 10:28:21 +0200 Message-Id: <1507278501-19274-1-git-send-email-erik.kapfer@ipfire.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507122180-16347-1-git-send-email-erik.kapfer@ipfire.org> References: <1507122180-16347-1-git-send-email-erik.kapfer@ipfire.org> X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" --- html/cgi-bin/chpasswd.cgi | 56 +++++++++++++++++++++++++++-------------------- 1 file changed, 32 insertions(+), 24 deletions(-) diff --git a/html/cgi-bin/chpasswd.cgi b/html/cgi-bin/chpasswd.cgi index 0a66062..a00f9cb 100644 --- a/html/cgi-bin/chpasswd.cgi +++ b/html/cgi-bin/chpasswd.cgi @@ -19,15 +19,24 @@ # # ############################################################################### +use strict; + +#usable only the following on debugging purpose +#use warnings; +#use CGI::Carp 'fatalsToBrowser'; + use CGI qw(param); use Apache::Htpasswd; use Crypt::PasswdMD5; -$swroot = "/var/ipfire"; - my %cgiparams; my %mainsettings; my %proxysettings; +my %netsettings; +my %temp; +my $swroot; +my $errormessage; +my $language; $proxysettings{'NCSA_MIN_PASS_LEN'} = 6; @@ -38,12 +47,10 @@ $language = $mainsettings{'LANGUAGE'}; ### Initialize language if ($language =~ /^(\w+)$/) {$language = $1;} - # - # Uncomment this to force a certain language: - # $language='en'; - # -require "${swroot}/langs/en.pl"; -require "${swroot}/langs/${language}.pl"; + +require '/var/ipfire/general-functions.pl'; +require "${General::swroot}/lang.pl"; +require "${General::swroot}/header.pl"; my $userdb = "$swroot/proxy/advanced/ncsa/passwd"; @@ -53,26 +60,26 @@ my $success = 0; &getcgihash(\%cgiparams); -if ($cgiparams{'SUBMIT'} eq $tr{'advproxy chgwebpwd change password'}) +if ($cgiparams{'SUBMIT'} eq $Lang::tr{'advproxy chgwebpwd change password'}) { if ($cgiparams{'USERNAME'} eq '') { - $errormessage = $tr{'advproxy errmsg no username'}; + $errormessage = $Lang::tr{'advproxy errmsg no username'}; goto ERROR; } if (($cgiparams{'OLD_PASSWORD'} eq '') || ($cgiparams{'NEW_PASSWORD_1'} eq '') || ($cgiparams{'NEW_PASSWORD_2'} eq '')) { - $errormessage = $tr{'advproxy errmsg no password'}; + $errormessage = $Lang::tr{'advproxy errmsg no password'}; goto ERROR; } if (!($cgiparams{'NEW_PASSWORD_1'} eq $cgiparams{'NEW_PASSWORD_2'})) { - $errormessage = $tr{'advproxy errmsg passwords different'}; + $errormessage = $Lang::tr{'advproxy errmsg passwords different'}; goto ERROR; } if (length($cgiparams{'NEW_PASSWORD_1'}) < $proxysettings{'NCSA_MIN_PASS_LEN'}) { - $errormessage = $tr{'advproxy errmsg password length 1'}.$proxysettings{'NCSA_MIN_PASS_LEN'}.$tr{'advproxy errmsg password length 2'}; + $errormessage = $Lang::tr{'advproxy errmsg password length 1'}.$proxysettings{'NCSA_MIN_PASS_LEN'}.$Lang::tr{'advproxy errmsg password length 2'}; goto ERROR; } @@ -81,14 +88,14 @@ if ($cgiparams{'SUBMIT'} eq $tr{'advproxy chgwebpwd change password'}) # Check if a user with this name exists my $old_password = $htpasswd->fetchPass($cgiparams{'USERNAME'}); if (!$old_password) { - $errormessage = $tr{'advproxy errmsg invalid user'}; + $errormessage = $Lang::tr{'advproxy errmsg invalid user'}; goto ERROR; } # Reset password if (!$htpasswd->htpasswd($cgiparams{'USERNAME'}, $cgiparams{'NEW_PASSWORD_1'}, $cgiparams{'OLD_PASSWORD'})) { - $errormessage = $tr{'advproxy errmsg password incorrect'}; + $errormessage = $Lang::tr{'advproxy errmsg password incorrect'}; goto ERROR; } @@ -103,7 +110,7 @@ print "Cache-control: no-cache\n"; print "Connection: close\n"; print "Content-type: text/html\n\n"; -print < @@ -124,7 +131,7 @@ print < - $tr{'advproxy chgwebpwd change web password'} + $Lang::tr{'advproxy chgwebpwd change web password'} @@ -134,7 +141,7 @@ print < - $tr{'advproxy chgwebpwd username'}: + $Lang::tr{'advproxy chgwebpwd username'}: @@ -142,7 +149,7 @@ print < - $tr{'advproxy chgwebpwd old password'}: + $Lang::tr{'advproxy chgwebpwd old password'}: @@ -150,7 +157,7 @@ print < - $tr{'advproxy chgwebpwd new password'}: + $Lang::tr{'advproxy chgwebpwd new password'}: @@ -158,7 +165,7 @@ print < - $tr{'advproxy chgwebpwd new password confirm'}: + $Lang::tr{'advproxy chgwebpwd new password confirm'}: @@ -166,7 +173,7 @@ print < - +


@@ -180,7 +187,7 @@ if ($errormessage) - $tr{'advproxy chgwebpwd ERROR'} $errormessage + $Lang::tr{'advproxy chgwebpwd ERROR'} $errormessage @@ -194,7 +201,7 @@ if ($success) - $tr{'advproxy chgwebpwd SUCCESS'} $tr{'advproxy errmsg change success'} + $Lang::tr{'advproxy chgwebpwd SUCCESS'} $Lang::tr{'advproxy errmsg change success'} @@ -287,3 +294,4 @@ sub getcgihash } # ------------------------------------------------------------------- +