From patchwork Wed Apr 6 13:46:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Leo-Andres Hofmann X-Patchwork-Id: 5453 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4KYQmX0GWsz3x1w for ; Wed, 6 Apr 2022 13:47:08 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4KYQmV2rrYz1Qb; Wed, 6 Apr 2022 13:47:06 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4KYQmV26zDz2xks; Wed, 6 Apr 2022 13:47:06 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4KYQmS507jz2xks for ; Wed, 6 Apr 2022 13:47:04 +0000 (UTC) Received: from arche.uberspace.de (arche.uberspace.de [185.26.156.147]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4KYQmR49fMz17R for ; Wed, 6 Apr 2022 13:47:03 +0000 (UTC) Received: (qmail 24508 invoked by uid 990); 6 Apr 2022 13:47:03 -0000 From: Leo-Andres Hofmann To: development@lists.ipfire.org Subject: [PATCH] getrrdimage.cgi: Add default values to parameters Date: Wed, 6 Apr 2022 15:46:52 +0200 Message-Id: <20220406134652.1506-1-hofmann@leo-andres.de> X-Mailer: git-send-email 2.27.0.windows.1 MIME-Version: 1.0 X-Rspamd-Bar: - X-Rspamd-Report: R_MISSING_CHARSET(0.5) MIME_GOOD(-0.1) MID_CONTAINS_FROM(1) BAYES_HAM(-2.999999) X-Rspamd-Score: -1.599999 Received: from unknown (HELO unkown) (::1) by arche.uberspace.de (Haraka/2.8.28) with ESMTPSA; Wed, 06 Apr 2022 15:47:03 +0200 ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1649252823; a=rsa-sha256; cv=none; b=d+EEnZOiXeQGI3LSd3U1NzljkbHQnsFXVzSt6ySQjBmrJn1bBnbwp/oRLQhvVOVZLIoEQy rJfszbwfe6DrsRPIri2w/ER5R+mV53qyPzhJILCBqAA9rMjEb+WsTjK9xsw7xJVIzPOu91 SHnMrtyAxA8TA/6RkI++JiDJ/zDKgqQ2VhoulNSUNk95SE5rgY2TXmqCHFkZ+r+TN8J5Qq T0MbGTj0mnkJtkoJK2Izkb2KMyvXfunv1R3Xi53wkNgd2mfcHsDU8QA4+Qq4XsuyEVvgkN zgt7KZ/nAsnkvHt79hMaho5cUMzv/3cIPWXrYzWqhSGLEsVKHN6Oo4qvTL3slA== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=none; dmarc=pass (policy=quarantine) header.from=leo-andres.de; spf=pass (mail01.ipfire.org: domain of hofmann@leo-andres.de designates 185.26.156.147 as permitted sender) smtp.mailfrom=hofmann@leo-andres.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1649252823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JXpyPsPVBE23ojU11yrR7jJk+MnbLfQTCmMhd3ZHUcg=; b=rXSkk12wlIDJUu8z+uIp5NUaQ1B8fo7yxkwX5dmOEd/lahS4E2vCRjdImwmAiOXJ55zsDR chCTJKu7UpNS0T5/1z2N/eAxaS6hzkWFEqWZEmhHPwwFEKBloOBxQ4oJHetNW9sDkHz96V IDOL+U2Tvm5fttm3K1ka0AnFfsTl5rPi2ZYo6KlERp4YyMljPFLX8/WtTe8Vjbfw+svNeu 4HWdfQzbP03b/WmNwomy0xm6rbC+zcF9s7Dkr/qO07I5T6ELeSofQq2rc3e4B96kt9Mr1E YOXn5gbMBQov8mce8hnwA/Mu13o/BOE79xNo97+qspeDso7Uvvr423rsfhEJJQ== X-Rspamd-Queue-Id: 4KYQmR49fMz17R X-Rspamd-Server: mail01.haj.ipfire.org X-Spamd-Result: default: False [-2.87 / 11.00]; BAYES_HAM(-2.21)[96.25%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM(-1.00)[-0.998]; SPF_REPUTATION_HAM(-0.85)[-0.85283310789696]; DMARC_POLICY_ALLOW(-0.50)[leo-andres.de,quarantine]; R_MISSING_CHARSET(0.50)[]; MX_INVALID(0.50)[]; R_SPF_ALLOW(-0.20)[+mx:c]; MIME_GOOD(-0.10)[text/plain]; IP_REPUTATION_HAM(-0.01)[asn: 205766(0.00), country: DE(-0.01), ip: 185.26.156.147(0.00)]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:205766, ipnet:185.26.156.0/24, country:DE]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[185.26.156.147:from]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; ARC_NA(0.00)[] Authentication-Results: mail01.ipfire.org; dkim=none; dmarc=pass (policy=quarantine) header.from=leo-andres.de; spf=pass (mail01.ipfire.org: domain of hofmann@leo-andres.de designates 185.26.156.147 as permitted sender) smtp.mailfrom=hofmann@leo-andres.de X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" Prevents "use of uninitialized value" warnings when the CGI is called with broken undefined GET parameters. Signed-off-by: Leo-Andres Hofmann Reviewed-by: Peter Müller --- html/cgi-bin/getrrdimage.cgi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi index 26e026bba..6ec91cc92 100644 --- a/html/cgi-bin/getrrdimage.cgi +++ b/html/cgi-bin/getrrdimage.cgi @@ -44,9 +44,9 @@ my @supported_origins = ("entropy.cgi", "hardwaregraphs.cgi", "media.cgi", my $uri = URI->new($ENV{'REQUEST_URI'}); my %query = $uri->query_form; -my $origin = lc $query{'origin'}; # lower case -my $graph = $query{'graph'}; -my $range = lc $query{'range'}; # lower case +my $origin = lc ($query{'origin'} // ''); # lower case +my $graph = $query{'graph'} // ''; +my $range = lc ($query{'range'} // ''); # lower case # Check parameters unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) {