From patchwork Sat Feb 10 23:14:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonatan Schlag X-Patchwork-Id: 1649 Return-Path: Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id C3E67602CB for ; Sat, 10 Feb 2018 13:15:00 +0100 (CET) X-Virus-Scanned: ClamAV at mail01.ipfire.org X-Spam-Flag: NO X-Spam-Score: -1.1 X-Spam-Level: X-Spam-Status: No, score=-1.1 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mail01.i.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 7729510FEF4A; Sat, 10 Feb 2018 12:15:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 mail01.ipfire.org 7729510FEF4A Authentication-Results: mail01.ipfire.org; dmarc=none (p=none dis=none) header.from=ipfire.org Authentication-Results: mail01.ipfire.org; spf=pass smtp.mailfrom=network-bounces@lists.ipfire.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ipfire.org; s=201801; t=1518264900; x=1520856900; bh=3Mxks5zF0sSn5oGXio90X+JK/ACzn3DosuD0Lfwz71Q=; h=From:To:Subject:Date:Message-Id:Sender:From:To:Cc:Date: Content-Type:Message-ID:In-Reply-To:Subject:Reply-To:Sender; b=y8mIwU75tEJKY98F13AhUKELfwRTbFv7KTsBozucnMPdOPzCvOlMOaOS5GtdT2qOQ c0FikBavSPNhhTTK+n01gOSWaT6ccRRGdRmj3kmk4Y0l0gpo9N1WO4iTcoymdf6eUG Kzfo6RPevISWTMp9/c7OYN5+HSM5ajfARW2SUQLgPOimdi36s2QrOdQr5NHXE+FuKq EbtKPowLveJG4Cm2SwsEThsywNhSvv1iNlaDtJkdIqp8Vg/qgV0K7lQdXQ2qd8FpZI qjxjVm0rBTn9hWm5MgEOg9KjQgm85I7J/jU0zKFHqVyAqZT2etctVb78hlgbWpu0iB 3a/itnwb5dbUQ== X-Virus-Scanned: ClamAV at mail01.ipfire.org Received: from localhost.localdomain (fw-1.cvjm.hk-net.de [95.129.212.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jschlag) by mail01.ipfire.org (Postfix) with ESMTPSA id A9F48108C3B9; Sat, 10 Feb 2018 12:14:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 mail01.ipfire.org A9F48108C3B9 Authentication-Results: mail01.ipfire.org; dmarc=none (p=none dis=none) header.from=ipfire.org Authentication-Results: mail01.ipfire.org; spf=fail smtp.mailfrom=jonatan.schlag@ipfire.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ipfire.org; s=201801; t=1518264898; x=1520856898; bh=3Mxks5zF0sSn5oGXio90X+JK/ACzn3DosuD0Lfwz71Q=; h=From:To:Cc:Subject:Date:Message-Id:From:To:Cc:Date:Content-Type: Message-ID:In-Reply-To:Subject:Reply-To:Sender; b=D+vDSne4HJF/HYBCDbSsJCX5LTWi8GDvOUT/A69MgiP6D4EyLFUlLckkN+RndE+0W fnkhVv4GKjppOP5FPuEvJJY29V26u84BrhFPqbyqUdMkTUVxMGFgCx9+GEPQzi//Bk ZpsjmFstprsBJUa4ASMWLZIO90qn+NULnRWrZzcAWW6oDzxcP7nQlnDtsrUm1/ILx2 /hHTj0nGt9RmLlVngVtNIZwhW+wLIv9RQkADlFbMtVkj3tmUaPqMpclpEJNS0i/y8h xm/gnU/qq1P2DHltHCCZ7nsI3q/+MAi0cY1EbSqBXDpcCrOeP1NU1T7VJjsdwsCuOC Tfcfx8lCQcr9g== From: Jonatan Schlag To: network@lists.ipfire.org Subject: [PATCH] Print better info mesages when we change a service Date: Sat, 10 Feb 2018 12:14:54 +0000 Message-Id: <1518264894-8343-1-git-send-email-jonatan.schlag@ipfire.org> X-Mailer: git-send-email 2.6.3 X-BeenThere: network@lists.ipfire.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List for the network package List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: network-bounces@lists.ipfire.org Sender: "network" Signed-off-by: Jonatan Schlag --- src/functions/functions.service | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/functions/functions.service b/src/functions/functions.service index 7a12ffd..07bd2cd 100644 --- a/src/functions/functions.service +++ b/src/functions/functions.service @@ -45,6 +45,11 @@ service_stop() { assert isset name systemctl stop "${name}" + local ret=$? + + log INFO "Stopped service '${name}', code=${ret}" + + return ${ret} } service_restart() { @@ -52,6 +57,11 @@ service_restart() { assert isset name systemctl restart "${name}" + local ret=$? + + log INFO "Restarted service '${name}', code=${ret}" + + return ${ret} } service_reload() { @@ -60,7 +70,12 @@ service_reload() { if service_status "${name}"; then systemctl reload "${name}" - return $? + local ret=$? + + log INFO "Reloaded service '${name}', code=${ret}" + + return ${ret} + else log WARNING "Cannot reload service '${name}' which is currently not running." fi