From patchwork Sun Jan 19 15:03:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tremer X-Patchwork-Id: 2705 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 480yjw2H5wz3xY5 for ; Sun, 19 Jan 2020 15:03:48 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 480yjt63tVz2Nq; Sun, 19 Jan 2020 15:03:46 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 480yjt3Q5Fz2y4R; Sun, 19 Jan 2020 15:03:46 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 480yjr5p6hz2xGM for ; Sun, 19 Jan 2020 15:03:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPSA id 480yjr38bvz2PD; Sun, 19 Jan 2020 15:03:44 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=201909ed25519; t=1579446224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mtQHQvczy45tJ/4Eh29x/i1J1rHhvfT8TSHayD+uowY=; b=AMxkjZA+UQE9c9H7WmRvEn7WzV8ojUTZCmrrXBMFS6ErayNSXJ/MRPfu/Ogq+BhSegHh3L 80RDti40kgPKRqBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=201909rsa; t=1579446224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mtQHQvczy45tJ/4Eh29x/i1J1rHhvfT8TSHayD+uowY=; b=iWyNmrk/OJl6MK/9hTAm2G0/bl9uOvj+ZPB1JVVrB6FjHWHtyUK9QGGWNCla2g46KuBkF4 6JOKmLBP0GNfIYe0X3e25rsNaq8hqCvZVRxGamiF8QUDkjrMvAhIBRY8ApCnPFxwVMj7UE 47yaQPpw6ezG6Rh1kmGrH03w/GspSFqSOEOln79dtkfoWkwyHDc8wHrBqsIuUbWZog6Nld 3sStaUUbHUZAQJIbbnLCJrd3RGLmIh5e8bqan95S2yfzTSbGjNGJhLMB92ZC+I7Sx65a9T PoQ/tK0GpCzFAa0svT72v2JOZhfdgTYqaSiI5qDIBx40+H1/ya7pCvZuttQ+jg== From: Michael Tremer To: development@lists.ipfire.org Subject: [PATCH] setup: Do not check DNS settings any more Date: Sun, 19 Jan 2020 15:03:34 +0000 Message-Id: <20200119150334.23123-1-michael.tremer@ipfire.org> MIME-Version: 1.0 X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Tremer Errors-To: development-bounces@lists.ipfire.org Sender: "Development" It has been removed that DNS servers could be configured in setup, but I forgot to remove a check which leads to new installations not being able to complete the setup wizard. Signed-off-by: Michael Tremer --- src/setup/networking.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/setup/networking.c b/src/setup/networking.c index 51dc7acb0..97d58f724 100644 --- a/src/setup/networking.c +++ b/src/setup/networking.c @@ -219,13 +219,6 @@ int oktoleave(void) strcpy(temp, ""); findkey(kv, "RED_TYPE", temp); if ((configtype == 0) || (strcmp(temp, "STATIC") == 0)) { - strcpy(temp, ""); findkey(kv, "DNS1", temp); - if (!(strlen(temp))) - { - errorbox(_("Missing DNS.")); - freekeyvalues(kv); - return 0; - } strcpy(temp, ""); findkey(kv, "DEFAULT_GATEWAY", temp); if (!(strlen(temp))) {