[3/7] Makefile: Remove any excess substitution rules

Message ID 20180604153832.331239-3-michael.tremer@ipfire.org
State Accepted
Commit 3431f71203342d3641b94b06672b434242be61d6
Headers
Series [1/7] nitsi: Create "nitsi" Makefile target |

Commit Message

Michael Tremer June 5, 2018, 1:38 a.m. UTC
  Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 Makefile.am | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
  

Comments

Jonatan Schlag June 14, 2018, 9:44 p.m. UTC | #1
Reviewed-by: Jonatan Schlag <jonatan.schlag@ipfire.org>

Am Mo, 4. Jun, 2018 um 5:38 schrieb Michael Tremer 
<michael.tremer@ipfire.org>:
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>  Makefile.am | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 88c56bcf68eb..73c79f501f99 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -502,16 +502,7 @@ SED_PROCESS = \
>  	$(SED) $(subst '|,-e 's|@,$(subst =,\@|,$(subst 
> |',|g',$(substitutions)))) \
>  		< $< > $@
> 
> -src/functions/functions: src/functions/functions.in Makefile
> -	$(SED_PROCESS)
> -
> -src/ppp/ip-updown: src/ppp/ip-updown.in Makefile
> -	$(SED_PROCESS)
> -
> -src/systemd/%: src/systemd/%.in Makefile
> -	$(SED_PROCESS)
> -
> -src/%.pc: src/%.pc.in Makefile
> +%: %.in Makefile
>  	$(SED_PROCESS)
> 
>  INSTALL_DIRS += \
> --
> 2.17.0
>
Reviewed-by: Jonatan Schlag &lt;jonatan.schlag@ipfire.org&gt;<br><br>Am Mo, 4. Jun, 2018 um 5:38  schrieb Michael Tremer &lt;michael.tremer@ipfire.org&gt;:<br>
<blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">Signed-off-by: Michael Tremer &lt;<a href="mailto:michael.tremer@ipfire.org">michael.tremer@ipfire.org</a>&gt;
---
 Makefile.am | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 88c56bcf68eb..73c79f501f99 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -502,16 +502,7 @@ SED_PROCESS = \
 	$(SED) $(subst '|,-e 's|@,$(subst =,\@|,$(subst |',|g',$(substitutions)))) \
 		&lt; $&lt; &gt; $@
 
-src/functions/functions: src/functions/functions.in Makefile
-	$(SED_PROCESS)
-
-src/ppp/ip-updown: src/ppp/ip-updown.in Makefile
-	$(SED_PROCESS)
-
-src/systemd/%: src/systemd/%.in Makefile
-	$(SED_PROCESS)
-
-src/%.pc: src/%.pc.in Makefile
+%: %.in Makefile
 	$(SED_PROCESS)
 
 INSTALL_DIRS += \
<div>-- 
</div>2.17.0

</div></blockquote>
  

Patch

diff --git a/Makefile.am b/Makefile.am
index 88c56bcf68eb..73c79f501f99 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -502,16 +502,7 @@  SED_PROCESS = \
 	$(SED) $(subst '|,-e 's|@,$(subst =,\@|,$(subst |',|g',$(substitutions)))) \
 		< $< > $@
 
-src/functions/functions: src/functions/functions.in Makefile
-	$(SED_PROCESS)
-
-src/ppp/ip-updown: src/ppp/ip-updown.in Makefile
-	$(SED_PROCESS)
-
-src/systemd/%: src/systemd/%.in Makefile
-	$(SED_PROCESS)
-
-src/%.pc: src/%.pc.in Makefile
+%: %.in Makefile
 	$(SED_PROCESS)
 
 INSTALL_DIRS += \