[1/5] zone: fix zone_config()
Message ID | 1500305066-12510-1-git-send-email-jonatan.schlag@ipfire.org |
---|---|
State | Superseded |
Headers |
Return-Path: <network-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id B38FC61C5D for <patchwork@ipfire.org>; Mon, 17 Jul 2017 17:24:37 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 666FE27D6; Mon, 17 Jul 2017 17:24:37 +0200 (CEST) Received: from ipfire.localdomain (dslb-088-073-208-102.088.073.pools.vodafone-ip.de [88.73.208.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id DAC792596; Mon, 17 Jul 2017 17:24:34 +0200 (CEST) From: Jonatan Schlag <jonatan.schlag@ipfire.org> To: network@lists.ipfire.org Subject: [PATCH 1/5] zone: fix zone_config() Date: Mon, 17 Jul 2017 17:24:22 +0200 Message-Id: <1500305066-12510-1-git-send-email-jonatan.schlag@ipfire.org> X-Mailer: git-send-email 2.6.3 X-BeenThere: network@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List for the network package <network.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/network>, <mailto:network-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/network/> List-Post: <mailto:network@lists.ipfire.org> List-Help: <mailto:network-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/network>, <mailto:network-request@lists.ipfire.org?subject=subscribe> Errors-To: network-bounces@lists.ipfire.org Sender: "network" <network-bounces@lists.ipfire.org> |
Message
Jonatan Schlag
July 18, 2017, 1:24 a.m. UTC
Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
---
src/functions/functions.zone | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi, I merged this patchset, but there is a few comments left. Maybe you can have a look at them and if you think it suits, please send some patches to get rid of any problems. -Michael On Mon, 2017-07-17 at 17:24 +0200, Jonatan Schlag wrote: > Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org> > --- > src/functions/functions.zone | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/functions/functions.zone > b/src/functions/functions.zone > index acf68f5..11a8dc2 100644 > --- a/src/functions/functions.zone > +++ b/src/functions/functions.zone > @@ -565,9 +565,9 @@ zone_config() { > # TODO This could be also a valid hid > local id=${cmd} > > - if zone_config_id_is valid ${zone} ${id} && > [[ ${1} == "edit" ]]; then > + if zone_config_id_is_valid ${zone} ${id} && > [[ ${1} == "edit" ]]; then > shift 1 > - zone_config_edit "${zone}" > "${id}""$@" > + zone_config_edit "${zone}" "${id}" > "$@" > else > error "Unrecognized argument: > ${cmd}" > cli_usage root-zone-config- > subcommands