[4/6] cli: print the color of a zone/port
Message ID | 1497003452-10190-4-git-send-email-jonatan.schlag@ipfire.org |
---|---|
State | Superseded |
Headers |
Return-Path: <network-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (unknown [172.28.1.200]) by web02.ipfire.org (Postfix) with ESMTP id 5620061C91 for <patchwork@ipfire.org>; Fri, 9 Jun 2017 12:17:58 +0200 (CEST) Received: from mail01.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id F1C9B280B; Fri, 9 Jun 2017 12:17:57 +0200 (CEST) Received: from ipfire.localdomain (dslb-088-073-203-240.088.073.pools.vodafone-ip.de [88.73.203.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 70141280B; Fri, 9 Jun 2017 12:17:49 +0200 (CEST) From: Jonatan Schlag <jonatan.schlag@ipfire.org> To: development@lists.ipfire.org, network@lists.ipfire.org Subject: [PATCH 4/6] cli: print the color of a zone/port Date: Fri, 9 Jun 2017 12:17:30 +0200 Message-Id: <1497003452-10190-4-git-send-email-jonatan.schlag@ipfire.org> X-Mailer: git-send-email 2.6.3 In-Reply-To: <1497003452-10190-1-git-send-email-jonatan.schlag@ipfire.org> References: <1497003452-10190-1-git-send-email-jonatan.schlag@ipfire.org> X-BeenThere: network@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List for the network package <network.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/network>, <mailto:network-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/network/> List-Post: <mailto:network@lists.ipfire.org> List-Help: <mailto:network-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/network>, <mailto:network-request@lists.ipfire.org?subject=subscribe> Errors-To: network-bounces@lists.ipfire.org Sender: "network" <network-bounces@lists.ipfire.org> |
Message
Jonatan Schlag
June 9, 2017, 8:17 p.m. UTC
Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
---
src/functions/functions.cli | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
Comments
Hi, On Fri, 2017-06-09 at 12:17 +0200, Jonatan Schlag wrote: > Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org> > --- > src/functions/functions.cli | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/src/functions/functions.cli > b/src/functions/functions.cli > index a4690b2..cd4fd06 100644 > --- a/src/functions/functions.cli > +++ b/src/functions/functions.cli > @@ -112,6 +112,12 @@ cli_device_headline() { > ;; > esac > cli_print_fmt1 1 "Status" "${status}" > + > + # Print the color of the device. > + if [[ "${type}" == "zone" ]] || [[ "${type}" == "port" ]]; > then > + cli_print_fmt1 1 "Color " "$(cli_color ${type} > ${device})" > + fi > + To compare two string values in shell you actually only use = instead of ==. I would probably have written this as: case "${type}" in port|zone) ... ;; esac I always considered this performing faster. > if enabled long; then > cli_print_fmt1 1 "Address" "$(device_get_address > ${device})" > fi > @@ -423,3 +429,15 @@ cli_show_man() { > > man ${manpage} > } > + > + > +cli_color() { Whitespace again :) > + assert [ $# -eq 2 ] > + > + local type=${1} > + local name=${2} > + > + local color=$(color_read ${type} ${name}) > + > + echo "$(shell_set_color - ${color}) ${CLR_RESET}" > +}