From patchwork Wed Jun 24 13:39:14 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valters Jansons X-Patchwork-Id: 9963 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1 raw public key) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "YR2" (not verified)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4gljj31R99z3wpB for ; Wed, 24 Jun 2026 13:39:35 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client CN "mail02.haj.ipfire.org", Issuer "YE1" (not verified)) by mail01.ipfire.org (Postfix) with ESMTPS id 4gljj21L63z5gV for ; Wed, 24 Jun 2026 13:39:34 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4gljj11GrMz3346 for ; Wed, 24 Jun 2026 13:39:33 +0000 (UTC) X-Original-To: location@lists.ipfire.org Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client CN "mail01.haj.ipfire.org", Issuer "YR2" (not verified)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4gljj03Rdcz2xHP for ; Wed, 24 Jun 2026 13:39:32 +0000 (UTC) Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4gljhy5VFKz5Xq for ; Wed, 24 Jun 2026 13:39:30 +0000 (UTC) Authentication-Results: mail01.ipfire.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=Z1R+vH30; spf=pass (mail01.ipfire.org: domain of valter.jansons@gmail.com designates 2607:f8b0:4864:20::102a as permitted sender) smtp.mailfrom=valter.jansons@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; d=lists.ipfire.org; s=202003rsa; cv=none; t=1782308370; b=erct5tYTwvbbItkrcrdEfoBrkBK091CHxpnPAaiNW82i3LhmYlVB9CD4thmP//h0eIS34H LSoT1H7T41iv1jkTFIWQvHygVEH8cnI6gG+VKZFGQW3aVzrkzVF6Tlj9eNmKiv6RV0OYiS snX/iiKbqG5FrZbOxw0bYTpbG6ZKQqZmTjAf98vD2qrxxpSzBTa+uqAY/FOgO1Q8OLtnjr OOPu6esWpa8npNLMiOxix6iUFhWm95czkFoGj85lT0epRoLcHAJJeva1ik22cyhBggN4OA qSgosO7b+iJ7nV4KXN1e/ONQop4PpGYOzcz8WSClw7Mj/fgx0ltQ17AQzVWUEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1782308370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=D0ytPghm6M23ICKBE4w1jVZZZD+Kp50RcPAfxRm9eKM=; b=w04xF1B31wwLRfJCym6pvsIyWqGdLbif6iJYG/8diCN93sPmXYjA4xMv/7UlvZojcvd4et HeHETrOG0MSbWQqEDAIOBGPARmpoN5HT0B5MJKsk2pEXtw0cORvjVKN9EiXQs7nRD056gX FybndFBWVPNWNqsJfSBpjZQtpCMG1axsRdOe7o9NjDYqq++oJocytOkOCFZU+vaFuZr6fQ aTNuagaLAGOsnuQmL1sI/avrZeuLbVt8G5bFh/FSaGunxmxZ8OahKh221Z/C5nPkIcirqV bRMZXwIwmO1pbqi4Idg+zo4+3+NJgJ36hlx4sovjrJKB2MYAZEvH819nOFO8SQ== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=Z1R+vH30; spf=pass (mail01.ipfire.org: domain of valter.jansons@gmail.com designates 2607:f8b0:4864:20::102a as permitted sender) smtp.mailfrom=valter.jansons@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-37c6cd1ac98so938283a91.0 for ; Wed, 24 Jun 2026 06:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782308369; x=1782913169; darn=lists.ipfire.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=D0ytPghm6M23ICKBE4w1jVZZZD+Kp50RcPAfxRm9eKM=; b=Z1R+vH306GTTUCDehuysIJilKQlNvjWQ/9FpAZ4mPVbDSLFxk0utGgdKJcWOyCMipR qw4559RiEfB1iGOxUEg05pxMQSvlDbrKG6HbnuN4Gcv1967YH8eOxfSLeRTiT7gkAIQV 8mt7xOg++xmaI9juxDSSYXCG0yAVfHDtoSvVXgGyHVTm0AdaiLcOl/wRYjdtV65AtBHR HOgkgLaP50ihEJR5Va5jVj4IoIUk7XcH9Y2U7GrsGc86xY2sz2/Ssp28xoTqUoWxe0si x7lnfvwycDUyyarWfMlJpF7/ydmqdz20IVmQoRHfCd3CRyNlI7dF5uXgcrhMjIl+8E14 rmpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782308369; x=1782913169; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D0ytPghm6M23ICKBE4w1jVZZZD+Kp50RcPAfxRm9eKM=; b=tQWSLp7wPOqnH97AQXncmK2EmpOhZbvBSt2DxtKk5F8qLsnzdrIWZkFxeOlsFajZC/ 852dT4NPzfRheADf4TWLcvlCcqGDtxCtIC0zFVtL++LTfGmz/KxoIim9ldRYHBym52Xq HxMhKGBrCBZ1PvMsRAj7uAMQ7C0TaOv328gYbzfCPqTd6RahPPdBJW+0Uj9VfIwGf3fU hE+3gIqzPfMtAGn5qJyEQyJ0gfcK7nzpQFZL94nrlWwI2/kh9FIt8QdPgt7B2cTiZHV8 2zhZjn8uAh+M7EKiswTravBStuyUhIBiM/JZD4a+GGHoVbvCn5KeivBiAJDhOBLfwk5d af2w== X-Gm-Message-State: AOJu0YzxfClSaoG3rrfFclmWedSsJcA5O7MqAH4IHVWSHDIUd9tcYmfM vKBxIKe58u+6ZKkiIUSpwgGjXPv9CovRPqfREUDiGiKwljcBbzBt9pXNMbzvjw== X-Gm-Gg: AfdE7ckyPLLkQnT6q3U8SPPuzEAJJjMWUz5Krll70RaVjvZG+Zhh32R4fq4Nk38b0i4 2mWc0TZJhSOgZlPLt7A7CGnqlp0Q3lUxUAWduTqII2jeXAjFsU9xtWE0BYIXSadzhTgU/IsxHp4 Lf+JtaeoPFJxybtqOJNYi5iSeKhFqxQvlXJsJ7a16ZKOaLcx2dAYOapVI8t47S6R4qtzoN+X0YW isUfFFRbWV2+TwCHu9/jQOpWEwibvogTXCGgIk5eMbFRG0vaHlyl5roXUze/8YQqg6I1xgLymG9 JzQkNSqsW1ftYRGLmBBq7mSxURo5xhqCyFAL2Ragfo8+CeeD1xJViHrBKDySVC7yU/eY/5tm57I VKNBsBUzzqNsJ4iit55WS7wPkpfeQajR61O7fJMiFpHZ6GvkKmIVFwsna/HuN5b2Afa4THydajN Hch4oPF4YQkKG9j6U5HuNVCgu5rDPzQQ== X-Received: by 2002:a17:90b:1c88:b0:372:94b9:76d8 with SMTP id 98e67ed59e1d1-37dd0d3d0b9mr7879859a91.6.1782308368508; Wed, 24 Jun 2026 06:39:28 -0700 (PDT) Received: from VT14-G5.localdomain ([221.146.12.107]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37de3ca3c2csm2529369a91.2.2026.06.24.06.39.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 06:39:27 -0700 (PDT) From: Valters Jansons To: location@lists.ipfire.org Subject: [PATCH 1/2] Makefile: Install Lua in `exec` stage, not `data` Date: Wed, 24 Jun 2026 22:39:14 +0900 Message-ID: <20260624133915.434197-1-valter.jansons@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 X-Spamd-Result: default: False [-6.75 / 11.00]; BAYES_HAM(-3.00)[100.00%]; R_DKIM_ALLOW(-1.69)[gmail.com:s=20251104]; DKIM_REPUTATION(-0.96)[-0.96313688780515]; SPF_REPUTATION_HAM(-0.69)[-0.69164785741642]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_MISSING_CHARSET(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.10)[gmail-smtp-in.l.google.com]; FROM_EQ_ENVFROM(0.00)[]; IP_REPUTATION_HAM(0.00)[asn: 15169(-0.32), country: US(-0.01), ip: 2607:f8b0:4864:20::(-0.83)]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_NONE(0.00)[]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; MID_RHS_MATCH_FROM(0.00)[]; ALIAS_RESOLVED(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[location@lists.ipfire.org]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::102a:from]; FROM_HAS_DN(0.00)[] X-Rspamd-Server: mail01.haj.ipfire.org X-Rspamd-Queue-Id: 4gljhy5VFKz5Xq X-Rspamd-Action: no action Automake installation has two stages: * `exec` for platform-specific files, * `data` for platform-agnostic files. Automake separates the install stages based on the directory (target) variable name. Built-in targets have known stages. Any custom-defined ones check simply whether the target name contains `exec` substring. Currently, the Lua module is installed in the `data` stage, because `lua` is not considered an `exec` stage name. However, the Lua module contains C code (it is architecture-specific). Similar to how Python is installed via `pyexec`, Lua should be installed via `luaexec`. That way Automake splits it into `exec` stage correctly. Internally, the installation target directory is `LUA_INSTALL_CMOD` which also signals that this is a platform/architecture-specific installation. This logic remains unchanged, and the Lua `.so` gets installed to the same target as a result. This change is also important to allow libtool cleanup to be done in `install-exec-hook` consistently. Without this change, part of la-files cleanup would need to be moved to `install-data-hook`. Ref: https://www.gnu.org/software/automake/manual/html_node/The-Two-Parts-of-Install.html Signed-off-by: Valters Jansons --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index c5b8df3..a64a20a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -230,10 +230,10 @@ src_python__location_la_LIBADD = \ # ------------------------------------------------------------------------------ if ENABLE_LUA -lua_LTLIBRARIES = \ +luaexec_LTLIBRARIES = \ src/lua/location.la -luadir = $(LUA_INSTALL_CMOD) +luaexecdir = $(LUA_INSTALL_CMOD) src_lua_location_la_SOURCES = \ src/lua/as.c \