diff mbox series

sendEmail

Message ID q426t7$k70$1@tuscan3.grantura.co.uk
State Dropped
Headers
Series sendEmail |

Commit Message

Rob Brewer Feb. 14, 2019, 9:49 a.m. UTC 
  Michael Tremer wrote:

> Would you re-submit this patch with “git send-email” so that Patchwork can
> pick it up and it can be merged?
> 
I'm still getting my head around git. Hopefully this is what is needed.

HTH

Rob

Comments

Michael Tremer Feb. 14, 2019, 10:06 p.m. UTC | #1 
Hello,

Yes, this is almost it.

Two minor things (I fixed both of them for you):

* If you change an add-on, please increase PAK_VER. That way, pakfire knows that this package has changed.

* You used spaces instead of tabs for the indentation of the added line. GNU Make only supports tabs.

I merged the patch though.

Best,
-Michael

> On 13 Feb 2019, at 22:49, Rob Brewer <ipfire-devel@grantura.co.uk> wrote:
> 
> Michael Tremer wrote:
> 
>> Would you re-submit this patch with “git send-email” so that Patchwork can
>> pick it up and it can be merged?
>> 
> I'm still getting my head around git. Hopefully this is what is needed.
> 
> HTH
> 
> Rob
> 
> 
> diff --git a/lfs/sendEmail b/lfs/sendEmail
> index 28646ef93..cc9f67aaa 100644
> --- a/lfs/sendEmail
> +++ b/lfs/sendEmail
> @@ -63,6 +63,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>        @$(PREBUILD)
>        @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
>        cd $(DIR_APP) && cp -pvf sendEmail /usr/local/bin
> +       chown root.root /usr/local/bin/sendEmail
>        chmod 755 /usr/local/bin/sendEmail
>        @rm -rf $(DIR_APP)
>        @$(POSTBUILD)
>
diff mbox series

Patch

diff --git a/lfs/sendEmail b/lfs/sendEmail
index 28646ef93..cc9f67aaa 100644
--- a/lfs/sendEmail
+++ b/lfs/sendEmail
@@ -63,6 +63,7 @@  $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
        @$(PREBUILD)
        @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
        cd $(DIR_APP) && cp -pvf sendEmail /usr/local/bin
+       chown root.root /usr/local/bin/sendEmail
        chmod 755 /usr/local/bin/sendEmail
        @rm -rf $(DIR_APP)
        @$(POSTBUILD)