system.cgi: correctly translate CPU frequency

Message ID f200ab55-1680-bc38-fc15-74c9b894e22d@ipfire.org
State Accepted
Headers
Series system.cgi: correctly translate CPU frequency |

Commit Message

Peter Müller April 11, 2020, 9:02 a.m. UTC
  The CPU frequency diagram used the same "translation" as the CPU load,
which was confusing. This patch introduces a dedicated translation for
"CPU frequency", which makes things a little bit better but still does
not solve a Deppenleerzeichen ("CPU-Frequenz Diagramm") in the German
translation.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 html/cgi-bin/system.cgi | 2 +-
 langs/de/cgi-bin/de.pl  | 1 +
 langs/en/cgi-bin/en.pl  | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)
  

Comments

Michael Tremer April 11, 2020, 9:32 a.m. UTC | #1
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

> On 11 Apr 2020, at 10:02, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> The CPU frequency diagram used the same "translation" as the CPU load,
> which was confusing. This patch introduces a dedicated translation for
> "CPU frequency", which makes things a little bit better but still does
> not solve a Deppenleerzeichen ("CPU-Frequenz Diagramm") in the German
> translation.
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> html/cgi-bin/system.cgi | 2 +-
> langs/de/cgi-bin/de.pl  | 1 +
> langs/en/cgi-bin/en.pl  | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/system.cgi b/html/cgi-bin/system.cgi
> index 487ba996c..d7db9406a 100644
> --- a/html/cgi-bin/system.cgi
> +++ b/html/cgi-bin/system.cgi
> @@ -61,7 +61,7 @@ if ( $querry[0] =~ "cpufreq"){
> 	&Header::closebox();
> 
> 	if ( -e "$mainsettings{'RRDLOG'}/collectd/localhost/cpufreq/cpufreq-0.rrd"){
> -		&Header::openbox('100%', 'center', "CPU $Lang::tr{'graph'}");
> +		&Header::openbox('100%', 'center', "$Lang::tr{'cpu frequency'} $Lang::tr{'graph'}");
> 		&Graphs::makegraphbox("system.cgi","cpufreq","day");
> 		&Header::closebox();
> 	}
> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
> index c3702cc09..9f1768e78 100644
> --- a/langs/de/cgi-bin/de.pl
> +++ b/langs/de/cgi-bin/de.pl
> @@ -662,6 +662,7 @@
> 'country' => 'Land',
> 'country codes and flags' => 'Länder und Länderkennungen',
> 'countrycode' => 'Kennung',
> +'cpu frequency' => 'CPU-Frequenz',
> 'cpu frequency per' => 'CPU-Frequenz pro',
> 'cpu idle usage' => 'Leerlauf CPU-Nutzung',
> 'cpu interrupt usage' => 'Interrupt CPU-Nutzung',
> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
> index 3f3e46641..3d8e3ceca 100644
> --- a/langs/en/cgi-bin/en.pl
> +++ b/langs/en/cgi-bin/en.pl
> @@ -678,6 +678,7 @@
> 'country' => 'Country',
> 'country codes and flags' => 'Country Codes and Flags:',
> 'countrycode' => 'Code',
> +'cpu frequency' => 'CPU frequency',
> 'cpu frequency per' => 'CPU frequency per',
> 'cpu idle usage' => 'Idle CPU Usage',
> 'cpu interrupt usage' => 'Interrupt CPU Usage',
> -- 
> 2.16.4
  

Patch

diff --git a/html/cgi-bin/system.cgi b/html/cgi-bin/system.cgi
index 487ba996c..d7db9406a 100644
--- a/html/cgi-bin/system.cgi
+++ b/html/cgi-bin/system.cgi
@@ -61,7 +61,7 @@  if ( $querry[0] =~ "cpufreq"){
 	&Header::closebox();
 
 	if ( -e "$mainsettings{'RRDLOG'}/collectd/localhost/cpufreq/cpufreq-0.rrd"){
-		&Header::openbox('100%', 'center', "CPU $Lang::tr{'graph'}");
+		&Header::openbox('100%', 'center', "$Lang::tr{'cpu frequency'} $Lang::tr{'graph'}");
 		&Graphs::makegraphbox("system.cgi","cpufreq","day");
 		&Header::closebox();
 	}
diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
index c3702cc09..9f1768e78 100644
--- a/langs/de/cgi-bin/de.pl
+++ b/langs/de/cgi-bin/de.pl
@@ -662,6 +662,7 @@ 
 'country' => 'Land',
 'country codes and flags' => 'Länder und Länderkennungen',
 'countrycode' => 'Kennung',
+'cpu frequency' => 'CPU-Frequenz',
 'cpu frequency per' => 'CPU-Frequenz pro',
 'cpu idle usage' => 'Leerlauf CPU-Nutzung',
 'cpu interrupt usage' => 'Interrupt CPU-Nutzung',
diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
index 3f3e46641..3d8e3ceca 100644
--- a/langs/en/cgi-bin/en.pl
+++ b/langs/en/cgi-bin/en.pl
@@ -678,6 +678,7 @@ 
 'country' => 'Country',
 'country codes and flags' => 'Country Codes and Flags:',
 'countrycode' => 'Code',
+'cpu frequency' => 'CPU frequency',
 'cpu frequency per' => 'CPU frequency per',
 'cpu idle usage' => 'Idle CPU Usage',
 'cpu interrupt usage' => 'Interrupt CPU Usage',