urlfilter.cgi: Add note on HTTP-only URL filtering

Message ID ee843a11a8b74e1c65a647382c9a0d83d574d337.camel@hotmail.com
State New
Headers
Series urlfilter.cgi: Add note on HTTP-only URL filtering |

Commit Message

Luca 22 Nov 2026, 4:22 p.m. UTC
Add a brief note next to the "Enable Custom Blacklist" and "Enable
Custom Whitelist" checkboxes, aligned under the "Blocked URLs" and
"Allowed URLs" fields, informing users that URL filtering works only
with HTTP connections and not with HTTPS connections.

Signed-off-by: Luca Trevisani <lucatrv@hotmail.com>
---
 html/cgi-bin/urlfilter.cgi | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
  

Comments

Peer Dietzmann 22 Nov 2026, 5:05 p.m. UTC | #1
Hi Luca,

I do really like your approach to make this more clear.

But in view of the new DNS-Firewall, I think it would make more sense so 
rework the whole location of URL-Filter/Webproxy on the one hand and the 
DNS-Firewall on the other hand.

Just "URL-Filter" could be confused with the DNS-Firewall, is it really 
clear, that those are two different things? Maybe "Proxy-URL-Filter" as 
title would be more clear?

Also: why is DNS-Firewall located under "Firewall" and URL-Filter under 
"Network"? Wouldn't both belong to the network as well as to the firewall?

Best,

Peer

On 22/11/2026 17:22, Luca wrote:
> Add a brief note next to the "Enable Custom Blacklist" and "Enable
> Custom Whitelist" checkboxes, aligned under the "Blocked URLs" and
> "Allowed URLs" fields, informing users that URL filtering works only
> with HTTP connections and not with HTTPS connections.
>
> Signed-off-by: Luca Trevisani <lucatrv@hotmail.com>
> ---
>   html/cgi-bin/urlfilter.cgi | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/html/cgi-bin/urlfilter.cgi b/html/cgi-bin/urlfilter.cgi
> index 73ad85bfd..217a5ef8b 100644
> --- a/html/cgi-bin/urlfilter.cgi
> +++ b/html/cgi-bin/urlfilter.cgi
> @@ -1253,9 +1253,8 @@ print <<END
>   <table width='100%'>
>   <tr>
>           <td class='base' width='25%'>@{[ _('Enable Custom Blacklist:') ]}</td>
> -        <td><input type='checkbox' name='ENABLE_CUSTOM_BLACKLIST' $checked{'ENABLE_CUSTOM_BLACKLIST'}{'on'} /></td>
> -        <td>&nbsp;</td>
> -        <td>&nbsp;</td>
> +        <td width='25%'><input type='checkbox' name='ENABLE_CUSTOM_BLACKLIST' $checked{'ENABLE_CUSTOM_BLACKLIST'}{'on'} /></td>
> +        <td width='50%'><small><i>@{[ _('URL filtering works only with HTTP connections, not with HTTPS connections.') ]}</i></small></td>
>   </tr>
>   </table>
>   <hr size='1'>
> @@ -1296,9 +1295,8 @@ print <<END
>   <table width='100%'>
>   <tr>
>           <td class='base' width='25%'>@{[ _('Enable Custom Whitelist:') ]}</td>
> -        <td><input type='checkbox' name='ENABLE_CUSTOM_WHITELIST' $checked{'ENABLE_CUSTOM_WHITELIST'}{'on'} /></td>
> -        <td>&nbsp;</td>
> -        <td>&nbsp;</td>
> +        <td width='25%'><input type='checkbox' name='ENABLE_CUSTOM_WHITELIST' $checked{'ENABLE_CUSTOM_WHITELIST'}{'on'} /></td>
> +        <td width='50%'><small><i>@{[ _('URL filtering works only with HTTP connections, not with HTTPS connections.') ]}</i></small></td>
>   </tr>
>   </table>
>   <hr size='1'>
  
Luca 22 Nov 2026, 5:35 p.m. UTC | #2
Hi Peter,

Personally I agree with you. I would suggest to rename "URL Filter"
into "Proxy Filter", because it clarifies that it applies to the Web
Proxy and because it can work both based on domains and URLs (for HTTP
traffic). Then I would move both "Web Proxy" and "Proxy Filter" under
the "Firewall" menu because all other filtering tools are located
there.

Regards,
Luca

On Sun, 2026-11-22 at 18:05 +0100, Peer Dietzmann wrote:
> Hi Luca,
> 
> I do really like your approach to make this more clear.
> 
> But in view of the new DNS-Firewall, I think it would make more sense so 
> rework the whole location of URL-Filter/Webproxy on the one hand and the 
> DNS-Firewall on the other hand.
> 
> Just "URL-Filter" could be confused with the DNS-Firewall, is it really 
> clear, that those are two different things? Maybe "Proxy-URL-Filter" as 
> title would be more clear?
> 
> Also: why is DNS-Firewall located under "Firewall" and URL-Filter under 
> "Network"? Wouldn't both belong to the network as well as to the firewall?
> 
> Best,
> 
> Peer
> 
> On 22/11/2026 17:22, Luca wrote:
> > Add a brief note next to the "Enable Custom Blacklist" and "Enable
> > Custom Whitelist" checkboxes, aligned under the "Blocked URLs" and
> > "Allowed URLs" fields, informing users that URL filtering works only
> > with HTTP connections and not with HTTPS connections.
> > 
> > Signed-off-by: Luca Trevisani <lucatrv@hotmail.com>
> > ---
> >   html/cgi-bin/urlfilter.cgi | 10 ++++------
> >   1 file changed, 4 insertions(+), 6 deletions(-)
> > 
> > diff --git a/html/cgi-bin/urlfilter.cgi b/html/cgi-bin/urlfilter.cgi
> > index 73ad85bfd..217a5ef8b 100644
> > --- a/html/cgi-bin/urlfilter.cgi
> > +++ b/html/cgi-bin/urlfilter.cgi
> > @@ -1253,9 +1253,8 @@ print <<END
> >   <table width='100%'>
> >   <tr>
> >           <td class='base' width='25%'>@{[ _('Enable Custom Blacklist:') ]}</td>
> > -        <td><input type='checkbox' name='ENABLE_CUSTOM_BLACKLIST' $checked{'ENABLE_CUSTOM_BLACKLIST'}{'on'} /></td>
> > -        <td>&nbsp;</td>
> > -        <td>&nbsp;</td>
> > +        <td width='25%'><input type='checkbox' name='ENABLE_CUSTOM_BLACKLIST' $checked{'ENABLE_CUSTOM_BLACKLIST'}{'on'} /></td>
> > +        <td width='50%'><small><i>@{[ _('URL filtering works only with HTTP connections, not with HTTPS connections.') ]}</i></small></td>
> >   </tr>
> >   </table>
> >   <hr size='1'>
> > @@ -1296,9 +1295,8 @@ print <<END
> >   <table width='100%'>
> >   <tr>
> >           <td class='base' width='25%'>@{[ _('Enable Custom Whitelist:') ]}</td>
> > -        <td><input type='checkbox' name='ENABLE_CUSTOM_WHITELIST' $checked{'ENABLE_CUSTOM_WHITELIST'}{'on'} /></td>
> > -        <td>&nbsp;</td>
> > -        <td>&nbsp;</td>
> > +        <td width='25%'><input type='checkbox' name='ENABLE_CUSTOM_WHITELIST' $checked{'ENABLE_CUSTOM_WHITELIST'}{'on'} /></td>
> > +        <td width='50%'><small><i>@{[ _('URL filtering works only with HTTP connections, not with HTTPS connections.') ]}</i></small></td>
> >   </tr>
> >   </table>
> >   <hr size='1'>
  

Patch

diff --git a/html/cgi-bin/urlfilter.cgi b/html/cgi-bin/urlfilter.cgi
index 73ad85bfd..217a5ef8b 100644
--- a/html/cgi-bin/urlfilter.cgi
+++ b/html/cgi-bin/urlfilter.cgi
@@ -1253,9 +1253,8 @@  print <<END
 <table width='100%'>
 <tr>
         <td class='base' width='25%'>@{[ _('Enable Custom Blacklist:') ]}</td>
-        <td><input type='checkbox' name='ENABLE_CUSTOM_BLACKLIST' $checked{'ENABLE_CUSTOM_BLACKLIST'}{'on'} /></td>
-        <td>&nbsp;</td>
-        <td>&nbsp;</td>
+        <td width='25%'><input type='checkbox' name='ENABLE_CUSTOM_BLACKLIST' $checked{'ENABLE_CUSTOM_BLACKLIST'}{'on'} /></td>
+        <td width='50%'><small><i>@{[ _('URL filtering works only with HTTP connections, not with HTTPS connections.') ]}</i></small></td>
 </tr>
 </table>
 <hr size='1'>
@@ -1296,9 +1295,8 @@  print <<END
 <table width='100%'>
 <tr>
         <td class='base' width='25%'>@{[ _('Enable Custom Whitelist:') ]}</td>
-        <td><input type='checkbox' name='ENABLE_CUSTOM_WHITELIST' $checked{'ENABLE_CUSTOM_WHITELIST'}{'on'} /></td>
-        <td>&nbsp;</td>
-        <td>&nbsp;</td>
+        <td width='25%'><input type='checkbox' name='ENABLE_CUSTOM_WHITELIST' $checked{'ENABLE_CUSTOM_WHITELIST'}{'on'} /></td>
+        <td width='50%'><small><i>@{[ _('URL filtering works only with HTTP connections, not with HTTPS connections.') ]}</i></small></td>
 </tr>
 </table>
 <hr size='1'>