Collectd: Stop tracking rtorrent, asterisk, java, and spamd processes

Message ID e9107c5f-bb21-1a61-bf86-07d0bd62a42b@ipfire.org
State Accepted
Commit 709fa7f3323961471323538ecb2ee6f8548107ec
Headers
Series Collectd: Stop tracking rtorrent, asterisk, java, and spamd processes |

Commit Message

Peter Müller Jan. 8, 2022, 11:15 a.m. UTC
  These are all not present on current IPFire versions, so there is no
sense in letting collectd keeping track of them.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 config/collectd/collectd.conf | 4 ----
 1 file changed, 4 deletions(-)
  

Comments

Jon Murphy Jan. 8, 2022, 6:10 p.m. UTC | #1
Yay!  This always triggered my OCD!  Thank you!

Can other processes be added?  I don’t have any recommendations since I don’t know how to determine the higher used processes. 

Jon


> On Jan 8, 2022, at 5:15 AM, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> These are all not present on current IPFire versions, so there is no
> sense in letting collectd keeping track of them.
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> config/collectd/collectd.conf | 4 ----
> 1 file changed, 4 deletions(-)
> 
> diff --git a/config/collectd/collectd.conf b/config/collectd/collectd.conf
> index 941c631c9..9270b01ae 100644
> --- a/config/collectd/collectd.conf
> +++ b/config/collectd/collectd.conf
> @@ -73,11 +73,7 @@ include "/etc/collectd.precache"
> 	Process "charon"
> 	Process "openvpn"
> 	Process "qemu"
> -	Process "rtorrent"
> 	Process "mpd"
> -	Process "asterisk"
> -	Process "java"
> -	Process "spamd"
> </Plugin>
> 
> <Plugin rrdtool>
> -- 
> 2.26.2
  
Adolf Belka Jan. 10, 2022, 8:45 a.m. UTC | #2
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org>


On 08/01/2022 12:15, Peter Müller wrote:
> These are all not present on current IPFire versions, so there is no
> sense in letting collectd keeping track of them.
>
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
>   config/collectd/collectd.conf | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/config/collectd/collectd.conf b/config/collectd/collectd.conf
> index 941c631c9..9270b01ae 100644
> --- a/config/collectd/collectd.conf
> +++ b/config/collectd/collectd.conf
> @@ -73,11 +73,7 @@ include "/etc/collectd.precache"
>   	Process "charon"
>   	Process "openvpn"
>   	Process "qemu"
> -	Process "rtorrent"
>   	Process "mpd"
> -	Process "asterisk"
> -	Process "java"
> -	Process "spamd"
>   </Plugin>
>   
>   <Plugin rrdtool>
  

Patch

diff --git a/config/collectd/collectd.conf b/config/collectd/collectd.conf
index 941c631c9..9270b01ae 100644
--- a/config/collectd/collectd.conf
+++ b/config/collectd/collectd.conf
@@ -73,11 +73,7 @@  include "/etc/collectd.precache"
 	Process "charon"
 	Process "openvpn"
 	Process "qemu"
-	Process "rtorrent"
 	Process "mpd"
-	Process "asterisk"
-	Process "java"
-	Process "spamd"
 </Plugin>
 
 <Plugin rrdtool>