diff mbox series

kernel: disable CONFIG_USELIB on x86_64 and i586(-pae)

Message ID d4a21079-c8c5-6e57-f26e-2bdc9b3f34b3@ipfire.org
State Accepted
Commit c2749c1bed787890c843b16ebbcf99c85a21eefb
Headers
Series kernel: disable CONFIG_USELIB on x86_64 and i586(-pae) |

Commit Message

Peter Müller April 18, 2020, 8:24 a.m. UTC 
  > This option enables the uselib syscall a system call used in the dynamic
> linker from libc5 and earlier. glibc does not use this system call. If you
> intend to run programs built on libc5 or earlier you may need to enable this
> syscall. Current systems running glibc can safely disable this.

In my point of view, the last sentence matches our situation.

Fixes: #12379

Cc: Arne Fitzenreiter <arne.fitzenreiter@ipfire.org>
Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 config/kernel/kernel.config.i586-ipfire     | 2 +-
 config/kernel/kernel.config.i586-ipfire-pae | 2 +-
 config/kernel/kernel.config.x86_64-ipfire   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Michael Tremer April 20, 2020, 7:12 a.m. UTC | #1 
Acked-by: Michael Tremer <michael.tremer@ipfire.org>

> On 18 Apr 2020, at 09:24, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
>> This option enables the uselib syscall a system call used in the dynamic
>> linker from libc5 and earlier. glibc does not use this system call. If you
>> intend to run programs built on libc5 or earlier you may need to enable this
>> syscall. Current systems running glibc can safely disable this.
> 
> In my point of view, the last sentence matches our situation.
> 
> Fixes: #12379
> 
> Cc: Arne Fitzenreiter <arne.fitzenreiter@ipfire.org>
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> config/kernel/kernel.config.i586-ipfire     | 2 +-
> config/kernel/kernel.config.i586-ipfire-pae | 2 +-
> config/kernel/kernel.config.x86_64-ipfire   | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kernel.config.i586-ipfire
> index 4bb39fc20..602e3ce2c 100644
> --- a/config/kernel/kernel.config.i586-ipfire
> +++ b/config/kernel/kernel.config.i586-ipfire
> @@ -72,7 +72,7 @@ CONFIG_POSIX_MQUEUE=y
> CONFIG_POSIX_MQUEUE_SYSCTL=y
> CONFIG_CROSS_MEMORY_ATTACH=y
> CONFIG_FHANDLE=y
> -CONFIG_USELIB=y
> +# CONFIG_USELIB is not set
> # CONFIG_AUDIT is not set
> CONFIG_HAVE_ARCH_AUDITSYSCALL=y
> 
> diff --git a/config/kernel/kernel.config.i586-ipfire-pae b/config/kernel/kernel.config.i586-ipfire-pae
> index 318384613..e18434557 100644
> --- a/config/kernel/kernel.config.i586-ipfire-pae
> +++ b/config/kernel/kernel.config.i586-ipfire-pae
> @@ -72,7 +72,7 @@ CONFIG_POSIX_MQUEUE=y
> CONFIG_POSIX_MQUEUE_SYSCTL=y
> CONFIG_CROSS_MEMORY_ATTACH=y
> CONFIG_FHANDLE=y
> -CONFIG_USELIB=y
> +# CONFIG_USELIB is not set
> # CONFIG_AUDIT is not set
> CONFIG_HAVE_ARCH_AUDITSYSCALL=y
> 
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
> index b16d13504..54da3aea4 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -75,7 +75,7 @@ CONFIG_POSIX_MQUEUE=y
> CONFIG_POSIX_MQUEUE_SYSCTL=y
> CONFIG_CROSS_MEMORY_ATTACH=y
> CONFIG_FHANDLE=y
> -CONFIG_USELIB=y
> +# CONFIG_USELIB is not set
> # CONFIG_AUDIT is not set
> CONFIG_HAVE_ARCH_AUDITSYSCALL=y
> 
> -- 
> 2.16.4
diff mbox series

Patch

diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kernel.config.i586-ipfire
index 4bb39fc20..602e3ce2c 100644
--- a/config/kernel/kernel.config.i586-ipfire
+++ b/config/kernel/kernel.config.i586-ipfire
@@ -72,7 +72,7 @@  CONFIG_POSIX_MQUEUE=y
 CONFIG_POSIX_MQUEUE_SYSCTL=y
 CONFIG_CROSS_MEMORY_ATTACH=y
 CONFIG_FHANDLE=y
-CONFIG_USELIB=y
+# CONFIG_USELIB is not set
 # CONFIG_AUDIT is not set
 CONFIG_HAVE_ARCH_AUDITSYSCALL=y
 
diff --git a/config/kernel/kernel.config.i586-ipfire-pae b/config/kernel/kernel.config.i586-ipfire-pae
index 318384613..e18434557 100644
--- a/config/kernel/kernel.config.i586-ipfire-pae
+++ b/config/kernel/kernel.config.i586-ipfire-pae
@@ -72,7 +72,7 @@  CONFIG_POSIX_MQUEUE=y
 CONFIG_POSIX_MQUEUE_SYSCTL=y
 CONFIG_CROSS_MEMORY_ATTACH=y
 CONFIG_FHANDLE=y
-CONFIG_USELIB=y
+# CONFIG_USELIB is not set
 # CONFIG_AUDIT is not set
 CONFIG_HAVE_ARCH_AUDITSYSCALL=y
 
diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
index b16d13504..54da3aea4 100644
--- a/config/kernel/kernel.config.x86_64-ipfire
+++ b/config/kernel/kernel.config.x86_64-ipfire
@@ -75,7 +75,7 @@  CONFIG_POSIX_MQUEUE=y
 CONFIG_POSIX_MQUEUE_SYSCTL=y
 CONFIG_CROSS_MEMORY_ATTACH=y
 CONFIG_FHANDLE=y
-CONFIG_USELIB=y
+# CONFIG_USELIB is not set
 # CONFIG_AUDIT is not set
 CONFIG_HAVE_ARCH_AUDITSYSCALL=y