remote.cgi: cosmetic changes

Message ID 8faceb22-59aa-6d5b-0377-1d53881e998b@ipfire.org
State Accepted
Headers
Series remote.cgi: cosmetic changes |

Commit Message

Peter Müller Dec. 22, 2020, 4:01 p.m. UTC
  - Swap colour generation to improve readability in case of no active SSH logins
- Unify table layout
- Improve German "SSH host key" translation to avoid Deppenleerzeichen

This patch does not introduce functional changes.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 html/cgi-bin/remote.cgi | 8 ++++----
 langs/de/cgi-bin/de.pl  | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
  

Patch

diff --git a/html/cgi-bin/remote.cgi b/html/cgi-bin/remote.cgi
index 31e4f4085..9e566201d 100644
--- a/html/cgi-bin/remote.cgi
+++ b/html/cgi-bin/remote.cgi
@@ -185,7 +185,7 @@  print "</form>\n";
 
 &Header::openbox('100%', 'center', $Lang::tr{'ssh host keys'});
 
-print "<table class='tbl'>\n";
+print "<table class='tbl' width='100%'>\n";
 
 print <<END
 <thead>
@@ -213,7 +213,7 @@  print "</tbody>\n</table>\n";
 &Header::openbox('100%', 'center', $Lang::tr{'ssh active sessions'});
 
 print <<END;
-		<table class="tbl" width='66%'>
+		<table class="tbl" width="100%">
 			<thead>
 				<tr>
 					<th align="center">
@@ -273,7 +273,7 @@  sub printactivelogins()
 	if ( scalar(@output) == 0 )
 	{
 		# no logins appeared
-		my $table_colour = ($id++ % 2) ? $color{'color22'} : $color{'color20'};
+		my $table_colour = ($id++ % 2) ? $color{'color20'} : $color{'color22'};
 		print "<tr bgcolor='$table_colour'><td colspan='5'>$Lang::tr{'ssh no active logins'}</td></tr>\n";
 	} else {
 		# list active logins...
@@ -295,7 +295,7 @@  sub printactivelogins()
 			my $rdns = gethostbyaddr($iaddr, AF_INET);
 			if (!$rdns) { $rdns = $Lang::tr{'ptr lookup failed'}; };
 
-			my $table_colour = ($id++ % 2) ? $color{'color22'} : $color{'color20'};
+			my $table_colour = ($id++ % 2) ? $color{'color20'} : $color{'color22'};
 
 			print <<END;
 			<tr bgcolor='$table_colour'>
diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
index 38c9783f8..b72e4d245 100644
--- a/langs/de/cgi-bin/de.pl
+++ b/langs/de/cgi-bin/de.pl
@@ -2276,7 +2276,7 @@ 
 'ssh active sessions' => 'Aktive Benutzeranmeldungen',
 'ssh agent forwarding' => 'Weiterleitung des SSH-Agenten (Agent Forwarding) zulassen',
 'ssh fingerprint' => 'Fingerabdruck',
-'ssh host keys' => 'SSH Host Schlüssel',
+'ssh host keys' => 'SSH-Serverschlüssel',
 'ssh is disabled' => 'Secure Shell ist deaktiviert.  Halte an.',
 'ssh is enabled' => 'Secure Shell ist aktiviert.  Starte neu.',
 'ssh key' => 'Schlüssel',