From patchwork Mon Nov 7 12:24:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Peter_M=C3=BCller?= X-Patchwork-Id: 6069 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4N5Vln3tc5z3wcM for ; Mon, 7 Nov 2022 12:24:21 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4N5Vll4GYmz12T; Mon, 7 Nov 2022 12:24:19 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4N5Vll3b3zz2ycW; Mon, 7 Nov 2022 12:24:19 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4N5Vlk0jZJz2xg2 for ; Mon, 7 Nov 2022 12:24:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4N5Vlg0sMvzqd for ; Mon, 7 Nov 2022 12:24:14 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1667823856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5DG4InH/xsoi6hLQ/aNnNo2Ubdq0XpRx2bd6A1k1CCs=; b=Vd1XnEUWU+D+AIy7gKPfvw/9yEH1FJDNQl+ngyh7R0TqDWt56cM231XzffOK5IK5+9rYM2 yNE92ey2OA2vHaAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1667823856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5DG4InH/xsoi6hLQ/aNnNo2Ubdq0XpRx2bd6A1k1CCs=; b=GEcUxkaS0BkZJ6d6CFYpPfwuZTEPRcJlvhHPeMQE1QnJjFNvG3IIEsqpltQII/Di0/cYTt 5JrCvhkT3UjVDC6pMoq5QIP+FmegTUSzJIicH0EnOL5kn4vV8Yfxr9gRX/BxQY66QH+34O qM6UlAbqWXh+VQtbjIzroKCutDx6eO/GujhSTkYQjSAlJY8doWBlF1BCq42xonrpU5nWf1 s3IUqxG2u0ESY/IcIUYDXKaPkq2kingSMJAmnzh9EMCzc1JAQeboHw/bZfLIjyGMFD1PvN cPfG5H0Fw2OdjLmY0vR5jzswJ2RrOwVMIK9pIxYBAUezdVjXNeS7G5f1dD1RXg== Message-ID: <6831fe85-6452-73d0-c672-50d116727d11@ipfire.org> Date: Mon, 7 Nov 2022 12:24:07 +0000 MIME-Version: 1.0 Content-Language: en-US To: "IPFire: Development" From: =?utf-8?q?Peter_M=C3=BCller?= Subject: [RFC PATCH] Drop powertop X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" This has been discussed briefly in the telephone conference of September: powertop is considered to be unnecessary, as IPFire is optimized for performance, thus interfering with possible power consumption reducing switches. Also, the need for powertop has been diminished, given that x86 platforms are highly likely not to run on batteries, and we are phasing out 32-bit ARM, where this could have been the case. Therefore, this patch proposes to drop powertop. Signed-off-by: Peter Müller Reviewed-by: Michael Tremer --- config/rootfiles/packages/powertop | 23 -------- lfs/powertop | 90 ------------------------------ make.sh | 1 - 3 files changed, 114 deletions(-) delete mode 100644 config/rootfiles/packages/powertop delete mode 100644 lfs/powertop diff --git a/config/rootfiles/packages/powertop b/config/rootfiles/packages/powertop deleted file mode 100644 index 3ec61dd8e..000000000 --- a/config/rootfiles/packages/powertop +++ /dev/null @@ -1,23 +0,0 @@ -usr/sbin/powertop -#usr/share/bash-completion/completions/powertop -#usr/share/locale/ca/LC_MESSAGES/powertop.mo -#usr/share/locale/cs_CZ/LC_MESSAGES/powertop.mo -#usr/share/locale/de_DE -#usr/share/locale/de_DE/LC_MESSAGES -#usr/share/locale/de_DE/LC_MESSAGES/powertop.mo -#usr/share/locale/en_GB/LC_MESSAGES/powertop.mo -#usr/share/locale/en_US/LC_MESSAGES/powertop.mo -#usr/share/locale/es_ES -#usr/share/locale/es_ES/LC_MESSAGES -#usr/share/locale/es_ES/LC_MESSAGES/powertop.mo -#usr/share/locale/hu_HU -#usr/share/locale/hu_HU/LC_MESSAGES -#usr/share/locale/hu_HU/LC_MESSAGES/powertop.mo -#usr/share/locale/id_ID -#usr/share/locale/id_ID/LC_MESSAGES -#usr/share/locale/id_ID/LC_MESSAGES/powertop.mo -#usr/share/locale/nl_NL -#usr/share/locale/nl_NL/LC_MESSAGES -#usr/share/locale/nl_NL/LC_MESSAGES/powertop.mo -#usr/share/locale/zh_TW/LC_MESSAGES/powertop.mo -#usr/share/man/man8/powertop.8 diff --git a/lfs/powertop b/lfs/powertop deleted file mode 100644 index c909a73bf..000000000 --- a/lfs/powertop +++ /dev/null @@ -1,90 +0,0 @@ -############################################################################### -# # -# IPFire.org - A linux based firewall # -# Copyright (C) 2007-2018 IPFire Team # -# # -# This program is free software: you can redistribute it and/or modify # -# it under the terms of the GNU General Public License as published by # -# the Free Software Foundation, either version 3 of the License, or # -# (at your option) any later version. # -# # -# This program is distributed in the hope that it will be useful, # -# but WITHOUT ANY WARRANTY; without even the implied warranty of # -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # -# GNU General Public License for more details. # -# # -# You should have received a copy of the GNU General Public License # -# along with this program. If not, see . # -# # -############################################################################### - -############################################################################### -# Definitions -############################################################################### - -include Config - -SUMMARY = A Linux Tool to Find out What is Using Power on a Laptop - -VER = 2.14 - -THISAPP = powertop-$(VER) -DL_FILE = $(THISAPP).tar.gz -DL_FROM = $(URL_IPFIRE) -DIR_APP = $(DIR_SRC)/$(THISAPP) -TARGET = $(DIR_INFO)/$(THISAPP) -PROG = powertop -PAK_VER = 4 - -DEPS = - -SERVICES = - -############################################################################### -# Top-level Rules -############################################################################### - -objects = $(DL_FILE) - -$(DL_FILE) = $(DL_FROM)/$(DL_FILE) - -$(DL_FILE)_BLAKE2 = 5f53f81b01e83004f6436f497818d2a552b5e7ffda5007749aad415773adeab2a256aeffbacbf9e5fe803ff343a0c1954b5264aebdffa841bb70406b8b9611bc - -install : $(TARGET) - -check : $(patsubst %,$(DIR_CHK)/%,$(objects)) - -download :$(patsubst %,$(DIR_DL)/%,$(objects)) - -b2 : $(subst %,%_BLAKE2,$(objects)) - -dist: - $(PAK) - -############################################################################### -# Downloading, checking, b2sum -############################################################################### - -$(patsubst %,$(DIR_CHK)/%,$(objects)) : - @$(CHECK) - -$(patsubst %,$(DIR_DL)/%,$(objects)) : - @$(LOAD) - -$(subst %,%_BLAKE2,$(objects)) : - @$(B2SUM) - -############################################################################### -# Installation Details -############################################################################### - -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) - @$(PREBUILD) - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE) - $(UPDATE_AUTOMAKE) - cd $(DIR_APP) && ./autogen.sh - cd $(DIR_APP) && ./configure --prefix=/usr - cd $(DIR_APP) && make $(MAKETUNING) - cd $(DIR_APP) && make install - @rm -rf $(DIR_APP) - @$(POSTBUILD) diff --git a/make.sh b/make.sh index 58220d046..ce88d9c19 100755 --- a/make.sh +++ b/make.sh @@ -1592,7 +1592,6 @@ buildipfire() { lfsmake2 zerofree lfsmake2 minicom lfsmake2 ddrescue - lfsmake2 powertop lfsmake2 parted lfsmake2 swig lfsmake2 dtc