Bug in /srv/web/ipfire/cgi-bin/routing.cgi in Core 95
Message ID | 565BE9D5.4050409@dailydata.net |
---|---|
State | Dropped |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.tremer.info [172.28.1.200]) by septima.ipfire.org (Postfix) with ESMTP id 0D62561367 for <patchwork@ipfire.org>; Mon, 30 Nov 2015 07:17:03 +0100 (CET) Received: from hedwig.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 70BB24429; Mon, 30 Nov 2015 07:17:02 +0100 (CET) Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=74.124.0.219; helo=mickey.dailydata.net; envelope-from=rodo@dailydata.net; receiver=development@lists.ipfire.org Received: from mickey.dailydata.net (mickey.dailydata.net [74.124.0.219]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPS id E482E223F for <development@lists.ipfire.org>; Mon, 30 Nov 2015 07:16:58 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mickey.dailydata.net (Postfix) with ESMTP id 35A392B8FB for <development@lists.ipfire.org>; Mon, 30 Nov 2015 00:16:51 -0600 (CST) X-Virus-Scanned: Debian amavisd-new at mickey.dailydata.net Received: from mickey.dailydata.net ([127.0.0.1]) by localhost (mickey.dailydata.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YslaMzpYj_lu for <development@lists.ipfire.org>; Mon, 30 Nov 2015 00:16:48 -0600 (CST) Received: from [10.111.111.67] (user-0cet30n.cable.mindspring.com [24.238.140.23]) (Authenticated sender: rodo@dailydata.net) by mickey.dailydata.net (Postfix) with ESMTPSA id 3A73124CC1 for <development@lists.ipfire.org>; Mon, 30 Nov 2015 00:16:48 -0600 (CST) Message-ID: <565BE9D5.4050409@dailydata.net> Date: Mon, 30 Nov 2015 00:16:53 -0600 From: "R. W. Rodolico" <rodo@dailydata.net> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: development@lists.ipfire.org Subject: Bug in /srv/web/ipfire/cgi-bin/routing.cgi in Core 95 Content-Type: multipart/mixed; boundary="------------000207090806060102060706" X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
R. W. Rodolico
Nov. 30, 2015, 5:16 p.m. UTC
Line 123 has one too many closing parenths. It currently reads: if (!&General::validipandmask($settings{'IP'}))){ and it should read if (!&General::validipandmask($settings{'IP'})){ (one less closing parentheses). Rod Attached is a diff. I did not know which parameters to give it, so gave it diff -Naur. If you tell me the correct ones, I'll use it in the future. Rod
Comments
Hi Rod, thanks for reporting this. This has actually already been found and fixed here: http://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=1574f25557d0f1bf9729d61dde9f44f1806d8ede Please keep on sending patches like this. The best way would be to use git to create these. More about that can be found here: http://wiki.ipfire.org/devel/submit-patches Best, -Michael On Mon, 2015-11-30 at 00:16 -0600, R. W. Rodolico wrote: > Line 123 has one too many closing parenths. It currently reads: > if (!&General::validipandmask($settings{'IP'}))){ > and it should read > if (!&General::validipandmask($settings{'IP'})){ > > (one less closing parentheses). > > Rod > > Attached is a diff. I did not know which parameters to give it, so > gave > it diff -Naur. If you tell me the correct ones, I'll use it in the > future. > > Rod > > >