mbox

Bug in /srv/web/ipfire/cgi-bin/routing.cgi in Core 95

Message ID 565BE9D5.4050409@dailydata.net
State Dropped
Headers

Message

R. W. Rodolico Nov. 30, 2015, 5:16 p.m. UTC 
  Line 123 has one too many closing parenths. It currently reads:
	if (!&General::validipandmask($settings{'IP'}))){
and it should read
	if (!&General::validipandmask($settings{'IP'})){

(one less closing parentheses).

Rod

Attached is a diff. I did not know which parameters to give it, so gave
it diff -Naur. If you tell me the correct ones, I'll use it in the future.

Rod

Comments

Michael Tremer Dec. 2, 2015, 9:31 a.m. UTC | #1 
Hi Rod,

thanks for reporting this. This has actually already been found and
fixed here:

  http://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=1574f25557d0f1bf9729d61dde9f44f1806d8ede

Please keep on sending patches like this. The best way would be to use
git to create these. More about that can be found here:

  http://wiki.ipfire.org/devel/submit-patches

Best,
-Michael

On Mon, 2015-11-30 at 00:16 -0600, R. W. Rodolico wrote:
> Line 123 has one too many closing parenths. It currently reads:
> 	if (!&General::validipandmask($settings{'IP'}))){
> and it should read
> 	if (!&General::validipandmask($settings{'IP'})){
> 
> (one less closing parentheses).
> 
> Rod
> 
> Attached is a diff. I did not know which parameters to give it, so
> gave
> it diff -Naur. If you tell me the correct ones, I'll use it in the
> future.
> 
> Rod
> 
> 
>