actual system time and timezone info-bar to ipfire theme
Message ID | 55CC92AC.3000504@gmx.de |
---|---|
State | Dropped |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.tremer.info [172.28.1.200]) by septima.ipfire.org (Postfix) with ESMTP id C5ADF61D66 for <patchwork@ipfire.org>; Thu, 13 Aug 2015 14:51:01 +0200 (CEST) Received: from hedwig.ipfire.org (localhost [IPv6:::1]) by mail01.ipfire.org (Postfix) with ESMTP id 7822B225C; Thu, 13 Aug 2015 14:51:01 +0200 (CEST) Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=212.227.15.19; helo=mout.gmx.net; envelope-from=xaver4all@gmx.de; receiver=development@lists.ipfire.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPS id 05ED39C8 for <development@lists.ipfire.org>; Thu, 13 Aug 2015 14:50:59 +0200 (CEST) Received: from [192.168.1.132] ([188.193.102.14]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MXZ4Q-1ZL0YW1LsM-00WW1a for <development@lists.ipfire.org>; Thu, 13 Aug 2015 14:50:58 +0200 From: Xaver4all <xaver4all@gmx.de> Subject: [PATCH] actual system time and timezone info-bar to ipfire theme To: development@lists.ipfire.org Message-ID: <55CC92AC.3000504@gmx.de> Date: Thu, 13 Aug 2015 14:50:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070804000802070006040304" X-Provags-ID: V03:K0:j+pIGhW7ZQUe0OPQMbxLzrlFH6TgWtCSgZCRC6aX/fBK9wf8ZVC +34op2wklIoNBt8qpnhmIbP2H+H+qUTDfaSEwIOBkqGAyJV828ML+8opD+YYNGDYX9WMHv8 qFmLBfnOsoupipt9My25QY5LizH4LA/DohwoczpImSx2VmJxfpt7o7XMyGJ8TZDjDm6YCGi oj1mdE+RmoQCoNutBMxPw== X-UI-Out-Filterresults: notjunk:1; V01:K0:795+j63vAJ4=:acNq7ZqjK1JP/wOuQM0B87 EEJbEKixvSj4uRJ8G1wB5rpIeHkyoJLoXi0o7A9+Oj2KpL21yhz27dPPI4lu19tB6tIjpuArh 4p8RttOecTw9EesXtZmuDjM4R9dcg9l5GxZaYT022rtL1ixzm2oeEq/OfL8t9B17pxA9oggXW dkxxu7S9CCqesdxMhoZx1QK631KmNysZBxF7LGTdGMOBEOWEJJTmnDReOGqqsGY7u3OoZeDEd FPf7V30OtCNzInBltyQNB6u9J8dYuAwdMrvrwlTa7AOfrMdrVa38Zo3/tiBx6f6yXx1UbxX6T XcMts/+VxZCRx0P9K2LOJVBG84bh+5y+STP74JthwMGI1uF1OxlDh1UPdYaWMQ9/5LLIDVcdU r4byzCzPWuBFkYegN80o9A5rn5hS+W6qUJ9sgNFJJV1iISysbj2I4rebvnDdlLHKtsI2KQXvO q2+8ff6oy5LmuaYYGfafnvp3gSZ3WoQKoi+od6fgjb0WE7B2kLOasmOHnrtQwMaDswFShVJ39 JEjIOGZJesE2H3dnlu27cT8rUBe4BEfXnOxH1dL5DlgSUsDwkQ/OGb9DQgAgZSNjkZ/PBBhjN J/TW9o0o8+abG1qlW+gkuAyCQ+TVJwaj+hEApPSM3VY8F8NkA0MeoTsDTBJzgPAMtHScfGeeT DpkRHCYOMbt4rJ2aKIWWX94VAp0f0/2E5l2Cnhhn4Q3V9Zw7I2HlSWdl63taKJuUhbVZbQXOb 1M0hU9crQzVcwUtT X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <http://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <http://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Message
Xaver4all
13 Aug 2015, 10:50 p.m. UTC
Hi all,
this is my first time using this mailing-list thing,
so hopefully I do everything according to your CoC.
[PATCH]
add actual system time and timezone info-bar to ipfire theme.
position can be configured in GUI user-settings, default is off.
future reference, German discussion in forum:
http://forum.ipfire.org/viewtopic.php?f=17&t=12177
attached is a patch against the actual next branch
br,
Kim
From 4509adfd71ff9aeb6bcae225ae126ed437e8fa20 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?W=C3=B6lfel=20Kim?= <xaver4all@gmx.de>
Date: Tue, 11 Aug 2015 00:26:24 +0200
Subject: [PATCH] add actual system time and timezone info-bar to ipfire theme.
position can be configured in GUI user-settings, default is off.
---
html/cgi-bin/gui.cgi | 27 ++++++++++++
html/cgi-bin/uptime.cgi | 50 ++++++++++++++++++++++
html/html/themes/ipfire/include/css/style.css | 21 +++++++++
html/html/themes/ipfire/include/functions.pl | 40 ++++++++++++++++-
.../themes/ipfire/include/js/refreshUpTimeInfo.js | 29 +++++++++++++
langs/de/cgi-bin/de.pl | 5 +++
langs/en/cgi-bin/en.pl | 5 +++
langs/es/cgi-bin/es.pl | 7 +++
langs/fr/cgi-bin/fr.pl | 7 +++
langs/it/cgi-bin/it.pl | 5 +++
langs/nl/cgi-bin/nl.pl | 7 +++
langs/pl/cgi-bin/pl.pl | 7 +++
langs/ru/cgi-bin/ru.pl | 7 +++
langs/tr/cgi-bin/tr.pl | 5 +++
14 files changed, 221 insertions(+), 1 deletion(-)
create mode 100644 html/cgi-bin/uptime.cgi
create mode 100644 html/html/themes/ipfire/include/js/refreshUpTimeInfo.js
Comments
Hi Kim, I have been using this for not so long either, but I can tell you that patches should be sent inline (no attachment) and you have to disable line-wrap in your mail client. Some examples: http://patchwork.ipfire.org/project/ipfire/list/ hth, Lars On Thu, 13 Aug 2015 14:50:52 +0200, Xaver4all <xaver4all@gmx.de> wrote: > Hi all, > > this is my first time using this mailing-list thing, > so hopefully I do everything according to your CoC. > > [PATCH] > add actual system time and timezone info-bar to ipfire theme. > position can be configured in GUI user-settings, default is off. > > future reference, German discussion in forum: > http://forum.ipfire.org/viewtopic.php?f=17&t=12177 > > attached is a patch against the actual next branch > > br, > Kim
Hello, On Thu, 2015-08-13 at 15:00 +0200, Larsen wrote: > Hi Kim, > > I have been using this for not so long either, but I can tell you > that > patches should be sent inline (no attachment) and you have to disable Indeed, we can comment on an inline patch much easier. Patchwork however parsed the attachment correctly, so it is okay for this time. > line-wrap in your mail client. > Some examples: http://patchwork.ipfire.org/project/ipfire/list/ On the thing itself: I saw the conversation on the IPFire forum and must say that I do not really get why all this information is needed on the web user interface. So I would like to discuss this first before looking closely at the patch. Time: I get that this is a good information to know just to check if the clock of the system is running correctly. If the timezone needs to be included if it is local time is debatable. Load: I do not really understand why this is an important information that should be on every single page of the web user interface. Most users do not even really understand the meaning of these values and often worry about numbers above a certain value they are used to. I think this could be as well below the load graph. Logged in users and uptime: There is no point in this. I wonder why you find this is important. So this information is automatically updated by Javascript every other second. This will always return a wrong time because there is obviously lots of latency on the network. What is wrong with just embedding the time when the page was generated? I just would like to hear your objective or opinion on this. Best, -Michael > > hth, > Lars > > > On Thu, 13 Aug 2015 14:50:52 +0200, Xaver4all <xaver4all@gmx.de> > wrote: > > > Hi all, > > > > this is my first time using this mailing-list thing, > > so hopefully I do everything according to your CoC. > > > > [PATCH] > > add actual system time and timezone info-bar to ipfire theme. > > position can be configured in GUI user-settings, default is off. > > > > future reference, German discussion in forum: > > http://forum.ipfire.org/viewtopic.php?f=17&t=12177 > > > > attached is a patch against the actual next branch > > > > br, > > Kim
Hi, my few cents for this: I'm used to see some (important) information by the *first* look, especially things regarding the actual 'time', 'uptime', 'load' and 'traffic'. For example: in the past I had to search for the load graph to see if "something is going on", now I see it at a glance. Good. For me, this is an important information, other opinions may vary... In my view, 'Date' and 'User:' are not so important, similar to the 'Automatic update'-feature. For me it would be ok, if this would be static and only updated generating the current page. This is why I originally added these wanted information by simply adding some ~kind of 'uptime'-command to my footer: http://forum.ipfire.org/viewtopic.php?f=17&t=12177#p88508 Furthermore, I noticed that keeping a page open costs some system load, generated by Javascript(?). Jm2C Regards Matthias On 13.08.2015 18:33, Michael Tremer wrote: > Hello, > > On Thu, 2015-08-13 at 15:00 +0200, Larsen wrote: >> Hi Kim, >> >> I have been using this for not so long either, but I can tell you >> that >> patches should be sent inline (no attachment) and you have to disable > > > Indeed, we can comment on an inline patch much easier. Patchwork > however parsed the attachment correctly, so it is okay for this time. > >> line-wrap in your mail client. >> Some examples: http://patchwork.ipfire.org/project/ipfire/list/ > > On the thing itself: I saw the conversation on the IPFire forum and > must say that I do not really get why all this information is needed on > the web user interface. So I would like to discuss this first before > looking closely at the patch. > > Time: I get that this is a good information to know just to check if > the clock of the system is running correctly. If the timezone needs to > be included if it is local time is debatable. > > Load: I do not really understand why this is an important information > that should be on every single page of the web user interface. Most > users do not even really understand the meaning of these values and > often worry about numbers above a certain value they are used to. > > I think this could be as well below the load graph. > > Logged in users and uptime: There is no point in this. I wonder why you > find this is important. > > So this information is automatically updated by Javascript every other > second. This will always return a wrong time because there is obviously > lots of latency on the network. What is wrong with just embedding the > time when the page was generated? > > I just would like to hear your objective or opinion on this. > > Best, > -Michael > >> >> hth, >> Lars >> >> >> On Thu, 13 Aug 2015 14:50:52 +0200, Xaver4all <xaver4all@gmx.de> >> wrote: >> >> > Hi all, >> > >> > this is my first time using this mailing-list thing, >> > so hopefully I do everything according to your CoC. >> > >> > [PATCH] >> > add actual system time and timezone info-bar to ipfire theme. >> > position can be configured in GUI user-settings, default is off. >> > >> > future reference, German discussion in forum: >> > http://forum.ipfire.org/viewtopic.php?f=17&t=12177 >> > >> > attached is a patch against the actual next branch >> > >> > br, >> > Kim >
On Thu, 2015-08-13 at 19:33 +0200, Matthias Fischer wrote: > Hi, > > my few cents for this: > > I'm used to see some (important) information by the *first* look, > especially things regarding the actual 'time', 'uptime', 'load' and > 'traffic'. For example: in the past I had to search for the load > graph > to see if "something is going on", now I see it at a glance. Good. > For > me, this is an important information, other opinions may vary... I get that, but the firewall is not really a good thing to check for the time. You will also not really notice if the clock is a minute or two off. Why do you check the uptime on your machines? And what does the load tell you? The only thing that is interesting to know about the load is how it develops over time and we have that in a graph. > In my view, 'Date' and 'User:' are not so important, similar to the > 'Automatic update'-feature. For me it would be ok, if this would be > static and only updated generating the current page. > > This is why I originally added these wanted information by simply > adding > some ~kind of 'uptime'-command to my footer: > http://forum.ipfire.org/viewtopic.php?f=17&t=12177#p88508 > > Furthermore, I noticed that keeping a page open costs some system > load, > generated by Javascript(?). This will fork a new perl process every time, load the code of the web user interface, execute the CGI and then send back the result. I did not look at the code what is done and how often it is done. Not sure what you are asking, but this creates load on both the client and firewall. -Michael > > Jm2C > Regards > Matthias > > > On 13.08.2015 18:33, Michael Tremer wrote: > > Hello, > > > > On Thu, 2015-08-13 at 15:00 +0200, Larsen wrote: > > > Hi Kim, > > > > > > I have been using this for not so long either, but I can tell you > > > that > > > patches should be sent inline (no attachment) and you have to > > > disable > > > > > > Indeed, we can comment on an inline patch much easier. Patchwork > > however parsed the attachment correctly, so it is okay for this > > time. > > > > > line-wrap in your mail client. > > > Some examples: http://patchwork.ipfire.org/project/ipfire/list/ > > > > On the thing itself: I saw the conversation on the IPFire forum and > > must say that I do not really get why all this information is > > needed on > > the web user interface. So I would like to discuss this first > > before > > looking closely at the patch. > > > > Time: I get that this is a good information to know just to check > > if > > the clock of the system is running correctly. If the timezone needs > > to > > be included if it is local time is debatable. > > > > Load: I do not really understand why this is an important > > information > > that should be on every single page of the web user interface. Most > > users do not even really understand the meaning of these values and > > often worry about numbers above a certain value they are used to. > > > > I think this could be as well below the load graph. > > > > Logged in users and uptime: There is no point in this. I wonder why > > you > > find this is important. > > > > So this information is automatically updated by Javascript every > > other > > second. This will always return a wrong time because there is > > obviously > > lots of latency on the network. What is wrong with just embedding > > the > > time when the page was generated? > > > > I just would like to hear your objective or opinion on this. > > > > Best, > > -Michael > > > > > > > > hth, > > > Lars > > > > > > > > > On Thu, 13 Aug 2015 14:50:52 +0200, Xaver4all <xaver4all@gmx.de> > > > wrote: > > > > > > > Hi all, > > > > > > > > this is my first time using this mailing-list thing, > > > > so hopefully I do everything according to your CoC. > > > > > > > > [PATCH] > > > > add actual system time and timezone info-bar to ipfire theme. > > > > position can be configured in GUI user-settings, default is > > > > off. > > > > > > > > future reference, German discussion in forum: > > > > http://forum.ipfire.org/viewtopic.php?f=17&t=12177 > > > > > > > > attached is a patch against the actual next branch > > > > > > > > br, > > > > Kim > > >