From patchwork Mon May 17 19:01:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Peter_M=C3=BCller?= X-Patchwork-Id: 4304 Return-Path: Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4FkT5L2l5tz3wbb for ; Mon, 17 May 2021 19:01:58 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4FkT5L0HRnz26y; Mon, 17 May 2021 19:01:58 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4FkT5K6nDnz2xd6; Mon, 17 May 2021 19:01:57 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4FkT5K2gc6z2xF1 for ; Mon, 17 May 2021 19:01:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4FkT5J2Xntz1TQ for ; Mon, 17 May 2021 19:01:56 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1621278116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=//i58Wr20jG6D1uS6TGLC0uWM0NUmru07LpqOwiGZEo=; b=X6iQsNEo+qSLtT/kAiP9AP2CllPAOdTDggQ1TeHXguMZmvWVfCG2rXgEyjmRLi9EiPdEaZ yaRpWD3XRsIKX5Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1621278116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=//i58Wr20jG6D1uS6TGLC0uWM0NUmru07LpqOwiGZEo=; b=Md5mZbG0aofgDOjTWmXcw9BhQYBzAN+KJIjINiy/MfpKlktjyWcfjUYaDk+IfsHh2iZYkt 3RNUMQUixlximVMSDNgGBf8LpZEFN8eY6qBwWbvozvgW7kyEOG/zgcDxWXThVAwF2QMByf dmbBwkyVXc6M0k77Gbp9g2AVidu7hjtIZaQePon9RJP+fhsCe/bS2XlmWHt8384doRXwY8 KUtwWQpzLX5sVykREyjByDTYLoqTiGGhsQPDztVB4eSvKn3oSH8B0MS1ZDx2RX4gwv35Cx iyJaiuzhmLafUqvHBZtklmftPXY/9x5KmYUHlUWUH3Sm/OqXtPCsdNjiUxQiGg== Subject: [PATCH 03/20] /usr/bin/ping does not need a SUID bit if appropriate capabilities are set To: development@lists.ipfire.org References: <7b61506c-84b9-f4e8-7a5f-5a8e8a39f795@ipfire.org> From: =?utf-8?q?Peter_M=C3=BCller?= Message-ID: <4924bc88-655d-2a81-96de-000a7362bece@ipfire.org> Date: Mon, 17 May 2021 21:01:54 +0200 MIME-Version: 1.0 In-Reply-To: <7b61506c-84b9-f4e8-7a5f-5a8e8a39f795@ipfire.org> Content-Language: en-US X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: development-bounces@lists.ipfire.org Sender: "Development" Cc: Michael Tremer Signed-off-by: Peter Müller --- lfs/iputils | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lfs/iputils b/lfs/iputils index b1e2e2216..ae692df7a 100644 --- a/lfs/iputils +++ b/lfs/iputils @@ -1,7 +1,7 @@ ############################################################################### # # # IPFire.org - A linux based firewall # -# Copyright (C) 2007-2018 IPFire Team # +# Copyright (C) 2007-2021 IPFire Team # # # # This program is free software: you can redistribute it and/or modify # # it under the terms of the GNU General Public License as published by # @@ -71,9 +71,12 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) @$(PREBUILD) @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) cd $(DIR_APP) && make ping tracepath - cd $(DIR_APP) && install -m 4755 ping /usr/bin + cd $(DIR_APP) && install -m 0755 ping /usr/bin cd $(DIR_APP) && install -m 0755 tracepath /usr/bin + # Allow execution of /usr/bin/ping by other users than "root" + setcap cap_net_raw+ep /usr/bin/ping + # Some scripts expect ping in /bin/ping. ln -svf ../usr/bin/ping /bin/ping