| Message ID | 45750d21-4ee6-4269-c2b5-56ef4e75c259@ipfire.org |
|---|---|
| State | Superseded |
| Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 48ZYP469sjz3yBZ for <patchwork@web04.haj.ipfire.org>; Sat, 7 Mar 2020 18:46:48 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail02.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 48ZYP336Dszg2; Sat, 7 Mar 2020 18:46:47 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 48ZYP31BG5z2yX5; Sat, 7 Mar 2020 18:46:47 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail01.haj.ipfire.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 48ZYP1063Zz2yCb for <development@lists.ipfire.org>; Sat, 7 Mar 2020 18:46:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPSA id 48ZYNz4WJszg2 for <development@lists.ipfire.org>; Sat, 7 Mar 2020 18:46:43 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=201909ed25519; t=1583606804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aQywWCeIJb3DvF2//6xlnAPsERCEWiELxrwt7b/X/xQ=; b=gHm9YwpiL58vcgRE9FY2112Hcbm4nUf/XD11dKNKABHbxVAYRgyDuvNryosHr8mqkKfJK+ 2wttdCubzpc2+QDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=201909rsa; t=1583606804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aQywWCeIJb3DvF2//6xlnAPsERCEWiELxrwt7b/X/xQ=; b=mPJUgWfD24fuGfv38qG1OCOnyXfmhU8PEfzBAx911SOB8RnpbaH+YIwmjzpwFqWYLdh55b QzXDt0jsaZxvAyDxPUtiigB3qdibJWZGwBsB76VuegKn+UMPT1nBkJkLqsBSUNA0HTuUiR Kr4qfgE/F9oJQH4EDbpHJJn1oGu8n/KZ4Fv4BrlVwwqD2pTHfNa+wOilinbCQi2GMZZ4Gh sdiWUgOGKhPevXHXReOj25LnM0PF2A+nkS7KY10z06gitPkQZjAEZmF6O5sS+cb9HSur3a idxYL5UHeYdudEsIdyjptGUlbYO0WEgz9Mq2xV2KjPWGmoUPV+JappedJrz6Ew== To: "IPFire: Development-List" <development@lists.ipfire.org> From: =?utf-8?q?Peter_M=C3=BCller?= <peter.mueller@ipfire.org> Subject: [PATCH] netother.cgi: show content of routing table 220 Message-ID: <45750d21-4ee6-4269-c2b5-56ef4e75c259@ipfire.org> Date: Sat, 07 Mar 2020 18:46:00 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Authentication-Results: mail01.ipfire.org; auth=pass smtp.mailfrom=peter.mueller@ipfire.org X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
| Series |
netother.cgi: show content of routing table 220
|
|
Commit Message
Peter Müller
March 7, 2020, 6:46 p.m. UTC
Since IPsec routing information do not show up in the normal routing
table, also displaying the contents of table 220 on netother.cgi might
be useful for debugging purposes.
Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
html/cgi-bin/netother.cgi | 6 ++++++
1 file changed, 6 insertions(+)
Comments
Hi, I appreciate the thought, but I think the implementation might be very confusing. I think the patch could be improved by: * Removing the 220 number and simply call it “IPsec VPN Routing Table” * Not show the box when the table is empty which it will be for all users that are not using IPsec And since it is basically a static table, I do not see what there is to gain for the user from this. How can this help with debugging? -Michael > On 7 Mar 2020, at 18:46, Peter Müller <peter.mueller@ipfire.org> wrote: > > Since IPsec routing information do not show up in the normal routing > table, also displaying the contents of table 220 on netother.cgi might > be useful for debugging purposes. > > Signed-off-by: Peter Müller <peter.mueller@ipfire.org> > --- > html/cgi-bin/netother.cgi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi > index dde1b603a..ac02b8148 100644 > --- a/html/cgi-bin/netother.cgi > +++ b/html/cgi-bin/netother.cgi > @@ -79,6 +79,12 @@ if ( $querry[0] =~ "fwhits"){ > print "<pre>$output</pre>\n"; > &Header::closebox(); > > + &Header::openbox('100%', 'left', "$Lang::tr{'routing table entries'} 220"); > + $output = `/sbin/ip route list table 220`; > + $output = &Header::cleanhtml($output,"y"); > + print "<pre>$output</pre>\n"; > + &Header::closebox() > + > &Header::openbox('100%', 'left', $Lang::tr{'arp table entries'}); > $output = `/sbin/ip neigh show`; > $output = &Header::cleanhtml($output,"y"); > -- > 2.16.4
Hello Michael, > Hi, > > I appreciate the thought, but I think the implementation might be very confusing. > > I think the patch could be improved by: > > * Removing the 220 number and simply call it “IPsec VPN Routing Table” Okay, good point. > > * Not show the box when the table is empty which it will be for all users that are not using IPsec ACK. > > And since it is basically a static table, I do not see what there is to gain for the user from this. How can this help with debugging? For the same reasons we display contents of the routing table, I guess. The user is able to do quick plausibility checks over it, without digging/using the search engine of his/hers least distrust for the command that shows him the IPsec routing information. Thanks, and best regards, Peter Müller > > -Michael > >> On 7 Mar 2020, at 18:46, Peter Müller <peter.mueller@ipfire.org> wrote: >> >> Since IPsec routing information do not show up in the normal routing >> table, also displaying the contents of table 220 on netother.cgi might >> be useful for debugging purposes. >> >> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >> --- >> html/cgi-bin/netother.cgi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi >> index dde1b603a..ac02b8148 100644 >> --- a/html/cgi-bin/netother.cgi >> +++ b/html/cgi-bin/netother.cgi >> @@ -79,6 +79,12 @@ if ( $querry[0] =~ "fwhits"){ >> print "<pre>$output</pre>\n"; >> &Header::closebox(); >> >> + &Header::openbox('100%', 'left', "$Lang::tr{'routing table entries'} 220"); >> + $output = `/sbin/ip route list table 220`; >> + $output = &Header::cleanhtml($output,"y"); >> + print "<pre>$output</pre>\n"; >> + &Header::closebox() >> + >> &Header::openbox('100%', 'left', $Lang::tr{'arp table entries'}); >> $output = `/sbin/ip neigh show`; >> $output = &Header::cleanhtml($output,"y"); >> -- >> 2.16.4 >
Okay. Will you update the patch accordingly, please? -Michael > On 8 Mar 2020, at 13:15, Peter Müller <peter.mueller@ipfire.org> wrote: > > Hello Michael, > >> Hi, >> >> I appreciate the thought, but I think the implementation might be very confusing. >> >> I think the patch could be improved by: >> >> * Removing the 220 number and simply call it “IPsec VPN Routing Table” > > Okay, good point. > >> >> * Not show the box when the table is empty which it will be for all users that are not using IPsec > > ACK. > >> >> And since it is basically a static table, I do not see what there is to gain for the user from this. How can this help with debugging? > > For the same reasons we display contents of the routing table, I guess. The user is > able to do quick plausibility checks over it, without digging/using the search > engine of his/hers least distrust for the command that shows him the IPsec routing information. > > Thanks, and best regards, > Peter Müller > >> >> -Michael >> >>> On 7 Mar 2020, at 18:46, Peter Müller <peter.mueller@ipfire.org> wrote: >>> >>> Since IPsec routing information do not show up in the normal routing >>> table, also displaying the contents of table 220 on netother.cgi might >>> be useful for debugging purposes. >>> >>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >>> --- >>> html/cgi-bin/netother.cgi | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi >>> index dde1b603a..ac02b8148 100644 >>> --- a/html/cgi-bin/netother.cgi >>> +++ b/html/cgi-bin/netother.cgi >>> @@ -79,6 +79,12 @@ if ( $querry[0] =~ "fwhits"){ >>> print "<pre>$output</pre>\n"; >>> &Header::closebox(); >>> >>> + &Header::openbox('100%', 'left', "$Lang::tr{'routing table entries'} 220"); >>> + $output = `/sbin/ip route list table 220`; >>> + $output = &Header::cleanhtml($output,"y"); >>> + print "<pre>$output</pre>\n"; >>> + &Header::closebox() >>> + >>> &Header::openbox('100%', 'left', $Lang::tr{'arp table entries'}); >>> $output = `/sbin/ip neigh show`; >>> $output = &Header::cleanhtml($output,"y"); >>> -- >>> 2.16.4 >>
diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi index dde1b603a..ac02b8148 100644 --- a/html/cgi-bin/netother.cgi +++ b/html/cgi-bin/netother.cgi @@ -79,6 +79,12 @@ if ( $querry[0] =~ "fwhits"){ print "<pre>$output</pre>\n"; &Header::closebox(); + &Header::openbox('100%', 'left', "$Lang::tr{'routing table entries'} 220"); + $output = `/sbin/ip route list table 220`; + $output = &Header::cleanhtml($output,"y"); + print "<pre>$output</pre>\n"; + &Header::closebox() + &Header::openbox('100%', 'left', $Lang::tr{'arp table entries'}); $output = `/sbin/ip neigh show`; $output = &Header::cleanhtml($output,"y");