Message ID | 37c1ca96-bffb-5b2c-baee-f8862e1f8b74@ipfire.org |
---|---|
State | Accepted |
Headers |
Return-Path: <development-bounces@lists.ipfire.org> Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by web04.haj.ipfire.org (Postfix) with ESMTPS id 4Lg8mq2SQ2z3xG6 for <patchwork@web04.haj.ipfire.org>; Sat, 9 Jul 2022 12:37:31 +0000 (UTC) Received: from mail02.haj.ipfire.org (mail02.haj.ipfire.org [172.28.1.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail02.haj.ipfire.org", Issuer "R3" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4Lg8mn6fyKz1FS; Sat, 9 Jul 2022 12:37:29 +0000 (UTC) Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4Lg8mn5sZ3z2yT5; Sat, 9 Jul 2022 12:37:29 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) client-signature ECDSA (P-384)) (Client CN "mail01.haj.ipfire.org", Issuer "R3" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Lg8mm3pGlz2xMq for <development@lists.ipfire.org>; Sat, 9 Jul 2022 12:37:28 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4Lg8ml0QlVz18 for <development@lists.ipfire.org>; Sat, 9 Jul 2022 12:37:26 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1657370247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RQNYntkt0SOmCj3pTBPnTEHoiZ0RS0KM2T/U7pxaVvg=; b=hUjF58nIaFgO7AlBzad4LzTqs/AlGzyd+FYUi/417hE5jdKSPEeiqqt6lKJFcdxxcnd8wQ Xrb0aNU1HZOXfADA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1657370247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RQNYntkt0SOmCj3pTBPnTEHoiZ0RS0KM2T/U7pxaVvg=; b=A6PA8bzpt4PxnRfsqgKEEGZKycOFc8Khx4RbLiKNkUA7R79ALl8GL5h8LehdtBMbICPiBi GHHx7EWkQ6mf7pqS1ec9tuJkCbnw0aQbWfoaPoc5BvXarO25aX16HD0nImxM3APHTEhHzx Q5Xbd0wJ9MDCOnl49JS0T1q3KtkvWtUvWMSU8vyJBH+awsbKnsVXegmOCzZX4fjPzdXCKt ApVdNrwtGEPDy2s3eTvi7/38o0zj9fgXpwEnvq1UUUPbHjmNFiGtEQLeBPePRXZyaL1ieR /82h9L9WAtMYysbxe5LMJ/LBKJemnWtDa+6kTlwFkXrsDvD5PLuBzj2nFdjxjA== Message-ID: <37c1ca96-bffb-5b2c-baee-f8862e1f8b74@ipfire.org> Date: Sat, 9 Jul 2022 12:37:23 +0000 MIME-Version: 1.0 Content-Language: en-US To: "IPFire: Development" <development@lists.ipfire.org> From: =?utf-8?q?Peter_M=C3=BCller?= <peter.mueller@ipfire.org> Subject: [PATCH] util-linux: Do not ship broken symlink "/usr/bin/x86_64" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: development@lists.ipfire.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: IPFire development talk <development.lists.ipfire.org> List-Unsubscribe: <https://lists.ipfire.org/mailman/options/development>, <mailto:development-request@lists.ipfire.org?subject=unsubscribe> List-Archive: <http://lists.ipfire.org/pipermail/development/> List-Post: <mailto:development@lists.ipfire.org> List-Help: <mailto:development-request@lists.ipfire.org?subject=help> List-Subscribe: <https://lists.ipfire.org/mailman/listinfo/development>, <mailto:development-request@lists.ipfire.org?subject=subscribe> Errors-To: development-bounces@lists.ipfire.org Sender: "Development" <development-bounces@lists.ipfire.org> |
Series |
util-linux: Do not ship broken symlink "/usr/bin/x86_64"
|
|
Commit Message
Peter Müller
July 9, 2022, 12:37 p.m. UTC
This file points to /usr/bin/setarch, which we do not ship on any
architecture. As it serves no obvious purpose on IPFire installations,
we may as well not ship it entirely.
Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
config/rootfiles/common/x86_64/util-linux | 2 +-
config/rootfiles/core/170/update.sh | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
Comments
Reviewed-by: Adolf Belka <adolf.belka@ipfire.org> On 09/07/2022 14:37, Peter Müller wrote: > This file points to /usr/bin/setarch, which we do not ship on any > architecture. As it serves no obvious purpose on IPFire installations, > we may as well not ship it entirely. > > Signed-off-by: Peter Müller <peter.mueller@ipfire.org> > --- > config/rootfiles/common/x86_64/util-linux | 2 +- > config/rootfiles/core/170/update.sh | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux > index bd862b557..de78f65c2 100644 > --- a/config/rootfiles/common/x86_64/util-linux > +++ b/config/rootfiles/common/x86_64/util-linux > @@ -103,7 +103,7 @@ usr/bin/uclampset > usr/bin/uuidgen > usr/bin/uuidparse > #usr/bin/whereis > -usr/bin/x86_64 > +#usr/bin/x86_64 > #usr/include/blkid > #usr/include/blkid/blkid.h > #usr/include/libfdisk > diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh > index e3f93df57..5d8903189 100644 > --- a/config/rootfiles/core/170/update.sh > +++ b/config/rootfiles/core/170/update.sh > @@ -57,6 +57,7 @@ rm -rvf \ > /sbin/ifcfg \ > /sbin/routef \ > /sbin/rtpr \ > + /usr/bin/x86_64 \ > /usr/lib/libbfd-2.36.* \ > /usr/lib/libbind9-9.16.2* \ > /usr/lib/libdnet* \
Hello *, for the records, this causes a rather ugly warning at the end of the distributions' build procedure: > Checking Logfiles for new Files > Error! '/x86_64' in rootfiles files found! > ./config/rootfiles/core/170/update.sh: /usr/bin/x86_64 \ > Replace by xxxMACHINExxx ! Can be safely ignored, but may cause some confusion at the first glance. Thanks, and best regards, Peter Müller > This file points to /usr/bin/setarch, which we do not ship on any > architecture. As it serves no obvious purpose on IPFire installations, > we may as well not ship it entirely. > > Signed-off-by: Peter Müller <peter.mueller@ipfire.org> > --- > config/rootfiles/common/x86_64/util-linux | 2 +- > config/rootfiles/core/170/update.sh | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux > index bd862b557..de78f65c2 100644 > --- a/config/rootfiles/common/x86_64/util-linux > +++ b/config/rootfiles/common/x86_64/util-linux > @@ -103,7 +103,7 @@ usr/bin/uclampset > usr/bin/uuidgen > usr/bin/uuidparse > #usr/bin/whereis > -usr/bin/x86_64 > +#usr/bin/x86_64 > #usr/include/blkid > #usr/include/blkid/blkid.h > #usr/include/libfdisk > diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh > index e3f93df57..5d8903189 100644 > --- a/config/rootfiles/core/170/update.sh > +++ b/config/rootfiles/core/170/update.sh > @@ -57,6 +57,7 @@ rm -rvf \ > /sbin/ifcfg \ > /sbin/routef \ > /sbin/rtpr \ > + /usr/bin/x86_64 \ > /usr/lib/libbfd-2.36.* \ > /usr/lib/libbind9-9.16.2* \ > /usr/lib/libdnet* \
Hello, Err, yes, but what do we gain from dropping this? Does it hurt us to be compatible with any general purpose distribution? -Michael > On 9 Jul 2022, at 14:37, Peter Müller <peter.mueller@ipfire.org> wrote: > > This file points to /usr/bin/setarch, which we do not ship on any > architecture. As it serves no obvious purpose on IPFire installations, > we may as well not ship it entirely. > > Signed-off-by: Peter Müller <peter.mueller@ipfire.org> > --- > config/rootfiles/common/x86_64/util-linux | 2 +- > config/rootfiles/core/170/update.sh | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux > index bd862b557..de78f65c2 100644 > --- a/config/rootfiles/common/x86_64/util-linux > +++ b/config/rootfiles/common/x86_64/util-linux > @@ -103,7 +103,7 @@ usr/bin/uclampset > usr/bin/uuidgen > usr/bin/uuidparse > #usr/bin/whereis > -usr/bin/x86_64 > +#usr/bin/x86_64 > #usr/include/blkid > #usr/include/blkid/blkid.h > #usr/include/libfdisk > diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh > index e3f93df57..5d8903189 100644 > --- a/config/rootfiles/core/170/update.sh > +++ b/config/rootfiles/core/170/update.sh > @@ -57,6 +57,7 @@ rm -rvf \ > /sbin/ifcfg \ > /sbin/routef \ > /sbin/rtpr \ > + /usr/bin/x86_64 \ > /usr/lib/libbfd-2.36.* \ > /usr/lib/libbind9-9.16.2* \ > /usr/lib/libdnet* \ > -- > 2.35.3
Hello Michael, thanks for your reply. > Hello, > > Err, yes, but what do we gain from dropping this? Well, shipping a broken symlink did not seem to serve any purpose to me. Or were you referring to not shipping /usr/bin/setarch? Thanks, and best regards, Peter Müller > > Does it hurt us to be compatible with any general purpose distribution? > > -Michael > >> On 9 Jul 2022, at 14:37, Peter Müller <peter.mueller@ipfire.org> wrote: >> >> This file points to /usr/bin/setarch, which we do not ship on any >> architecture. As it serves no obvious purpose on IPFire installations, >> we may as well not ship it entirely. >> >> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >> --- >> config/rootfiles/common/x86_64/util-linux | 2 +- >> config/rootfiles/core/170/update.sh | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux >> index bd862b557..de78f65c2 100644 >> --- a/config/rootfiles/common/x86_64/util-linux >> +++ b/config/rootfiles/common/x86_64/util-linux >> @@ -103,7 +103,7 @@ usr/bin/uclampset >> usr/bin/uuidgen >> usr/bin/uuidparse >> #usr/bin/whereis >> -usr/bin/x86_64 >> +#usr/bin/x86_64 >> #usr/include/blkid >> #usr/include/blkid/blkid.h >> #usr/include/libfdisk >> diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh >> index e3f93df57..5d8903189 100644 >> --- a/config/rootfiles/core/170/update.sh >> +++ b/config/rootfiles/core/170/update.sh >> @@ -57,6 +57,7 @@ rm -rvf \ >> /sbin/ifcfg \ >> /sbin/routef \ >> /sbin/rtpr \ >> + /usr/bin/x86_64 \ >> /usr/lib/libbfd-2.36.* \ >> /usr/lib/libbind9-9.16.2* \ >> /usr/lib/libdnet* \ >> -- >> 2.35.3 >
Oh no, we should of course ship setarch or drop x86_64. Either or the other. I missed that we were talking about a *broken* symlink here. > On 12 Jul 2022, at 11:44, Peter Müller <peter.mueller@ipfire.org> wrote: > > Hello Michael, > > thanks for your reply. > >> Hello, >> >> Err, yes, but what do we gain from dropping this? > > Well, shipping a broken symlink did not seem to serve any purpose to me. Or were > you referring to not shipping /usr/bin/setarch? > > Thanks, and best regards, > Peter Müller > >> >> Does it hurt us to be compatible with any general purpose distribution? >> >> -Michael >> >>> On 9 Jul 2022, at 14:37, Peter Müller <peter.mueller@ipfire.org> wrote: >>> >>> This file points to /usr/bin/setarch, which we do not ship on any >>> architecture. As it serves no obvious purpose on IPFire installations, >>> we may as well not ship it entirely. >>> >>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >>> --- >>> config/rootfiles/common/x86_64/util-linux | 2 +- >>> config/rootfiles/core/170/update.sh | 1 + >>> 2 files changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux >>> index bd862b557..de78f65c2 100644 >>> --- a/config/rootfiles/common/x86_64/util-linux >>> +++ b/config/rootfiles/common/x86_64/util-linux >>> @@ -103,7 +103,7 @@ usr/bin/uclampset >>> usr/bin/uuidgen >>> usr/bin/uuidparse >>> #usr/bin/whereis >>> -usr/bin/x86_64 >>> +#usr/bin/x86_64 >>> #usr/include/blkid >>> #usr/include/blkid/blkid.h >>> #usr/include/libfdisk >>> diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh >>> index e3f93df57..5d8903189 100644 >>> --- a/config/rootfiles/core/170/update.sh >>> +++ b/config/rootfiles/core/170/update.sh >>> @@ -57,6 +57,7 @@ rm -rvf \ >>> /sbin/ifcfg \ >>> /sbin/routef \ >>> /sbin/rtpr \ >>> + /usr/bin/x86_64 \ >>> /usr/lib/libbfd-2.36.* \ >>> /usr/lib/libbind9-9.16.2* \ >>> /usr/lib/libdnet* \ >>> -- >>> 2.35.3 >>
Okay, then I'll vote for dropping the broken symlink, as nobody has asked for "setarch" in years. > Oh no, we should of course ship setarch or drop x86_64. Either or the other. > > I missed that we were talking about a *broken* symlink here. > >> On 12 Jul 2022, at 11:44, Peter Müller <peter.mueller@ipfire.org> wrote: >> >> Hello Michael, >> >> thanks for your reply. >> >>> Hello, >>> >>> Err, yes, but what do we gain from dropping this? >> >> Well, shipping a broken symlink did not seem to serve any purpose to me. Or were >> you referring to not shipping /usr/bin/setarch? >> >> Thanks, and best regards, >> Peter Müller >> >>> >>> Does it hurt us to be compatible with any general purpose distribution? >>> >>> -Michael >>> >>>> On 9 Jul 2022, at 14:37, Peter Müller <peter.mueller@ipfire.org> wrote: >>>> >>>> This file points to /usr/bin/setarch, which we do not ship on any >>>> architecture. As it serves no obvious purpose on IPFire installations, >>>> we may as well not ship it entirely. >>>> >>>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >>>> --- >>>> config/rootfiles/common/x86_64/util-linux | 2 +- >>>> config/rootfiles/core/170/update.sh | 1 + >>>> 2 files changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux >>>> index bd862b557..de78f65c2 100644 >>>> --- a/config/rootfiles/common/x86_64/util-linux >>>> +++ b/config/rootfiles/common/x86_64/util-linux >>>> @@ -103,7 +103,7 @@ usr/bin/uclampset >>>> usr/bin/uuidgen >>>> usr/bin/uuidparse >>>> #usr/bin/whereis >>>> -usr/bin/x86_64 >>>> +#usr/bin/x86_64 >>>> #usr/include/blkid >>>> #usr/include/blkid/blkid.h >>>> #usr/include/libfdisk >>>> diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh >>>> index e3f93df57..5d8903189 100644 >>>> --- a/config/rootfiles/core/170/update.sh >>>> +++ b/config/rootfiles/core/170/update.sh >>>> @@ -57,6 +57,7 @@ rm -rvf \ >>>> /sbin/ifcfg \ >>>> /sbin/routef \ >>>> /sbin/rtpr \ >>>> + /usr/bin/x86_64 \ >>>> /usr/lib/libbfd-2.36.* \ >>>> /usr/lib/libbind9-9.16.2* \ >>>> /usr/lib/libdnet* \ >>>> -- >>>> 2.35.3 >>> >
Agreed. > On 12 Jul 2022, at 12:42, Peter Müller <peter.mueller@ipfire.org> wrote: > > Okay, then I'll vote for dropping the broken symlink, as nobody has asked for "setarch" in years. > >> Oh no, we should of course ship setarch or drop x86_64. Either or the other. >> >> I missed that we were talking about a *broken* symlink here. >> >>> On 12 Jul 2022, at 11:44, Peter Müller <peter.mueller@ipfire.org> wrote: >>> >>> Hello Michael, >>> >>> thanks for your reply. >>> >>>> Hello, >>>> >>>> Err, yes, but what do we gain from dropping this? >>> >>> Well, shipping a broken symlink did not seem to serve any purpose to me. Or were >>> you referring to not shipping /usr/bin/setarch? >>> >>> Thanks, and best regards, >>> Peter Müller >>> >>>> >>>> Does it hurt us to be compatible with any general purpose distribution? >>>> >>>> -Michael >>>> >>>>> On 9 Jul 2022, at 14:37, Peter Müller <peter.mueller@ipfire.org> wrote: >>>>> >>>>> This file points to /usr/bin/setarch, which we do not ship on any >>>>> architecture. As it serves no obvious purpose on IPFire installations, >>>>> we may as well not ship it entirely. >>>>> >>>>> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> >>>>> --- >>>>> config/rootfiles/common/x86_64/util-linux | 2 +- >>>>> config/rootfiles/core/170/update.sh | 1 + >>>>> 2 files changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux >>>>> index bd862b557..de78f65c2 100644 >>>>> --- a/config/rootfiles/common/x86_64/util-linux >>>>> +++ b/config/rootfiles/common/x86_64/util-linux >>>>> @@ -103,7 +103,7 @@ usr/bin/uclampset >>>>> usr/bin/uuidgen >>>>> usr/bin/uuidparse >>>>> #usr/bin/whereis >>>>> -usr/bin/x86_64 >>>>> +#usr/bin/x86_64 >>>>> #usr/include/blkid >>>>> #usr/include/blkid/blkid.h >>>>> #usr/include/libfdisk >>>>> diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh >>>>> index e3f93df57..5d8903189 100644 >>>>> --- a/config/rootfiles/core/170/update.sh >>>>> +++ b/config/rootfiles/core/170/update.sh >>>>> @@ -57,6 +57,7 @@ rm -rvf \ >>>>> /sbin/ifcfg \ >>>>> /sbin/routef \ >>>>> /sbin/rtpr \ >>>>> + /usr/bin/x86_64 \ >>>>> /usr/lib/libbfd-2.36.* \ >>>>> /usr/lib/libbind9-9.16.2* \ >>>>> /usr/lib/libdnet* \ >>>>> -- >>>>> 2.35.3 >>>> >>
diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux index bd862b557..de78f65c2 100644 --- a/config/rootfiles/common/x86_64/util-linux +++ b/config/rootfiles/common/x86_64/util-linux @@ -103,7 +103,7 @@ usr/bin/uclampset usr/bin/uuidgen usr/bin/uuidparse #usr/bin/whereis -usr/bin/x86_64 +#usr/bin/x86_64 #usr/include/blkid #usr/include/blkid/blkid.h #usr/include/libfdisk diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh index e3f93df57..5d8903189 100644 --- a/config/rootfiles/core/170/update.sh +++ b/config/rootfiles/core/170/update.sh @@ -57,6 +57,7 @@ rm -rvf \ /sbin/ifcfg \ /sbin/routef \ /sbin/rtpr \ + /usr/bin/x86_64 \ /usr/lib/libbfd-2.36.* \ /usr/lib/libbind9-9.16.2* \ /usr/lib/libdnet* \