kmod: Update to 29

Message ID 35e9cc23-d37f-c45f-dfbe-acedd98d1a41@ipfire.org
State Accepted
Commit ddd8d0705b3320f890d45c0222de3df0dad0bb76
Headers show
Series kmod: Update to 29 | expand

Commit Message

Peter Müller Jan. 4, 2022, 6:29 p.m. UTC
Full changelog as given in the NEWS file:

kmod 29
=======

- Improvements
	- Add support to use /usr/local as a place for configuration files. This makes it easier
	  to install locally without overriding distro files.

- Bug fixes
	- Fix `modinfo -F` when module is builtin: when we asked by a specific field from modinfo,
	  it was not working correctly if the module was builtin

	- Documentation fixes on precedence order of /etc and /run: the correct order is
	  /etc/modprobe.d, /run/modprobe.d, /lib/modprobe.d

	- Fix the priority order that we use for searching configuration files. The
	  correct one is /etc, /run, /usr/local/lib, /lib, for both modprobe.d
	  and depmo.d

	- Fix kernel command line parsing when there are quotes present. Grub
	  mangles the command line and changes it from 'module.option="val with
	  spaces"' to '"module.option=val with spaces"'. Although this is weird
	  behavior and grub could have been fixed, the kernel understands it
	  correctly for builtin modules. So change libkmod to also parse it
	  correctly. This also brings another hidden behavior from the kernel:
	  newline in the kernel command line is also allowed and can be used to
	  separate options.

	- Fix a memory leak, overflow and double free on error path

	- Fix documentation for return value from kmod_module_get_info(): we
	  return the number of entries we added to the list

	- Fix output of modules.builtin.alias.bin index: we were writing an empty file due to
	  the misuse of kmod_module_get_info()

- Infra/internal
	- Retire integration with semaphoreci

	- Declare the github mirror also as an official upstream source: now besides accepting
	  patches via mailing list, PRs on github are also acceptable

	- Misc improvements to testsuite, so we can use it reliably regardless
	  of the configuration used: now tests will skip if we don't have the
	  build dependencies)

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
---
 config/rootfiles/common/kmod | 2 +-
 lfs/kmod                     | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Michael Tremer Jan. 4, 2022, 10:10 p.m. UTC | #1
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>

> On 4 Jan 2022, at 18:29, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> Full changelog as given in the NEWS file:
> 
> kmod 29
> =======
> 
> - Improvements
> 	- Add support to use /usr/local as a place for configuration files. This makes it easier
> 	  to install locally without overriding distro files.
> 
> - Bug fixes
> 	- Fix `modinfo -F` when module is builtin: when we asked by a specific field from modinfo,
> 	  it was not working correctly if the module was builtin
> 
> 	- Documentation fixes on precedence order of /etc and /run: the correct order is
> 	  /etc/modprobe.d, /run/modprobe.d, /lib/modprobe.d
> 
> 	- Fix the priority order that we use for searching configuration files. The
> 	  correct one is /etc, /run, /usr/local/lib, /lib, for both modprobe.d
> 	  and depmo.d
> 
> 	- Fix kernel command line parsing when there are quotes present. Grub
> 	  mangles the command line and changes it from 'module.option="val with
> 	  spaces"' to '"module.option=val with spaces"'. Although this is weird
> 	  behavior and grub could have been fixed, the kernel understands it
> 	  correctly for builtin modules. So change libkmod to also parse it
> 	  correctly. This also brings another hidden behavior from the kernel:
> 	  newline in the kernel command line is also allowed and can be used to
> 	  separate options.
> 
> 	- Fix a memory leak, overflow and double free on error path
> 
> 	- Fix documentation for return value from kmod_module_get_info(): we
> 	  return the number of entries we added to the list
> 
> 	- Fix output of modules.builtin.alias.bin index: we were writing an empty file due to
> 	  the misuse of kmod_module_get_info()
> 
> - Infra/internal
> 	- Retire integration with semaphoreci
> 
> 	- Declare the github mirror also as an official upstream source: now besides accepting
> 	  patches via mailing list, PRs on github are also acceptable
> 
> 	- Misc improvements to testsuite, so we can use it reliably regardless
> 	  of the configuration used: now tests will skip if we don't have the
> 	  build dependencies)
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> config/rootfiles/common/kmod | 2 +-
> lfs/kmod                     | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/config/rootfiles/common/kmod b/config/rootfiles/common/kmod
> index 56806fd1f..f46db860b 100644
> --- a/config/rootfiles/common/kmod
> +++ b/config/rootfiles/common/kmod
> @@ -9,6 +9,6 @@ sbin/rmmod
> #usr/lib/libkmod.la
> #usr/lib/libkmod.so
> usr/lib/libkmod.so.2
> -usr/lib/libkmod.so.2.3.6
> +usr/lib/libkmod.so.2.3.7
> #usr/lib/pkgconfig/libkmod.pc
> #usr/share/bash-completion/completions/kmod
> diff --git a/lfs/kmod b/lfs/kmod
> index 3d9acd899..5499002b6 100644
> --- a/lfs/kmod
> +++ b/lfs/kmod
> @@ -1,7 +1,7 @@
> ###############################################################################
> #                                                                             #
> # IPFire.org - A linux based firewall                                         #
> -# Copyright (C) 2007-2018  IPFire Team  <info@ipfire.org>                     #
> +# Copyright (C) 2007-2022  IPFire Team  <info@ipfire.org>                     #
> #                                                                             #
> # This program is free software: you can redistribute it and/or modify        #
> # it under the terms of the GNU General Public License as published by        #
> @@ -24,7 +24,7 @@
> 
> include Config
> 
> -VER        = 28
> +VER        = 29
> 
> THISAPP    = kmod-$(VER)
> DL_FILE    = $(THISAPP).tar.xz
> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_MD5 = 0a2b887b1b3dfb8c0b3f41f598203e56
> +$(DL_FILE)_MD5 = e81e63acd80697d001c8d85c1acb38a0
> 
> install : $(TARGET)
> 
> -- 
> 2.26.2

Patch

diff --git a/config/rootfiles/common/kmod b/config/rootfiles/common/kmod
index 56806fd1f..f46db860b 100644
--- a/config/rootfiles/common/kmod
+++ b/config/rootfiles/common/kmod
@@ -9,6 +9,6 @@  sbin/rmmod
 #usr/lib/libkmod.la
 #usr/lib/libkmod.so
 usr/lib/libkmod.so.2
-usr/lib/libkmod.so.2.3.6
+usr/lib/libkmod.so.2.3.7
 #usr/lib/pkgconfig/libkmod.pc
 #usr/share/bash-completion/completions/kmod
diff --git a/lfs/kmod b/lfs/kmod
index 3d9acd899..5499002b6 100644
--- a/lfs/kmod
+++ b/lfs/kmod
@@ -1,7 +1,7 @@ 
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2018  IPFire Team  <info@ipfire.org>                     #
+# Copyright (C) 2007-2022  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -24,7 +24,7 @@ 
 
 include Config
 
-VER        = 28
+VER        = 29
 
 THISAPP    = kmod-$(VER)
 DL_FILE    = $(THISAPP).tar.xz
@@ -40,7 +40,7 @@  objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = 0a2b887b1b3dfb8c0b3f41f598203e56
+$(DL_FILE)_MD5 = e81e63acd80697d001c8d85c1acb38a0
 
 install : $(TARGET)