backup.pl: Restart openvpn daemons after restore.

Message ID 20250823134609.12835-1-adolf.belka@ipfire.org
State Accepted
Commit 97469fbdd20c7c47b9d1f2df6b57f60ccda16560
Headers
Series backup.pl: Restart openvpn daemons after restore. |

Commit Message

Adolf Belka 23 Aug 2025, 1:46 p.m. UTC
- As the daemons are running when the restore is done then if the daemons are not
   restarted the running daemon stays with the previous config and not with the restored
   version.

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/backup/backup.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
  

Comments

Michael Tremer 23 Aug 2025, 2:57 p.m. UTC | #1
Thank you. I even remembered to merge it into master.

> On 23 Aug 2025, at 14:46, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - As the daemons are running when the restore is done then if the daemons are not
>   restarted the running daemon stays with the previous config and not with the restored
>   version.
> 
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> config/backup/backup.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/config/backup/backup.pl b/config/backup/backup.pl
> index c9bc14355..e79f510c6 100644
> --- a/config/backup/backup.pl
> +++ b/config/backup/backup.pl
> @@ -349,8 +349,10 @@ restore_backup() {
> rm /var/log/pakfire.log
> fi
> 
> - # Update the OpenVPN configuration
> + # Update the OpenVPN configuration and restart the openvpn daemons
> sudo -u nobody /srv/web/ipfire/cgi-bin/ovpnmain.cgi
> + /etc/init.d/openvpn-n2n restart
> + /etc/init.d/openvpn-rw restart
> 
> return 0
> }
> -- 
> 2.50.1
> 
>
  

Patch

diff --git a/config/backup/backup.pl b/config/backup/backup.pl
index c9bc14355..e79f510c6 100644
--- a/config/backup/backup.pl
+++ b/config/backup/backup.pl
@@ -349,8 +349,10 @@  restore_backup() {
 		rm /var/log/pakfire.log
 	fi
 
-	# Update the OpenVPN configuration
+	# Update the OpenVPN configuration and restart the openvpn daemons
 	sudo -u nobody /srv/web/ipfire/cgi-bin/ovpnmain.cgi
+	/etc/init.d/openvpn-n2n restart
+	/etc/init.d/openvpn-rw restart
 
 	return 0
 }