diff mbox series

[v2] setup: v2 Fixes bug10245 - removal of so called non-local network stop

Message ID 20250619160418.2398881-1-adolf.belka@ipfire.org
State Staged
Commit a21bc6e7ee0aab5b134e5058855eb634e9c892f1
Headers
Series [v2] setup: v2 Fixes bug10245 - removal of so called non-local network stop |

Commit Message

Adolf Belka June 19, 2025, 4:04 p.m. UTC 
  - In the setup menu if the OK button is pressed when it asks if you want to change any
   of the interfaces then the red, blue and orange interfaces are stopped. However if
   none of the interfaces are changed then the network restart code does not get used.
- This results in the system ending up with only the green interfrace being UP and
   connected.
- This patch removes the command that stops the red, blue & orange interfaces but leaves
   the green one running. It seems to not bhe needed and if the OK button is pressed
   on the Drivers and card assignments window but no change made then the IPFire system
   is left with only the green interface connected.
- This command has been present since at least Core Update 30 and the bug was originally
   raised in 2012.
- I tested out this v2 code on my vm testbed and everything worked fine and if any
   change was made then when leaving the Networking section the Network and Unbound were
   restarted.

Fixes: bug10245
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 src/setup/networking.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Michael Tremer June 23, 2025, 10:39 a.m. UTC | #1 
Okay. This makes perfect sense.

There is no need to stop the network before any changes would be done.

I don’t know why I didn’t get it the first time you posted this. Sorry.

-Michael

> On 19 Jun 2025, at 17:04, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - In the setup menu if the OK button is pressed when it asks if you want to change any
>   of the interfaces then the red, blue and orange interfaces are stopped. However if
>   none of the interfaces are changed then the network restart code does not get used.
> - This results in the system ending up with only the green interfrace being UP and
>   connected.
> - This patch removes the command that stops the red, blue & orange interfaces but leaves
>   the green one running. It seems to not bhe needed and if the OK button is pressed
>   on the Drivers and card assignments window but no change made then the IPFire system
>   is left with only the green interface connected.
> - This command has been present since at least Core Update 30 and the bug was originally
>   raised in 2012.
> - I tested out this v2 code on my vm testbed and everything worked fine and if any
>   change was made then when leaving the Networking section the Network and Unbound were
>   restarted.
> 
> Fixes: bug10245
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> src/setup/networking.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/src/setup/networking.c b/src/setup/networking.c
> index 8d398f365..98018b7f6 100644
> --- a/src/setup/networking.c
> +++ b/src/setup/networking.c
> @@ -420,9 +420,6 @@ int changedrivers(void)
> errorbox(_("Unable to open settings file"));
> return 0;
> }
> - if (automode == 0)
> - runcommandwithstatus("/etc/rc.d/init.d/network stop red blue orange",
> - _("Networking"), _("Restarting non-local network..."), NULL);
> 
> findkey(kv, "CONFIG_TYPE", temp); configtype = atol(temp);
> if (configtype == 1)
> -- 
> 2.49.0
> 
>
diff mbox series

Patch

diff --git a/src/setup/networking.c b/src/setup/networking.c
index 8d398f365..98018b7f6 100644
--- a/src/setup/networking.c
+++ b/src/setup/networking.c
@@ -420,9 +420,6 @@  int changedrivers(void)
 		errorbox(_("Unable to open settings file"));
 		return 0;
 	}
-	if (automode == 0)
-		runcommandwithstatus("/etc/rc.d/init.d/network stop red blue orange",
-			_("Networking"), _("Restarting non-local network..."), NULL);
 
 	findkey(kv, "CONFIG_TYPE", temp); configtype = atol(temp);
 	if (configtype == 1)