ipblocklist-functions.pl: Allow downloading empty blocklists

Message ID 20250524081436.7395-1-stefan.schantl@ipfire.org
State Staged
Commit 476277d0febf510489c314bc950f91ec6efb717b
Headers
Series ipblocklist-functions.pl: Allow downloading empty blocklists |

Commit Message

Stefan Schantl May 24, 2025, 8:14 a.m. UTC
  Some blocklist providers does serve blocklists for current events or
with very limited updates. Therefore there is a chance such a blocklist
could be empty for a certain time.

This patch allows to replace an existing filled blocklist by an empty
one and vice versa.

Fixes #13804.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 config/cfgroot/ipblocklist-functions.pl | 9 ---------
 1 file changed, 9 deletions(-)
  

Patch

diff --git a/config/cfgroot/ipblocklist-functions.pl b/config/cfgroot/ipblocklist-functions.pl
index 665dadb4c..b2d0a1a49 100644
--- a/config/cfgroot/ipblocklist-functions.pl
+++ b/config/cfgroot/ipblocklist-functions.pl
@@ -91,8 +91,6 @@  sub get_ipset_db_file($) {
 ##   nothing - On success
 ##   not_modified - In case the servers responds with "Not modified" (304)
 ##   dl_error - If the requested blocklist could not be downloaded.
-##   empty_list - The downloaded blocklist is empty, or the parser was not able to parse
-##                it correctly.
 #
 sub download_and_create_blocklist($) {
 	my ($list) = @_;
@@ -226,13 +224,6 @@  sub download_and_create_blocklist($) {
 		push(@blocklist, $address);
 	}
 
-	# Check if the content could be parsed correctly and the blocklist
-	# contains at least one item.
-	unless(@blocklist) {
-		# No entries - exit and return "empty_list".
-		return "empty_list";
-	}
-
 	# Get amount of entries in the blocklist array.
 	my $list_entries = scalar(@blocklist);