[1/4] unbound-dhcp-leases-bridge: Don't export expired leases to Unbound

Message ID 20241021163849.1265183-1-michael.tremer@ipfire.org
State New
Headers
Series [1/4] unbound-dhcp-leases-bridge: Don't export expired leases to Unbound |

Commit Message

Michael Tremer Oct. 21, 2024, 4:38 p.m. UTC
  Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 config/unbound/unbound-dhcp-leases-bridge | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Bernhard Bitsch Oct. 21, 2024, 4:42 p.m. UTC | #1
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 21.10.2024 um 18:38 schrieb Michael Tremer:
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>   config/unbound/unbound-dhcp-leases-bridge | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound/unbound-dhcp-leases-bridge
> index 986fae2d2..bc944a073 100644
> --- a/config/unbound/unbound-dhcp-leases-bridge
> +++ b/config/unbound/unbound-dhcp-leases-bridge
> @@ -276,7 +276,7 @@ class UnboundDHCPLeasesBridge(object):
>   				if lease.has_expired():
>   					log.debug("    Expired")
>   
> -		self.unbound.update_dhcp_leases(self.leases)
> +		self.unbound.update_dhcp_leases([l for l in self.leases if not l.has_expired()])
>   
>   	def _add_lease(self, lease):
>   		# Skip leases without an FQDN
  

Patch

diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound/unbound-dhcp-leases-bridge
index 986fae2d2..bc944a073 100644
--- a/config/unbound/unbound-dhcp-leases-bridge
+++ b/config/unbound/unbound-dhcp-leases-bridge
@@ -276,7 +276,7 @@  class UnboundDHCPLeasesBridge(object):
 				if lease.has_expired():
 					log.debug("    Expired")
 
-		self.unbound.update_dhcp_leases(self.leases)
+		self.unbound.update_dhcp_leases([l for l in self.leases if not l.has_expired()])
 
 	def _add_lease(self, lease):
 		# Skip leases without an FQDN