squid: Comment out access.log in rootfile

Message ID 20240708114842.4444-1-adolf.belka@ipfire.org
State Staged
Commit 516d541c29bce32e1241b319fc72eb4d59ea3a58
Headers
Series squid: Comment out access.log in rootfile |

Commit Message

Adolf Belka July 8, 2024, 11:48 a.m. UTC
  - Everytime an update has been done on squid the access.log file has been replaced with an
   empty file, losing whatever messages have been in the log.
- This has been the case since squid was implemented in IPFire.
- Update of rootfile to comment out var/log/squid/access.log

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/rootfiles/common/squid | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Adolf Belka July 8, 2024, 11:55 a.m. UTC | #1
Hi All,

Forgot to add a tag to identify that this was discovered by Peter Müller
https://lists.ipfire.org/hyperkitty/list/development@lists.ipfire.org/thread/QNRP6VHFPE5MSXQ45S4WLH36HRWCIYWP/

Regards,
Adolf.


On 08/07/2024 13:48, Adolf Belka wrote:
> - Everytime an update has been done on squid the access.log file has been replaced with an
>     empty file, losing whatever messages have been in the log.
> - This has been the case since squid was implemented in IPFire.
> - Update of rootfile to comment out var/log/squid/access.log
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   config/rootfiles/common/squid | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/rootfiles/common/squid b/config/rootfiles/common/squid
> index 50c77a114..4f92469e3 100644
> --- a/config/rootfiles/common/squid
> +++ b/config/rootfiles/common/squid
> @@ -2345,6 +2345,6 @@ var/ipfire/updatexlrator/bin/lscache
>   var/ipfire/updatexlrator/updxlrator-lib.pl
>   var/log/cache
>   #var/log/squid
> -var/log/squid/access.log
> +#var/log/squid/access.log
>   var/log/updatexlrator
>   #var/logs
  
Michael Tremer July 8, 2024, 3:33 p.m. UTC | #2
Thank you. Merged.

> On 8 Jul 2024, at 12:48, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - Everytime an update has been done on squid the access.log file has been replaced with an
>   empty file, losing whatever messages have been in the log.
> - This has been the case since squid was implemented in IPFire.
> - Update of rootfile to comment out var/log/squid/access.log
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> config/rootfiles/common/squid | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/rootfiles/common/squid b/config/rootfiles/common/squid
> index 50c77a114..4f92469e3 100644
> --- a/config/rootfiles/common/squid
> +++ b/config/rootfiles/common/squid
> @@ -2345,6 +2345,6 @@ var/ipfire/updatexlrator/bin/lscache
> var/ipfire/updatexlrator/updxlrator-lib.pl
> var/log/cache
> #var/log/squid
> -var/log/squid/access.log
> +#var/log/squid/access.log
> var/log/updatexlrator
> #var/logs
> -- 
> 2.45.2
>
  

Patch

diff --git a/config/rootfiles/common/squid b/config/rootfiles/common/squid
index 50c77a114..4f92469e3 100644
--- a/config/rootfiles/common/squid
+++ b/config/rootfiles/common/squid
@@ -2345,6 +2345,6 @@  var/ipfire/updatexlrator/bin/lscache
 var/ipfire/updatexlrator/updxlrator-lib.pl
 var/log/cache
 #var/log/squid
-var/log/squid/access.log
+#var/log/squid/access.log
 var/log/updatexlrator
 #var/logs